well im trying to get hills and forests to give one a 50% attack bonus. how would i do that?

lol I'm doing the same thing. If you want to wait I'll be releasing it as a mod comp in probably less than a week.Except I'm making bonouses like attacking from a hill +25% forest +50% same as the defence values.

well im trying to get hills and forests to give one a 50% attack bonus. how would i do that?

Warlords has a hills attack bonus already defined on the unit. To add a feature attack bonus you will need an SDK change (we have that change in FfH so you may want to checkout our source code).