Sounds complex, but I'll look into it, thanks!I don't know about XML, but Lua-wise, if you use Machiavelli's Unit Created snippet or whoward's DLL (it has a GameEvents for that), checking on creation the unit's plot you can get the city and check for the Building, adding the Chariotry-related Promotion directly to the unit!
That's what I'm thinking: the question is how?
function ChariotryPromotion(playerID, unitID)
local pPlayer = Players[playerID]
local pUnit = pPlayer:GetUnitByID(unitID)
local pPlot = pUnit:GetPlot()
local pCity = pPlot:GetPlotCity()
if pPlot:IsCity() and pCity:IsHasBuilding(GameInfoTypes["BUILDING_CHARIOTRY"]) and pUnit:GetUnitType() == GameInfoTypes["UNIT_CHARIOT_TYPE_II"] then
pUnit:SetHasPromotion(GameInfoTypes["PROMOTION_CHARIOTRY"], true)
end
end
LuaEvents.SerialEventUnitCreatedGood.Add(ChariotryPromotion)function ChariotryPromotion(iPlayer, iUnit, iUnitType, iPlotX, iPlotY)
local pPlayer = Players[iPlayer]
local pUnit = pPlayer:GetUnitByID(iUnit)
local pPlot = Map.GetPlot(iPlotX, iPlotY) -- or local pPlot = pUnit:GetPlot()
local pCity = pPlot:GetPlotCity()
if pPlot:IsCity() and pCity:IsHasBuilding(GameInfoTypes["BUILDING_CHARIOTRY"]) and pUnit:GetUnitType() == GameInfoTypes["UNIT_CHARIOT_TYPE_II"] then
pUnit:SetHasPromotion(GameInfoTypes["PROMOTION_CHARIOTRY"], true)
end
end
GameEvents.UnitCreated.Add(ChariotryPromotion)You are welcome!
Indeed, it'll work for both trained units and bought units alike, but only if the city has a Chariot Maker (I called it "BUILDING_CHARIOTRY" in the code, just replace with the real deal).
Unfortunately the way both <FreePromotion> and <TrainedFreePromotion> work is controlled not so much by the building as by the way the promotion works. Any unit that can accept the promotion is given the promotion. The way that the promotions system works is it will be based generally on UnitCombatType and not on the individual unit (<UnitPromotions_UnitCombats>). Promotions that are tied within the Units & Promotions systems to individual units within a class or within a UnitCombatType are given the promotion immediately upon creation regardless of where or how they are created or what buildings are present in the city where the unit was built (<Unit_FreePromotions>). There's no table within the promotions system so far as I know of that specifies a specific unit is allowed a promotion but don't also give the unit the promotion whenever the unit is created.
I think that may be the brick wall in waiting for you to bang your head against. I'm not sure what all would be required either to get it to work.
For mods that don't use later eras, however, you can recycle existing ones. I use UNITCOMBAT_GUN for horse-mounted archers and UNITCOMBAT_ARMOR for elephant-mounted units. That lets me keep all UnitCombats "clean" so I can use them for promotion assignments.
