stuck creating my 1st civilisation

daylightend · Oct 11, 2014

Hey modders !

I just started my very first mod, a new civ.

I want the trait of my new civ to be something like "+15% production towards military unit construction while at war". I got this idea from the swords into swords into plowshares belief (+x% growth when not at war). When i looked up this belief in CIV5Beliefs.xml I found the following

Spoiler :

I wonder if anyone can tell me where I can find the logic behind "<RequiresPeace>true</RequiresPeace>". And how I can create a state check like that one.

I hope some experienced modders can help me. Thx in advance !

Nutty · Oct 11, 2014

You can't lift logic from a belief and insert it into a unique ability without modding the DLL. However, that's not necessary as it's fairly easy to use Lua to determine peace/war state. Note that several modded civs have UAs that rely on peace/war status from which you can derive your Lua code.

If you want to include being at war with city states you would simply check the status with:

Code:

if (Teams[player:GetTeam()]:GetAtWarCount(true) > 0) then

Otherwise, here's a function lifted from whoward69's post #21 of this thread to determine whether your civ is at war with another civ:

whoward69 said:

Code:

function AtWarWithAnyMajor(iTeam)
  local pTeam = Teams[iTeam]

  for iOtherPlayer = 0, GameDefines.MAX_MAJOR_CIVS - 1, 1 do
    local pOtherPlayer = Players[iOtherPlayer]
    if (pOtherPlayer:IsAlive() and pTeam:IsAtWar(pOtherPlayer:GetTeam())) then
      print(string.format("Team %i is at war with (at least) player %i", iTeam, iOtherPlayer))
      return true
    end
  end

  print(string.format("Team %i is at war with nobody", iTeam))
  return false
end

Either way, if the check was successful, you'd give all of your civ's cities a hidden, unbuildable building. That Building would have entries for all of the CombatClass types (from UnitCombatInfos) in the Building_UnitCombatProductionModifiers table.

Let me know if that's all Greek to you.

LeeS · Oct 11, 2014

Nutty said:
That Building would have entries for all of the CombatClass types (from UnitCombatInfos) in the Building_UnitCombatProductionModifiers table.

Just use <MilitaryProductionModifier>15</MilitaryProductionModifier> directly in <Buildings> to cover all military units. If you want only land units, forex, use this instead:

Code:

<Building_DomainProductionModifiers>
	<Row>
		<BuildingType>BUILDING_NEW_BUILDING</BuildingType>
		<DomainType>DOMAIN_LAND</DomainType>
		<Modifier>15</Modifier>
	</Row>
</Building_DomainProductionModifiers>

Much simpler than doing so through Building_UnitCombatProductionModifiers

Nutty · Oct 11, 2014

Good point. But your second example would apply to civilians...

LeeS · Oct 11, 2014

Nutty said:
Good point. But your second example would apply to civilians...

Yeah...I keep forgetting that.

But then when I do remember it I generally decide to live with it since it's so much easier to add the code, and to look at it later.

Daylightend, here's a list of all the UnitCombat types, the domain (land, sea, air) they fit into, and the units assigned to them. It's for Brave New World, things are slightly different for Vanilla and Gods & Kings. Listing of Units, Domains, and UnitCombat Types

daylightend · Oct 11, 2014

Thanks all for the fast replies !

I understand the part about how to give production bonus to units. I wouldn't know how to "put" a hidden unbuildable building into a city. Probably because I'm very unexperienced with lua.

I've been trying to run a basic lua script that just prints your amount of gold into the log (form this tutorial http://forums.civfanatics.com/showthread.php?t=533853)

Spoiler :

Had no succes yet. I'm probably just missing something thats covered in all the tutorials O.O

Nutty · Oct 11, 2014

Hints:
Is logging turned on in your config.ini?

Do you have your Lua file published as InGameUIAddin?

Before "if pPlayer...", throw in an extra

Code:

print("Hello world")

to see if your Lua is even running...

daylightend · Oct 11, 2014

In config.ini i have:

Spoiler :

assuming that is the loggin you are refering to ?

I included a pic for the file published as InGameUIAddin.

I put the hello world before the if, log still empty.
I also built, and ran the "empty" mod from this thread http://forums.civfanatics.com/showthread.php?t=490438

The hello world print from that mod also doens't show up in my lua.log

Nutty · Oct 11, 2014

What about LoggingEnabled = 1?

daylightend · Oct 11, 2014

Allright, that was 0 :blush:

I turned it on, and this is what i got

log after loading the mod, in game setup screen

Spoiler :

log after starting a game with my modded civ, turn 0 (or 1)

Spoiler :

Still, no hello world. But one step closer

LeeS · Oct 11, 2014

I think you may have missed Nutty's earlier comment about making your lua file an InGameUIAddin within ModBuddy. See whoward69's what ModBuddy setting for what file types tutorial. Without an entry for your lua file in the "Content" tab of the Mod's Properties (within ModBuddy), the game won't have any instructions on what to do with your lua file.

Since your lua file doesn't fit any of the other lua categories (such as a Map Script or a Diplomacy Screen Add-in), and the file is not referenced inside of another lua file via an include("YourFileName.lua") command, you need the InGameUIAddin method of activating your lua file.

------------------------------------------------------------------------------------------------
Also, this would work as a hidden building you can reference within your lua. As coded, it is using the <MilitaryProductionModifier>15</MilitaryProductionModifier> and would therefore increase production of all military units, regardless of domain: land, sea, air. Also as written it would only work for BNW. If you have G&K or Vanilla it would have to be coded differently, and would be best done as a non-hidden building. It is possible to hide buildings in G&K (and I think Vanilla) but it is much much harder to do.

Code:

<GameData>
	<Buildings>
		<Row>
			<Type>BUILDING_MIL_PROD_MODIFIER</Type>
			<BuildingClass>BUILDINGCLASS_MIL_PROD_MODIFIER</BuildingClass>
			<Cost>-1</Cost>
			<FaithCost>-1</FaithCost>
			<PrereqTech>NULL</PrereqTech>
			<GreatWorkCount>-1</GreatWorkCount>
			<ArtDefineTag>NONE</ArtDefineTag>
			<MinAreaSize>-1</MinAreaSize>
			<NeverCapture>true</NeverCapture>
			<HurryCostModifier>-1</HurryCostModifier>
			<IconAtlas>BW_ATLAS_1</IconAtlas>
			<PortraitIndex>19</PortraitIndex>
			<Description>TXT_KEY_MIL_PROD_MODIFIER</Description>
			<NukeImmune>true</NukeImmune>
			[COLOR="Blue"]<MilitaryProductionModifier>15</MilitaryProductionModifier>[/COLOR]
		</Row>
	</Buildings>

	<BuildingClasses>
		<Row>
			<Type>BUILDINGCLASS_MIL_PROD_MODIFIER</Type>
			<DefaultBuilding>BUILDING_MIL_PROD_MODIFIER</DefaultBuilding>
			<Description>TXT_KEY_MIL_PROD_MODIFIER</Description>
		</Row>
	</BuildingClasses>

	<Language_en_US>
		<Row Tag="TXT_KEY_MIL_PROD_MODIFIER">
			<Text>Mil Prod Modifier</Text>
		</Row>
	</Language_en_US>
</GameData>

I highlighted the production modifier command so it would be a little easier to see. You would want to throw the entire code into an XML file, and activate it in the normal way with an OnModActivated > UpdateDatabase > Filename.XML in the Actions tab within ModBuddy.

daylightend · Oct 11, 2014

I think I did including it in the content tab, I included a screenshot of my content tab in post #8 in this thread. I might have screwed something up there since I had to type the file name manualy (drop down menu only reconised .xml files, no the .lua)

LeeS · Oct 11, 2014

daylightend said:
I think I did including it in the content tab, I included a screenshot of my content tab in post #8 in this thread. I might have screwed something up there since I had to type the file name manualy (drop down menu only reconised .xml files, no the .lua)

hmmm...look for typos between the name of the file as it is shown in the Solution Explorer View and as you typed it in under the Content tab. Also look for typos in the file extension (ie, you could have typed ".lau" instead of ".lua")

[edit] I looked at your screenshot and I don't see anything that looks wrong there, but it's fuzzy enough I can't make out whether there are or are not any typos in the name of the file as you entered it. You might just want to redo your Content add-in, using the method I mentioned below. (By this I mean delete the one you have and re-do it using my hint method of selecting the file before any of the other stuff)

Hint for future use: When using the Content Tab, select the File from the drop-down list 1st, before selecting the Type, or entering the info for Name and Description. Lua files will show in the drop-down list if you do it this way.

daylightend · Oct 11, 2014

Allright ! it worked. I deleted the lua file and made a new one, then put it in the content tab like you suggested. Got hello world in the log now.

I hope I can trial and error my way into some lua scripting from here

. Thanks to everyone for replying and dealing with these noobie questions and mistakes ^^.

daylightend · Oct 13, 2014

Allright, I did some lua stuff now. Looped trough players and cities, printing in log every step. Also ran the AtWarWithAnyMajor function posted by Nutty. All working fine.

My issue now is, how do I go about the hidden building that gives production to military units? I think I get the XML part from LeeS, but that is just to define the hidden building right ? not put it in any cities or so (or am I totaly wrong xD ?).

If my assumption is right I still have to "put" the building in my cities when I'm at war, and take it away when I'm not. Or maby always have the building in all my cities, but edit the production from 0 to 15 when at war? I'm not sure how to go about this. Ive been looking in the lua reference on the modiki. But haven't found functions to add or remove buildings.

LeeS · Oct 13, 2014

(re-edited to make my response a little more clear, I hope)

daylightend said:
Allright, I did some lua stuff now. Looped trough players and cities, printing in log every step. Also ran the AtWarWithAnyMajor function posted by Nutty. All working fine.

My issue now is, how do I go about the hidden building that gives production to military units? I think I get the XML part from LeeS, but that is just to define the hidden building right ? not put it in any cities or so (or am I totaly wrong xD ?).

Yup. All that XML code does is define the building for use later in the lua.

daylightend said:
If my assumption is right I still have to "put" the building in my cities when I'm at war, and take it away when I'm not...Ive been looking in the lua reference on the modiki. But haven't found functions to add or remove buildings.

Code:

pCity:SetNumRealBuilding(GameInfoTypes.BUILDING_MIL_PROD_MODIFIER, 1)

will add the building in "pCity".

Code:

pCity:SetNumRealBuilding(GameInfoTypes.BUILDING_MIL_PROD_MODIFIER, 0)

will remove the building in "pCity".

So you could add an if ___ then block such as:

Code:

for pCity in pPlayer:Cities() do
	if AtWarWithAnyMajor(iTeam) then
		pCity:SetNumRealBuilding(GameInfoTypes.BUILDING_MIL_PROD_MODIFIER, 1)
	else pCity:SetNumRealBuilding(GameInfoTypes.BUILDING_MIL_PROD_MODIFIER, 0)
	end
end

You could also do something like the following, if you've already 'grabbed' and stored the war status you got from AtWarWithAnyMajor(iTeam) and have it stored in a variable (differences highlighted in blue):

Code:

[COLOR="Blue"]local bAtWarIsTrue = AtWarWithAnyMajor(iTeam)[/COLOR]
for pCity in pPlayer:Cities() do
	if [COLOR="Blue"]bAtWarIsTrue[/COLOR] then
		pCity:SetNumRealBuilding(GameInfoTypes.BUILDING_MIL_PROD_MODIFIER, 1)
	else pCity:SetNumRealBuilding(GameInfoTypes.BUILDING_MIL_PROD_MODIFIER, 0)
	end
end

daylightend said:
Or maby always have the building in all my cities, but edit the production from 0 to 15 when at war? I'm not sure how to go about this.

This part of your question(s) really isn't (a) possible in any workable method I can think of, (b) something you want to spend any time chasing after. Just use the lua method shown above, or something like it.
Just adding this final note for future posterity of the forum. I learned a lot by reading old threads when I first started modding, and a lot of what I learned came from very often nearly throw-away comments such as: Oh, by the way Bob, did you do XYZ in your code*. So I don't want anyone reading this thread in future to misunderstand my post.

* and 90% of those seemed to be BTW mentions made by W. Howard.

daylightend · Oct 13, 2014

Thx LeeS!

That was exactly what I was looking for. I did see that function when looking at the modiki, just didnt figure out it was the one I needed

whoward69 · Oct 13, 2014

LeeS said:

Code:

local bAtWarIsTrue = AtWarWithAnyMajor(iTeam)
for pCity in pPlayer:Cities() do
  if bAtWarIsTrue then
    pCity:SetNumRealBuilding(GameInfoTypes.BUILDING_MIL_PROD_MODIFIER, 1)
  else
    pCity:SetNumRealBuilding(GameInfoTypes.BUILDING_MIL_PROD_MODIFIER, 0)
  end
end

* and 90% of those seemed to be BTW mentions made by W. Howard.

I'll add another one then

The condition inside the loop is invariant (that is, it doesn't depend on what the value of the loop variable - pCity in this case - is). So you can evaluate it once outside the loop and use another stored value within the loop. Won't save you much in execution time unless you have a large number of cities, but the general practice is a good one to follow. We can also do the same for the table lookup (GameInfoTypes.BUILDING_MIL_PROD_MODIFIER)

Code:

local iBuildingType = GameInfoTypes.BUILDING_MIL_PROD_MODIFIER
local bAtWarIsTrue = AtWarWithAnyMajor(iTeam)
local iBuildingsNeeded = 0
if bAtWarIsTrue then
  iBuildingsNeeded = 1
end

for pCity in pPlayer:Cities() do
  pCity:SetNumRealBuilding(iBuildingType, iBuildingsNeeded)
end

and you can then omit bAtWarIsTrue

Code:

local iBuildingsNeeded = 0
if AtWarWithAnyMajor(iTeam) then
  iBuildingsNeeded = 1
end

and for really brief code

Code:

local iBuildingsNeeded = AtWarWithAnyMajor(iTeam) and 1 or 0

stuck creating my 1st civilisation

daylightend

Chieftain

Nutty

Deity

LeeS

Imperator

Nutty

Deity

LeeS

Imperator

daylightend

Chieftain

Nutty

Deity

daylightend

Chieftain

Attachments

Nutty

Deity

daylightend

Chieftain

LeeS

Imperator

daylightend

Chieftain

LeeS

Imperator

daylightend

Chieftain

daylightend

Chieftain

LeeS

Imperator

daylightend

Chieftain

whoward69

DLL Minion

Similar threads