Right now what your mod does, as far as I can tell, is re-add every single original entry to the file (not sure if they duplicate), then add your own. In effect, you are doing a rewrite of the file, without actually rewriting it, which appears to be the problem.
If this is a core file that needs to be overwritten due to the way it loads (fully during game creation, rather than piecemeal like UI), then you will want to set VFS to true, and deal with the incompatibility issues.
--This is the method for R.E.D. graphic pack (which would overwrite your files if someone played both)
If this file loads as needed during gameplay, you should simply remove all units that aren't yours from the list, so the file simply loads those into the existing xml.
I'm back at my place now, so I can look at this in more detail. So far as I remember, when I built the mod I could not get custom units to work without copying and replacing the entire main file. Perhaps I am mistaken, however, isn't VFS just for files that don't receive 'OnModActivated-->UpdateDatabase' lines on the actions tab? I.e., isn't VFS for art, etc.? My ignorance is certainly the likely culprit here.
hey, just wanted to hop in and say great job, yours was one of the first mods i tried and ive been using it ever since, does make diplomacy more fun...although, i've noticed it's still possible to pay for alliances...by end game i have so much cash it makes more sense for me to that than spend the cash or time to build a unit that will only get me about half of what straight up money will, and it seems to me like the AI takes advantage of that too with their huge amounts of wealth..just a thought..but yeah, wanted to say great job, love your mod!!!
yeah, in my last play with PWM and CSD and WWGD,
on King level, AI Egypt had at one point 17k gold in the end (future era)!
Fixed nagging unit-based crash
That's high, but not uncommon on king. AI can make insane amounts of money (+100-200GPT) towards modern era.
Seems LUA coding is more tricky than I remember. If anyone wants to help and/or give guidance, this is what I want to do:
A LUA event that spawns a notification icon on the right-hand side (where all the bubbles are) that indicates when any player initiates the 'Conduct Trade Mission' action available to diplomatic units and great merchants. Nothing fancy, just a simple notification is all I need (probably using the City-State defacto 'capitol dome' icon). I'd rather not spend hours trial and erroring about in LUA-land if someone has a quick solution. All credit will be bestowed upon ye!
G