Limit to # of Bonuses in TGA GameFont & SDK

Sephi said:

if you use a debug dll, you can put a breakpoint into the loop and then mouseover the variable to display the current value. Else you could log it into a textfile.

The value you need is iCurSymbolID the first time the loop is run.

Click to expand...

Sephi said:

Valkrionn, since you basically use the same tga file, 8825 should work for you too. But if you one day add a whole new line to the tga file you probably need to change the number.

@Afforess

The function has been written to load the BTS tga file, not the WoC one. What exactly goes wrong, I don't care at the moment. I am happy I could track down the problem and "fix" it. This is the modification I am using.

Code:

void CvGameTextMgr::assignFontIds(int iFirstSymbolCode, int iPadAmount)
{
    int iCurSymbolID = iFirstSymbolCode;

    // set yield symbols
    for (int i = 0; i < NUM_YIELD_TYPES; i++)
    {
        GC.getYieldInfo((YieldTypes) i).setChar(iCurSymbolID);
        ++iCurSymbolID;
    }

    do
    {
        ++iCurSymbolID;
    } while (iCurSymbolID % iPadAmount != 0);

    // set commerce symbols
    for (i=0;i<GC.getNUM_COMMERCE_TYPES();i++)
    {
        GC.getCommerceInfo((CommerceTypes) i).setChar(iCurSymbolID);
        ++iCurSymbolID;
    }

    do
    {
        ++iCurSymbolID;
    } while (iCurSymbolID % iPadAmount != 0);

    if (NUM_COMMERCE_TYPES < iPadAmount)
    {
        do
        {
            ++iCurSymbolID;
        } while (iCurSymbolID % iPadAmount != 0);
    }

    for (int i = 0; i < GC.getNumReligionInfos(); i++)
    {
        GC.getReligionInfo((ReligionTypes) i).setChar(iCurSymbolID);
        ++iCurSymbolID;
        GC.getReligionInfo((ReligionTypes) i).setHolyCityChar(iCurSymbolID);
        ++iCurSymbolID;
    }
    for (i = 0; i < GC.getNumCorporationInfos(); i++)
    {
        GC.getCorporationInfo((CorporationTypes) i).setChar(iCurSymbolID);
        ++iCurSymbolID;
        GC.getCorporationInfo((CorporationTypes) i).setHeadquarterChar(iCurSymbolID);
        ++iCurSymbolID;
    }

    do
    {
        ++iCurSymbolID;
    } while (iCurSymbolID % iPadAmount != 0);

    if (2 * (GC.getNumReligionInfos() + GC.getNumCorporationInfos()) < iPadAmount)
    {
        do
        {
            ++iCurSymbolID;
        } while (iCurSymbolID % iPadAmount != 0);
    }

    // set bonus symbols
    int bonusBaseID = iCurSymbolID;
    ++iCurSymbolID;
    for (int i = 0; i < GC.getNumBonusInfos(); i++)
    {
        int bonusID = bonusBaseID + GC.getBonusInfo((BonusTypes) i).getArtInfo()->getFontButtonIndex();
        GC.getBonusInfo((BonusTypes) i).setChar(bonusID);
        ++iCurSymbolID;
    }

    do
    {
        ++iCurSymbolID;
    } while (iCurSymbolID % iPadAmount != 0);

    if(GC.getNumBonusInfos() < iPadAmount)
    {
        do
        {
            ++iCurSymbolID;
        } while (iCurSymbolID % iPadAmount != 0);
    }

    if(GC.getNumBonusInfos() < 2 * iPadAmount)
    {
        do
        {
            ++iCurSymbolID;
        } while (iCurSymbolID % iPadAmount != 0);
    }

// TEMPFIX Sephi
    iCurSymbolID=8825;
// TEMPFIX Sephi

    // set extra symbols
    for (int i=0; i < MAX_NUM_SYMBOLS; i++)
    {
        gDLL->setSymbolID(i, iCurSymbolID);
        ++iCurSymbolID;
    }
}

Click to expand...

Sephi said:

Every Icon in the tga file has a position. It is iFirstSymbolCode + number of icons before in the tga. Maybe another fancy value added in, the code to actually use the number is in the exe.

And the RoM tga has a lot more icons before the first symbol, so you definetly need a different number. just put a breakpoint into the
// set extra symbols
loop when the game reads the fonts correctly (that means not too many bonuses in the game) and you will get your needed number.

Click to expand...

Valkrionn said:

From what Sephi has said, you're good until you add an entirely new line to the fonts file; Somehow, I doubt that will be necessary any time soon.

Click to expand...

Valkrionn said:

Does this directly replace Sephi's code? As in, same location? Because I got a crash when trying to use it....

Click to expand...

...
    if(GC.getNumBonusInfos() < iPadAmount)
    {
        do 
        {
            ++iCurSymbolID;
        } while (iCurSymbolID % iPadAmount != 0);
    }
    if(GC.getNumBonusInfos() < 2 * iPadAmount)
    {
        do 
        {
            ++iCurSymbolID;
        } while (iCurSymbolID % iPadAmount != 0);
    }

//The order for symbols was changed in WoC. In normal BTS, Extra Symbols are loaded last, but in WoC, they are
//loaded right before resources. So we need to go back and load them. Order matters to the exe, which is why I can't
//re-order the way the exe loads the symbols.
    iCurSymbolID -= MAX_NUM_SYMBOLS;
    if (MAX_NUM_SYMBOLS > iPadAmount)
    {
        do 
        {
            ++iCurSymbolID;
        } while (iCurSymbolID % iPadAmount != 0);
    }

    for (int i=0; i < MAX_NUM_SYMBOLS; i++)
    {
        gDLL->setSymbolID(i, iCurSymbolID);
        ++iCurSymbolID;
    }
}

Afforess said:

Also, with this fix and the harcoding, I've still had an issue where the icons on the city bar are corrupted. They are off by 5 symbols, so the defense icon shows the Golden Age icon, etc... Anyone else have this? I have other places where the Defense Icon shows up fine, so I'm confused.

Click to expand...

Sephi said:

yeah, I know this. I had the exact same problem when I added some corporations but forgot to gave them correct values for the tga index (or whatever the WoC tag is called).

Click to expand...

Afforess said:

Hmm. That's not my issue. I just don't understand why calls to getSymbolId are returning different values for different functions, despite exactly the same parameters.

Click to expand...