I'm too lazy to look through 56 pages. But, -and this is mostly for ranged units- when you upgrade say shock or drill, (Bonus to rough terrain attack or open planes.) Does that mean that your unit has to be in the terrain? Or the enemy unit?
Ranged units don't have shock or drill promotions. Instead they have accuracy and barrage. Accuracy increases attack against units standing on open terrain and barrage - against units standing on rough terrain.