Captured City Art Mod

S

stolenrays

Deity

Joined

Aug 2, 2009

Messages

2,061

• Oct 21, 2011

• #1

Captured City Art Mod v1.3 (BTS 3.19)​

Captured cities now retain the city art of their highest cultural player.

This is a very simple sdk mod that I isolated and revised from Conqueror's Delight. Included is a working mod and the changed .cpp files. Changed sdk parts are commented as CITYART.

----Gameplay----
-Custom Gameoption
-Globaldefines.xml options
-Highest or Conquering Civ Culture Art

----Version History----

Spoiler :

Version 1.3
-Custom Gameoption
-DLL Fix by Isabelxxx
-Better commenting
-GLobalDefines for highest culture or original owner
-Removed UnitArt changes
-C++ fixes from Afforess/Orbis
-Highest Culture C++ Fix for founding cities

Version 1.2
-Fixed Human conquering art(as noticed by Cruel)
Version 1.1
-Port to 3.19
Version 1.0
-Original DPII version

Download Captured City Art Mod

 

Attachments

• 
  Civ4ScreenShot0006.JPG

  235.2 KB · Views: 680

C

CaptainMidnight

Warlord

Joined

Apr 16, 2006

Messages

141

• Oct 21, 2011

• #2

nice! Keep them coming!

 

The_J

Say No 2 Net Validations

Administrator

Supporter

Joined

Oct 22, 2008

Messages

39,554

Location

DE/NL/FR

• Oct 21, 2011

• #3

Nice .

Tried such a thing myself some time ago, but it turned out that it was not possible with Python :/. So, well done .

 

NikNaks

Deity

Joined

Jul 25, 2006

Messages

2,972

Location

England

• Oct 25, 2011

• #4

Hey, this is neat! Is there a way to show some buildings of one culture, and some of another, based on the culture percentages? Now *that* would be perfect.

 

S

stolenrays

Deity

Joined

Aug 2, 2009

Messages

2,061

• Oct 25, 2011

• #5

You mean Dynamic City Art. That sounds interesting and a good idea, but I do not know how to code it. The code right now checks the artstyle of the unit on the plot and checks the culture of the previous/current owner and then changes the artstyle accordingly. Anybody who wants to update this mod further should go ahead and do so.

 

Linkman226

#anarchy

Joined

Sep 14, 2007

Messages

2,493

• Oct 29, 2011

• #6

Does this require XML modifications as well?

 

S

stolenrays

Deity

Joined

Aug 2, 2009

Messages

2,061

• Oct 29, 2011

• #7

Nope, it is only sdk.

 

Linkman226

#anarchy

Joined

Sep 14, 2007

Messages

2,493

• Oct 30, 2011

• #8

Cool, thanks Just finished adding it to my mod.

 

S

stolenrays

Deity

Joined

Aug 2, 2009

Messages

2,061

• Oct 30, 2011

• #9

I'm adding a gameoption box to all my mods soon.

 

Cruel

King

Joined

Jun 22, 2005

Messages

826

Location

São Paulo, Brazil

• Nov 16, 2011

• #10

Very cool!

 

Cruel

King

Joined

Jun 22, 2005

Messages

826

Location

São Paulo, Brazil

• Jul 15, 2012

• #11

I did some tests "stand alone" in this mod. Is not working... It mantains the culture art of dominated but never back to the culture art of the conqueror.

 

S

stolenrays

Deity

Joined

Aug 2, 2009

Messages

2,061

• Jul 15, 2012

• #12

Maybe you could clarify the second sentance for me. Are you saying that you think that the captured city's art should eventually over time flip to the conquerer after the conquerer's culture is higher? Or is it just that the conquerer's art is never instituted during conquest.

I was actually getting ready to ad an option to the mod, so it is good that you mentioned this.

 

Cruel

King

Joined

Jun 22, 2005

Messages

826

Location

São Paulo, Brazil

• Jul 15, 2012

• #13

stolenrays said:

Maybe you could clarify the second sentance for me. Are you saying that you think that the captured city's art should eventually over time flip to the conquerer after the conquerer's culture is higher? Or is it just that the conquerer's art is never instituted during conquest.

I was actually getting ready to ad an option to the mod, so it is good that you mentioned this.

Click to expand...

The conquerer's art never instituted even with 100% of culture.

 

S

stolenrays

Deity

Joined

Aug 2, 2009

Messages

2,061

• Jul 15, 2012

• #14

I just tested it and it worked fine. In both instances the conquerer had a higher culture in the city and a different era art. Here is a screenshot:

 

Attachments

• 
  Civ4ScreenShot0003.jpg

  180.3 KB · Views: 292

Cruel

King

Joined

Jun 22, 2005

Messages

826

Location

São Paulo, Brazil

• Jul 15, 2012

• #15

stolenrays said:

I just tested it and it worked fine. In both instances the conquerer had a higher culture in the city and a different era art. Here is a screenshot:

Click to expand...

Test with Greek and Chinese/japanese in classical era.

 

S

stolenrays

Deity

Joined

Aug 2, 2009

Messages

2,061

• Jul 15, 2012

• #16

Definetly a bug, but otherwise I have found it to work. I looked at the code and I'm not sure where the error is, or maybe I have overlooked a confounding variable to why the art didn't change. If you know a solution, or anyone else, let me know.

I checked it again. It seems it works if the era of the civs is different only, not when the eras are the same.

 

Cruel

King

Joined

Jun 22, 2005

Messages

826

Location

São Paulo, Brazil

• Jul 15, 2012

• #17

stolenrays said:

I checked it again. It seems it works if the era of the civs is different only, not when the eras are the same.

Click to expand...

That is why it never worked in my tests. Always used the same era.

I wish could help but my SDK knowledge is near 0.

 

S

stolenrays

Deity

Joined

Aug 2, 2009

Messages

2,061

• Jul 15, 2012

• #18

It might be that there needs to be a else combo added somewhere. Just odd that different eras work, captured art works, but not the default way anymore.

 

S

stolenrays

Deity

Joined

Aug 2, 2009

Messages

2,061

• Jul 17, 2012

• #19

Cruel, I think that I figured it out, but I will need to create/add some more code to it. I tried it with the Japanese vs. Romans. I let the Japanese capture my city and their new art was instituted (same eras) . Here's the code:

Code:

	/*** CITYART 07/28/08 by DPII START ***/
	if ((eHighestCulturePlayer != NO_PLAYER) && (eHighestCulturePlayer != eOwner))
	{
	    setArtStyleType(GET_PLAYER(eHighestCulturePlayer).getArtStyleType());
	}
	else
	{
	    setArtStyleType(GET_PLAYER(eOwner).getArtStyleType());
	}
	/*** CITYART END ***/

The first if part I believe says that if the highest culture is a player, but no longer the owner, go with the highest culture. The else should cover all other things, but it doesn't. I think if I just elimiate the first part of the if statement, then add some more things, it could work.

Maybe:

Code:

	if (eHighestCulturePlayer != eOwner)
	
	{
	    setArtStyleType(GET_PLAYER(eHighestCulturePlayer).getArtStyleType());
	}
	else 
            {
                 if (eHighestCulturePlayer = eOwner)
                {
	        setArtStyleType(GET_PLAYER(eOwner).getArtStyleType());
	    }
             }

There are probably many ways you could get this to work, but the previous seems rather simpler. I'll test some different things to see what happens.

 

Cruel

King

Joined

Jun 22, 2005

Messages

826

Location

São Paulo, Brazil

• Jul 17, 2012

• #20

OK (I need more friends who know how to programming - )