[Religion and Revolution]: Events

raystuttgart · May 29, 2012

@orlanth:

I got another Python exception.
Could you please check that ? :thumbsup:

raystuttgart · May 31, 2012

@orlanth:

I get another Python exception with the new Event for CattleThieves.
Could you please check and correct that ? :thumbsup:

orlanth · Jun 3, 2012

Ok, I uploaded an update to prevent that.

Does anyone know how a python function could be made to add or subtract a unit from the King's expeditionary force? It would be nice to create a way that good relations could decrease the REF slightly while angering the King could increase it.

raystuttgart · Jun 3, 2012

orlanth said:
Ok, I uploaded an update to prevent that.

Great.

orlanth said:
Does anyone know how a python function could be made to add or subtract a unit from the King's expeditionary force ?

You could use this:

void addRevolutionEuropeUnit(UnitTypes eUnit, ProfessionTypes eProfession);

It is already made available for Python.

(At the player object.)

It is used from the "child" (meaning the colony) and not from the "parent" (meaning the king).

-----------

But actually it does not make a lot of sense. :dunno:

Any unit you would add with that method, would simply be there earlier, because there is always the calculation / comparison:

Needed REF vs. Existing REF

If you add units to Existing REF with an event, the King will simply not increase the REF, until Needed REF is bigger than Existing REF again .
By removing units from REF, it is even worse, because it will directly be replaced again in the next round.

orlanth · Jun 3, 2012

Thanks, I see. If the existing REF system would undo any change, I guess that wouldn't be a helpful Event.

Could there be some way to apply a modifier to the "needed REF"? It would be nice if by keeping consistently good relations with the King and completing missions for him, REF will be a bit lower than it would otherwise be. For example, if there's a global variable that applies a modifier to Needed Ref, you could use this to earn a permanent -1 modifier to REF size as a quest reward. While if you often antagonize him and refuse to kiss his ring etc, this REF modifier can become a bit higher than it would be if considering your weapons and Bells alone.

Or does the current Needed REF calculation already take past behavior toward the King somewhat into account?

raystuttgart · Jun 3, 2012

orlanth said:
Or does the current Needed REF calculation already take past behavior toward the King somewhat into account?

Indirectly yes.

(It takes into account MaxTaxRate, which is mainly affected by Attitude of King.)

Better King Attitude -> lower MaxTaxRate -> lower REF.

Summary:

You can (indirectly) reduce REF by having good realtions to the King.
So everything ok. :thumbsup:

orlanth · Jun 9, 2012

I added a Royal Crackdown Event that can trigger when the King's relation with you is at "Furious" and you're not in Revolution. You can either pay a fine to the royal treasury or royal agents will seize Food from your city and burn several Improvements :cry:

, the King's relation then gets adjusted upward by one point. So this adds some consequence for all that disobedience :nono:

and can also prevent relations from getting stuck permanently at Furious.

raystuttgart · Jun 10, 2012

Great, it sounds very interesting. :thumbsup:

raystuttgart · Jun 10, 2012

@orlanth:

I get a Python-Exception with your new event.

Could you please check that ?

raystuttgart · Jun 11, 2012

@orlanth:

I updated to the current revision, but got some more Python-Exceptions with the new events.

orlanth · Jun 20, 2012

After a long time of looking at it I can't figure out what would cause that. It uses the exact same syntax as numerous existing events from TAC and vanilla game (canDoTriggerImmigrant, canDoTriggerMotherland, canTriggerPeasantWarPrep etc) but sometimes prints a python exception saying global variable eplayer is not defined, and sometimes causes no exception at all. I will just have to deactivate it for the time being.

raystuttgart · Jun 21, 2012

orlanth said:
I will just have to deactivate it for the time being.

I will have a look. :thumbsup:

raystuttgart · Jun 21, 2012

@orlanth:

I made small correction to CIV4EventInfos.xml.
(Please get current revision.)

----------------------

Here you have an undefined variable (iChoose).

I am not totally sure, what you are trying to do there.
Otherwise I would have fixed it.

Code:

def applyKingAngry(argsList):
	eEvent = argsList[0]
	event = gc.getEventInfo(eEvent)
	kTriggeredData = argsList[1]
	player = gc.getPlayer(kTriggeredData.ePlayer)
	eking = player.getParent()
	king = gc.getPlayer(eking)
	[COLOR="Red"]iYield = gc.getInfoTypeForString(iChoose)[/COLOR]
	player.AI_changeAttitudeExtra(eking, event.getGenericParameter(3))
	king.AI_changeAttitudeExtra(kTriggeredData.ePlayer, event.getGenericParameter(3))
	if event.getGenericParameter(4) == 1 :
		player.NBMOD_IncreaseMaxTaxRate()

----------------------

Here I think it might be better to have that condition after the check if not player.isPlayable().

Code:

def canDoNotInRevolution(argsList):
	pTriggeredData = argsList[0]
	player = gc.getPlayer(pTriggeredData.ePlayer)
	if player.isNative():
		return false
	[COLOR="Red"]king = gc.getPlayer(player.getParent())[/COLOR]
	if not player.isPlayable():
		return false
	if not king.isEurope():
		return false
	if player.isInRevolution():
		return false
	return true

----------------------

A general question:

Sometimes you get the player like this:

Code:

def canTriggerDeliverCoats(argsList):
	...
	ePlayer = argsList[1]
	...
	player = gc.getPlayer(ePlayer)
	...

and sometimes like this:

Code:

def canDoInRevolution(argsList):
	pTriggeredData = argsList[0]
	player = gc.getPlayer(pTriggeredData.ePlayer)
        ...

Are you sure, that both variants work ?

----------------------

The Event Cattle Thieves can be triggered, even if you do not have cattle.
(If you select option 1, you will have negative storage of cattle.)

We probably have the same problem with Horse Thieves.
(The events are very similar.)

I tried to correct it, but I get the same problem again. :confused:

Could you please take a look again, at that event ? :thumbsup:

See screenshot 1 and screenshot 2.

raystuttgart · Jun 22, 2012

@orlanth:

I really don't understand why Cattle Thieves can be triggered without YIELD_CATTLE being available in the city ... :confused:

(I cannot find anything wrong in XML or Python.)

It is really easy to test by the way.
Simply put a city directly next to a Native Village (borders touching) and then click through a few rounds.
(The trigger is only activated in 80% of the games, so if it doesn't work, try again with a new game.)

orlanth · Jun 23, 2012

@Ray:

I can't understand why that wouldn't work either :confused:

Now I've totally redone the python triggers using a different way which also seems like it should work, but still it can be triggered without YIELD_CATTLE being available.

For the KingFurious trigger, I also tried to do a version using the ePlayer = argsList[1] python from other TAC events, but this also had an exception.

raystuttgart · Jun 24, 2012

If you don't mind, I will ask Ronnar - a former colleague from TAC and the one who did most of the TAC events - if he might take a look.

raystuttgart · Jun 24, 2012

@orlanth:

I have noticed that you are trying to use 2 ways of getting player at the same time.
(the second red line is wrong)

Spoiler :

--------------------

Also I have asked Ronnar for help and got some information. :thumbsup:

Methods called by <PythonCanDo> and <PythonCanDoCity> get their parameters very differently.
(Parameters themselves and their order is different.)

This is the way you get the player with <PythonCanDo>:

Code:

kTriggeredData = argsList[0]
player = gc.getPlayer(kTriggeredData.ePlayer)

This is the way you get the player with <PythonCanDoCity>:

Code:

ePlayer = argsList[1]
player = gc.getPlayer(ePlayer)

This is the way you get the city with <PythonCanDoCity>:

Code:

iCity = argsList[2]
city = player.getCity(iCity)

I hope this helps a little.

However, I am not sure, if this solves our problem ... :dunno:

Could you please check all our new Events, if the parameters are acquired correctly. :thumbsup:

orlanth · Jun 30, 2012

phew.. I've made it use the specific methods for python candocity, and it finally triggers only when Cattle are present in the settlement!
thank you to Ray and Ronnar for the advice :king:

raystuttgart · Jun 30, 2012

orlanth said:
phew.. I've made it use the specific methods for python candocity, and it finally triggers only when Cattle are present in the settlement!
thank you to Ray and Ronnar for the advice

Fantastic !!! :goodjob:

(Thanks for not giving up.

)

By the way:
I am really looking forward to see more of your great events.

raystuttgart · Jun 30, 2012

@orlanth:

What about these old ideas ?
(Is one of them interesting for you to implement ?)

Spoiler :

Another idea:

Conflict between Cattle Ranchers and Sheep Ranchers

Condition:
Butchery in City and > 100 Cattle and > 100 Sheep in city.
(Event is unique.)

Cattle Ranchers and Sheep Ranchers have started fighting over rights for the best pastures.

A) Side with the Cattle Ranchers and have all Sheep in Town butchered.
(All Sheep in town transformed into Food + Wool.)
B) Side with the Sheep Ranchers and have all Cattle in Town butchered.
(All Cattle in town transformed into Food + Hides.)
C) Throw a party for the town to have them celebrate together and become friends again.
(-50 gold)

Comment:
A) and B) sound good on first sight, but remember, that Sheep and Cattle are livestock and you need some available in city to bread other.

[Religion and Revolution]: Events

Civ4Col Modder

Attachments

Civ4Col Modder

Attachments

Storm God. Yarr!

Civ4Col Modder

Storm God. Yarr!

Civ4Col Modder

Storm God. Yarr!

Civ4Col Modder

Civ4Col Modder

Attachments

Civ4Col Modder

Attachments

Storm God. Yarr!

Civ4Col Modder

Civ4Col Modder

Attachments

Civ4Col Modder

Storm God. Yarr!

Civ4Col Modder

Civ4Col Modder

Storm God. Yarr!

Civ4Col Modder

Civ4Col Modder

Similar threads