JFD's Rise to Power

Excellent! I played a bit of this as Bohemia. Never got to get to their own stuff aside from a Tabor a decision happened to give me (but I never got to try those functions), as the only city-states were impossible to reach by Missionary (also the game crashed before even the Medieval so)

Two bugs noticed! The biggest one is that all the buttons on the Piety tree were gone. I was still able to adopt the opener, and the lines between the policies were there, but the policy buttons themselves were totally missing. I suspect R&R is to blame for that, I will poke another time to see if that's the issue.

And another smaller one - the little icon for Lotus in the tooltip didn't appear, and in one lake wasn't visibly present, I think. Might've just been an oddity from it being a one-tile lake, it showed up fine in a larger one. Other two resources work a-okay. Otherwise everything worked out happily! Piety functioned, decisions showed up, events were working, and all was well. I noticed the Sioux were settling cities directly on resources which is an odd thing I've never seen the AI do, but I realized that's something you actually want to be doing as them, so maybe it was just a clever bit of AI coding on Tom's part.

But yes, good job! This is a lovely release and I look forward to seeing what the Institutions and Prestige have to offer.

JFD said:

Currently, the mod isn't compatible with Gazebo's Community Patch (causes the game to CTD). I don't know why this is, and I doubt I'll be able to fix the conflict on P&P's end.

Click to expand...

Does P&P add a new yield type? That'll cause a crash if it overrides any of the yield IDs in the CP/CBP.

G

I'm not familiar with whoward's DLL, what exactly do I need to get for P&P to work ?

Gazebo said:

Does P&P add a new yield type? That'll cause a crash if it overrides any of the yield IDs in the CP/CBP.

G

Click to expand...

Nope, and the CTD is definitely with P&P + CP. It's whenever a new turn happens.

Teproc said:

I'm not familiar with whoward's DLL, what exactly do I need to get for P&P to work ?

Click to expand...

Just download the DLL like a regular mod and put it in your MODS folder to let it extract.

Ok, I thought it was a "pick and choose thing" but I guess not. Thanks !

JFD,

I downloaded and tested out Cultural Diversity and Piety and Prestige. Cultural Diversity seems to work fine from what I can tell (with both the CP and the CBP), however Piety and Prestige crashes on turn 0 (first AI attempt to settle a city). The minidump for the dll points to a spot in LuaGame.cpp:


This indicates that the problem is an issue with lua. Any idea what element of your lua calls this on turn 0?

Also, seeing these database errors (promotions possibly due to the nuke of the promotions in the CBP - I can fix this with an xml update in the CBP):


If you have any thoughts on this, let me know. I'd like to see the CP, CBP and your two mods play nice.

G

Gazebo said:

JFD,

I downloaded and tested out Cultural Diversity and Piety and Prestige. Cultural Diversity seems to work fine from what I can tell (with both the CP and the CBP), however Piety and Prestige crashes on turn 0 (first AI attempt to settle a city). The minidump for the dll points to a spot in LuaGame.cpp:

Code:

//------------------------------------------------------------------------------
int CvLuaGame::lGetFounder(lua_State* L)
{
	const ReligionTypes eReligion = static_cast<ReligionTypes>(luaL_checkint(L, 1));
	const PlayerTypes ePlayer = static_cast<PlayerTypes>(luaL_checkint(L, 2));

	const CvReligion* pReligion = GC.getGame().GetGameReligions()->GetReligion(eReligion, ePlayer);

	lua_pushinteger(L, (int)pReligion->m_eFounder);
	return 1;
}

This indicates that the problem is an issue with lua. Any idea what element of your lua calls this on turn 0?

Also, seeing these database errors (promotions possibly due to the nuke of the promotions in the CBP - I can fix this with an xml update in the CBP):

Code:

[20933.056] Invalid Reference on Policy_FreePromotions.PromotionType - "PROMOTION_JFD_BANTU_GOLDEN_AGE" does not exist in UnitPromotions
[20935.037] Invalid Reference on UnitPromotions_UnitCombats.PromotionType - "PROMOTION_JFD_BANTU_GOLDEN_AGE" does not exist in UnitPromotions
[20935.037] Invalid Reference on UnitPromotions_UnitCombats.PromotionType - "PROMOTION_JFD_BANTU_GOLDEN_AGE" does not exist in UnitPromotions
[20935.037] Invalid Reference on UnitPromotions_UnitCombats.PromotionType - "PROMOTION_JFD_BANTU_GOLDEN_AGE" does not exist in UnitPromotions
[20935.037] Invalid Reference on UnitPromotions_UnitCombats.PromotionType - "PROMOTION_JFD_BANTU_GOLDEN_AGE" does not exist in UnitPromotions
[20935.037] Invalid Reference on UnitPromotions_UnitCombats.PromotionType - "PROMOTION_JFD_BANTU_GOLDEN_AGE" does not exist in UnitPromotions
[20935.037] Invalid Reference on UnitPromotions_UnitCombats.PromotionType - "PROMOTION_JFD_BANTU_GOLDEN_AGE" does not exist in UnitPromotions
[20935.037] Invalid Reference on UnitPromotions_UnitCombats.PromotionType - "PROMOTION_JFD_BANTU_GOLDEN_AGE" does not exist in UnitPromotions
[20936.051] Invalid Reference on JFD_Institutions.AlphaAtlas - "JFD_PIETY_INSTITUTIONS_PATRIARCHY_ALPHA_ATLAS" does not exist in IconTextureAtlases
[20936.051] Invalid Reference on JFD_Institutions.AlphaAtlas - "JFD_PIETY_INSTITUTIONS_PAPACY_ALPHA_ATLAS" does not exist in IconTextureAtlases
[20936.051] Invalid Reference on JFD_Institutions.AlphaAtlas - "JFD_PIETY_INSTITUTIONS_MANDATE_OF_HEAVEN_ALPHA_ATLAS" does not exist in IconTextureAtlases
[20936.051] Invalid Reference on JFD_Institutions.AlphaAtlas - "JFD_PIETY_INSTITUTIONS_IMPERIAL_CULT_ALPHA_ATLAS" does not exist in IconTextureAtlases
[20936.051] Invalid Reference on JFD_Institutions.AlphaAtlas - "JFD_PIETY_INSTITUTIONS_CALIPHATE_ALPHA_ATLAS" does not exist in IconTextureAtlases
[20936.051] Invalid Reference on JFD_Institutions.IconAtlas - "JFD_PIETY_INSTITUTIONS_ATLAS" does not exist in IconTextureAtlases
[20936.051] Invalid Reference on JFD_Institutions.IconAtlas - "JFD_PIETY_INSTITUTIONS_ATLAS" does not exist in IconTextureAtlases
[20936.051] Invalid Reference on JFD_Institutions.IconAtlas - "JFD_PIETY_INSTITUTIONS_ATLAS" does not exist in IconTextureAtlases
[20936.051] Invalid Reference on JFD_Institutions.IconAtlas - "JFD_PIETY_INSTITUTIONS_ATLAS" does not exist in IconTextureAtlases
[20936.051] Invalid Reference on JFD_Institutions.IconAtlas - "JFD_PIETY_INSTITUTIONS_ATLAS" does not exist in IconTextureAtlases

If you have any thoughts on this, let me know. I'd like to see the CP, CBP and your two mods play nice.

G

Click to expand...

Whoops. The Bantu Golden Age promotion is from CulDiv, and is from a test build in which I must've forgotten to disable all the files that aren't yet public. Will fix this when I update CulDiv next. The IconAtlas errors I'll tidy up.

As for the CTD... phew, that took two hours to track down But it was being caused by the function that assesses whether the AI can adopt a State Religion or not. I've added a check in that function to ensure that the AI player has a capital city before continuing, which resolves the CTD. So to anyone hoping to use the CP and P&P, please re-download. The CBP isn't yet compatible (probably), but that'll have to wait until P&P is more complete, as I'll need to convert CBP's Top Panel changes to be more modular using my Dynamic Top Panel mod.

Somehow the mod's UI broke completely down at around turn 70 when the first State Religion was established. I no longer see any state religions at the list, and the Enact Decisions list got completely empty. It still seems to work hidden, because I still get notifications of other players choosing their State Religions, and such.

The Lua.log is filled by this kind of messages every turn:

I'm afraid I don't know what that line corresponds to, as you don't appear to have the latest version (that line is not comparing numbers in my version) (I should really be changing version numbers...). Try updating and hopefully that'll resolve the issue. If not, let me know again of any errors in the log. Thanks.

Ahh, it was already updated - my bad
I'll test it asap and post if there's anything not working correctly anymore then


EDIT: All updated - same problem. It just keeps adding this on logs.

Fixed, finally. There was probably some mods conflicting, I'm not sure which it was. I disabled all not listed as compatible here, and now it's looking great! Though, no new icons for wonders and resources display.

JFD said:

Whoops. The Bantu Golden Age promotion is from CulDiv, and is from a test build in which I must've forgotten to disable all the files that aren't yet public. Will fix this when I update CulDiv next. The IconAtlas errors I'll tidy up.

As for the CTD... phew, that took two hours to track down But it was being caused by the function that assesses whether the AI can adopt a State Religion or not. I've added a check in that function to ensure that the AI player has a capital city before continuing, which resolves the CTD. So to anyone hoping to use the CP and P&P, please re-download. The CBP isn't yet compatible (probably), but that'll have to wait until P&P is more complete, as I'll need to convert CBP's Top Panel changes to be more modular using my Dynamic Top Panel mod.

Click to expand...

Glad to hear it works now. When you want to collaborate on the dynamic lua changes, let me know, as making CBP's lua more friendly is a priority of mine as well.
G

Typo report:
For the pagan decisions, in the lua you have written (on line 57) SacredWaters, when you meant OneWithNature.

Hello JFD, I have the same issue as theD3rp, I tracked it down to whoward's dll, not cultural diversity. Is there any workaround? I'd love to test this.

Much appreciated,
Fenragon

It turns out the Case of the Missing Piety Policies has nothing to do with R&R after all. Odd...

Since the update, the new resources aren't showing up properly in the civlopedia or spawning on the map.


Edit: The icons for Solomon's Temple are gone as well, and I had a big red circle with a slash through it on the wheel tech where the icon should have been.

Should I have given screenshots?

Well, I forgot that I'd moved the art assets over to the balance patch, as they should've been in the first place, so I've roughly update the balance patch to fix this.

hokath said:

Typo report:
For the pagan decisions, in the lua you have written (on line 57) SacredWaters, when you meant OneWithNature.

Click to expand...

Thanks.

Thank you, I'll go back to testing out P&P (as I was doing this morning) after I'm done cleaning. I would like to know, why is the piety branch unlocked in the classical era instead of at the beginning?

It seemed pointless to have it in the Ancient Era, where its contemporaries are far superior. This may change once I do a more robust overhaul of Social Policies for Prestige.

JFD said:

Well, I forgot that I'd moved the art assets over to the balance patch, as they should've been in the first place, so I've roughly update the balance patch to fix this.

Click to expand...

It seems that files named JFD_PietyBalanceSpecialistAtlas_xx are still missing, and it causes the city view of every city that has a Monastery to break down. Otherwise it's now working