Merging BUG 4.0 with FfH2

GIR · Aug 17, 2009

denev said:
...

4. Tweaking from Original BUG

Banner dot becomes star with joining Great Commander instead of Great General.

Adding "Priests" row in Religion Advisor screen.

Great Person Tech in Tech Advisor screen works correctly. This function was rewritten and became same as DLL method.

Some Sevopedia pages are improved to match with FfH2 features.

That's awesome. I love the bug interface and your 'tweaks' are great.
I hope they will find there way to ff and all the other great mods anytime soon...

[to_xp]Gekko · Aug 18, 2009

BUG 4.0? awesome job dude :goodjob:

denev · Sep 2, 2009

GIR said:
I hope they will find there way to ff and all the other great mods anytime soon...

Thank you GIR. I hope so too

.

denev · Sep 8, 2009

Version 0.05 posted.

[to_xp]Gekko · Sep 9, 2009

nice

Sephi · Sep 11, 2009

very very great. :goodjob:

One thing I noticed is that the Sevopedia has a category traits. Does it work for you? (I got an error because trait description doesn't exist) and even Ignoring this shows only weird information (link a hint that assembly line is a good tech for organized trait).

denev · Sep 12, 2009

Sephi said:
One thing I noticed is that the Sevopedia has a category traits. Does it work for you?

Yeah, unmodded Civilipedia doesn't have category traits.
This means that unmodded CvGameCoreDLL.dll has no python API which is required for displaying category traits.

BUG Mod uses very tricky method for category traits, because BUG doesn't touch CvGameCoreDLL.dll at all.
I have modded category traits for matching with FfH2 features following BUG method, but it is tricky too.

Now I have breached BUG mantra which says CvGameCoreDLL.dll is not modded.
Next version which is not released yet can treat TraitInfos as same as many other item infos.

alerum68 · Sep 13, 2009

Denev, if you're feeling adventurous you could try merging BULL (BUg dLL) with the FFH DLL. I don't know how much FFH changes their DLL at this point, but you'll be able to do a complete and total merger of BUG / FFH this way.

denev · Sep 14, 2009

alerum68 said:
Denev, if you're feeling adventurous you could try merging BULL (BUg dLL) with the FFH DLL. I don't know how much FFH changes their DLL at this point, but you'll be able to do a complete and total merger of BUG / FFH this way.

Thanks for your advice.
Merging with BULL is one of my goal. But it is a little bit hard work for me

.

I'm working on improving sevopedia (and civilopedia) now.
After it is finished and Kael releases FfH2 041 patch "h", I will plan merging BULL afresh.

denev · Sep 17, 2009

Version 0.06 posted.

[to_xp]Gekko · Sep 17, 2009

thank you denev

Nicopol · Sep 18, 2009

denev said:
[...]
4. If a unit has more than 27 Promotions, their icon size becomes smaller on unit status area.
View attachment 228119

nice!!!!

denev · Oct 13, 2009

Version 0.07 posted.

[to_xp]Gekko · Oct 14, 2009

BUG 4.1 plus assorted goodness? yes, please

Sephi · Oct 30, 2009

one little thing I noticed while merging. In void CvGameTextMgr::setBasicUnitHelp(CvWStringBuffer &szBuffer, UnitTypes eUnit, bool bCivilopediaText)

a check for !=NO_PROMOTION should be added.

Code:

				//race requirement
				const PromotionTypes ePromotionPrereq1 = (PromotionTypes)GC.getSpellInfo((SpellTypes)iJ).getPromotionPrereq1();
				const PromotionTypes ePromotionPrereq2 = (PromotionTypes)GC.getSpellInfo((SpellTypes)iJ).getPromotionPrereq2();
				PromotionTypes eRacePrereq = NO_PROMOTION;
				eRacePrereq = GC.getPromotionInfo(ePromotionPrereq2).isRace() ? ePromotionPrereq1 : eRacePrereq;
				eRacePrereq = GC.getPromotionInfo(ePromotionPrereq1).isRace() ? ePromotionPrereq1 : eRacePrereq;
				if (eRacePrereq != NO_PROMOTION)
				{
					if (!GC.getUnitInfo(eUnit).getFreePromotions(eRacePrereq))
					{
						continue;
					}
				}

to something like that

Code:

				const PromotionTypes ePromotionPrereq1 = (PromotionTypes)GC.getSpellInfo((SpellTypes)iJ).getPromotionPrereq1();
				const PromotionTypes ePromotionPrereq2 = (PromotionTypes)GC.getSpellInfo((SpellTypes)iJ).getPromotionPrereq2();
				PromotionTypes eRacePrereq = NO_PROMOTION;
				if (ePromotionPrereq2!=NO_PROMOTION)
				{
					eRacePrereq = GC.getPromotionInfo(ePromotionPrereq2).isRace() ? ePromotionPrereq2 : eRacePrereq;
				}
				if (ePromotionPrereq1!=NO_PROMOTION)
				{
					eRacePrereq = GC.getPromotionInfo(ePromotionPrereq1).isRace() ? ePromotionPrereq1 : eRacePrereq;
				}

Sephi · Oct 30, 2009

Anyway, I really like what you have done so far. The interface looks a lot improved now :goodjob:

denev · Oct 31, 2009

Sephi said:
one little thing I noticed while merging. In void CvGameTextMgr::setBasicUnitHelp(CvWStringBuffer &szBuffer, UnitTypes eUnit, bool bCivilopediaText)

a check for !=NO_PROMOTION should be added.

Great catch!

I might never have been able to notice this.
I will fix it next version.

Thanks for reporting!

xienwolf · Oct 31, 2009

In the code sephi quoted:

eRacePrereq = GC.getPromotionInfo(ePromotionPrereq2).isRace() ? ePromotionPrereq1 : eRacePrereq;
eRacePrereq = GC.getPromotionInfo(ePromotionPrereq1).isRace() ? ePromotionPrereq1 : eRacePrereq;

Note that both lines use Prereq1 to fill in eRacePrereq

denev · Nov 1, 2009

xienwolf said:
Note that both lines use Prereq1 to fill in eRacePrereq

Yeah, I have committed double silly mistakes. Now, these code has been fixed as below. :

Spoiler :

I'm glad if you notice anything and advise me in the future.

denev · Nov 5, 2009

Version 0.08 posted.

Merging BUG 4.0 with FfH2

It'sNotStupidIt'sAdvanced

QCT junkie

Warlord

Warlord

QCT junkie

Deity

Warlord

Priest of Hiroshima

Warlord

Warlord

QCT junkie

Warlord

Warlord

QCT junkie

Deity

Deity

Warlord

Deity

Warlord

Warlord

Similar threads