Generals that upgrade do not get the XP reset, they keep all XP earned.
This is a good thing though, because when XP earned for a unit resets back to 10 (well, it is capped to 10 if it is over that amount), the amount needed for the next promotion increases. For example if you have 35/37 XP...