1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

[GS] [1.0.0.290] Reverse effect of Trade Policy WC resolution

Discussion in 'Civ6 - Bug Reports' started by cholsy, Mar 2, 2019.

  1. cholsy

    cholsy Warlord

    Joined:
    Dec 20, 2010
    Messages:
    159
    Besides my previous thread about Mercenary Companies, https://forums.civfanatics.com/thre...companies-100-cost-up-with-production.643145/ , I found something odd about Trade Policy.
    Please compare between before(turn 281) and after(turn 283) the resolution.
    Senders should have gotten +4 gold but John is getting the bonus.

    20190303114526_1.jpg

    281.jpg 283.jpg
    I was not able to check all resolution effects but strongly believe that the program on WC should be overhauled.
     
  2. cholsy

    cholsy Warlord

    Joined:
    Dec 20, 2010
    Messages:
    159
    SAVE files are here.
     

    Attached Files:

  3. Qwan

    Qwan Warlord

    Joined:
    Mar 5, 2010
    Messages:
    117
    Please fix this bug with Trade Policy. Not only am I getting an extra trade route slot, but the three foreign trade routes to my cities are each giving ME +4 instead of them.

    Version 1.0.0.341 (176806)

     
  4. Laurana Kanan

    Laurana Kanan Don’t underestimate who I am. Moderator

    Joined:
    Apr 10, 2014
    Messages:
    3,062
    Gender:
    Female
    Location:
    Near the Greatest Snow on Earth
    1. You should be on version 1.0.1.501.
    2. Do you have a save game you could upload here?
     
  5. cholsy

    cholsy Warlord

    Joined:
    Dec 20, 2010
    Messages:
    159
    1.0.1.501 save file on this issue.
     

    Attached Files:

  6. Pfeffersack

    Pfeffersack Deity

    Joined:
    May 10, 2003
    Messages:
    2,871
    Location:
    Germany
    I can confirm this issue for version NFP 1.0.1.501 as well:

    EffectAonWL.jpg

    WLgetting4foreachRoute.jpg

    NewRoute+4WL.jpg
     

    Attached Files:

  7. Qwan

    Qwan Warlord

    Joined:
    Mar 5, 2010
    Messages:
    117
    1. I can't run version 1.0.1.501, because I'm using MacOS El Capitan (10.11.6) ... yes I have an old computer.
    2. Yes, I have the save game, but as others have already posted such for version 1.0.1.501, mine would be redundant.

    Thank for your attention to this bug!
    P.S. It'd be nice if Steam didn't automatically update when connected, but checked system requirements.
     
  8. Laurana Kanan

    Laurana Kanan Don’t underestimate who I am. Moderator

    Joined:
    Apr 10, 2014
    Messages:
    3,062
    Gender:
    Female
    Location:
    Near the Greatest Snow on Earth
    It looks like this resolution uses the same ModType that Radio Oranje uses - "MODIFIER_PLAYER_CITIES_ADJUST_TRADE_ROUTE_YIELD_FROM_OTHERS". And seeing that the Modifier is attached to the target of the resolution, the bonus gold is gained by them as the recipient instead of the sender. It's like there needs to be a third Modifier Argument parameter - AffectOrigin - similiar to how the Alliance Bonuses are set up.
    ───────────────────────────────────────────────────────────────────────────────────────────────────
    Any performance difference between the Sept '19 patch and the May '20 patch would be negligible, if any at all. My benchmarks were almost identical between the two. Thing is, if you for whatever reason can't run 501, and they fix the bug in a subsequent patch, you still won't see the fix as you're playing ver. 341.
     
  9. Infixo

    Infixo Deity

    Joined:
    Jan 9, 2016
    Messages:
    3,719
    Gender:
    Male
    Location:
    Warsaw
  10. Laurana Kanan

    Laurana Kanan Don’t underestimate who I am. Moderator

    Joined:
    Apr 10, 2014
    Messages:
    3,062
    Gender:
    Female
    Location:
    Near the Greatest Snow on Earth
    Yeah, it may be as simple as swapping "MODIFIER_PLAYER_CITIES_ADJUST_TRADE_ROUTE_YIELD_TO_OTHERS" for "MODIFIER_PLAYER_CITIES_ADJUST_TRADE_ROUTE_YIELD_FROM_OTHERS" as that's what Cleo uses to grant food to other Civs that send trade routes to her.
     
    Infixo likes this.
  11. Infixo

    Infixo Deity

    Joined:
    Jan 9, 2016
    Messages:
    3,719
    Gender:
    Male
    Location:
    Warsaw
    Anyone willing to test it, then here's the fix. I will check it in my current game if this resolution pops up.
    Code:
    --------------------------------------------------------------
    -- 2020-06-14 WC resolution nor working correctly
    UPDATE Modifiers
    SET ModifierType = 'MODIFIER_PLAYER_CITIES_ADJUST_TRADE_ROUTE_YIELD_TO_OTHERS'
    WHERE ModifierId = 'INCREASES_TRADE_TO_GOLD' AND ModifierType = 'MODIFIER_PLAYER_CITIES_ADJUST_TRADE_ROUTE_YIELD_FROM_OTHERS';
    
     
  12. cholsy

    cholsy Warlord

    Joined:
    Dec 20, 2010
    Messages:
    159
    I did it on the line 216 in Expansion2_Congress.xml and loaded sav file again. But nothing changed.

    <Row ModifierId="INCREASES_TRADE_TO_GOLD">
    <ModifierType>MODIFIER_PLAYER_CITIES_ADJUST_TRADE_ROUTE_YIELD_TO_OTHERS</ModifierType>

    I'm not sure if I got something wrong or just XML does not change anything built already.
     
  13. Infixo

    Infixo Deity

    Joined:
    Jan 9, 2016
    Messages:
    3,719
    Gender:
    Male
    Location:
    Warsaw
    You wont see a change for a current resolution. You need either a new game or at least this resolution to be applied anew. All active modifiers are copied internally and attached to proper objects, changing xml wont change those internal ones, only new ones.
     
  14. cholsy

    cholsy Warlord

    Joined:
    Dec 20, 2010
    Messages:
    159
    @ Infixo,
    Your fix works.
    Thank you !!
     
    Infixo likes this.
  15. HiRezAudio

    HiRezAudio Prince

    Joined:
    Dec 29, 2007
    Messages:
    370
    Maybe John Curtin is also running this card at the same time? You are definitely getting the bonus though.....
     
  16. Qwan

    Qwan Warlord

    Joined:
    Mar 5, 2010
    Messages:
    117
    This bug about Trade Route Policy benefiting the target (who gets the extra trader) for +4 gpt still exists in [1.0.6.9], please fix.

    Saved games available on request.
     

Share This Page