A bug in CvPlayerAI::AI_counterPropose

[dilandau]

BTS319, CvPlayerAI.cpp Line 5914

5904    int iGoldWeight = iAIDealWeight - iHumanDealWeight;

        if (iGoldWeight > 0)
        {
            if (pGoldNode)
            {
                iGoldData = iGoldWeight * 100;
                iGoldData /= iGoldValuePercent;
5914            if ((iGoldData * iGoldValuePercent) < iGoldWeight)
                {
                    iGoldData++;
                }
                if (GET_PLAYER(ePlayer).AI_maxGoldTrade(getID()) >= iGoldData)
                {
                    pGoldNode->m_data.m_iData = iGoldData;
                    iHumanDealWeight += (iGoldData * iGoldValuePercent) / 100;
                    pTheirCounter->insertAtEnd(pGoldNode->m_data);
                    pGoldNode = NULL;
                }
            }
        }

This line is incorrect.

if ((iGoldData * iGoldValuePercent) < iGoldWeight)

It should be

if ((iGoldData * iGoldValuePercent) < iGoldWeight * 100)

 

[jdog5000]

Yeah, Firaxis got it right in a couple other places but not this one.

 

[Ahovking]

Thanks