1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

bug about guild of hammers and other wonders providing free buildings on every cities

Discussion in 'Civ4 - Fall from Heaven' started by lampuiho, Aug 5, 2008.

  1. lampuiho

    lampuiho Chieftain

    Joined:
    Jul 27, 2008
    Messages:
    49
    I completed those wonders and after that I created the mercurians gate. When I take control of Basium, I immediately lost the forge in that city. Also, new cities don't get those buildings like the mage guild, etc as well. Is it a bug with the wonder? Or is it just supposed to be like that.
     
  2. Amerigo Arturo

    Amerigo Arturo Warlord

    Joined:
    Mar 24, 2008
    Messages:
    105
    They only work for the civilization that owns them. You no longer own them.
     
  3. eerr

    eerr Emperor

    Joined:
    May 27, 2006
    Messages:
    1,077
    the wonders take back what they've given if you loose them
     
  4. lampuiho

    lampuiho Chieftain

    Joined:
    Jul 27, 2008
    Messages:
    49
    no no no... I didn't explain clearly that i built the mercurians gate in the city that i built the guild of hammers.
     
  5. lampuiho

    lampuiho Chieftain

    Joined:
    Jul 27, 2008
    Messages:
    49
    also, even if that is the case, i should still get the free forge because basium and ur original leader will be in the same team. Thus, the benefits should share.
     
  6. Sarisin

    Sarisin Deity

    Joined:
    May 15, 2006
    Messages:
    2,796
    Location:
    NJ
    Yes, I pointed out this bug several versions ago with the Mercurians. The example I used was the Catacombs Libralus. Basium took over the city with that wonder in it, but still had to build a Mage Guild to build Adepts. Likewise, none of the other Mercurian cities had Mage Guilds and had to build them.

    There are still quite a few bugs outstanding with the Mercurians, but I'm sure the development team has higher priorities to work on for now.
     
  7. lampuiho

    lampuiho Chieftain

    Joined:
    Jul 27, 2008
    Messages:
    49
    Because it's still linked to whoever built it. Not whoever owns it...

    EDIT: after some debugging, I believe this is caused by the owner losing the city, thus the free building and specialist bonus but since the Mercurians are in the same team, they lose the bonuses too. But this is after Mercurians getting the city AND the bonuses. Thus making them lose the bonuses straight after gaining the bonus.

    Better/Correct illustration of the problem (I suck at languages, sigh), consider only changeFreeBuildingCount:
    Right after original owner loses city and Guild of Hammers, iChange = -1:
    Owner:
    iOldFreeBuildingCount: 1
    after m_paiFreeBuildingCount[eIndex] = (m_paiFreeBuildingCount[eIndex] + iChange);
    getFreeBuildingCount(eIndex): 0
    forges are removed

    Basium:
    iOldFreeBuildingCount = 0
    after m_paiFreeBuildingCount[eIndex] = (m_paiFreeBuildingCount[eIndex] + iChange);
    getFreeBuildingCount(eIndex): -1
    causing FAssertMsg "getFreeBuildingCount(eIndex) is expected to be greater than 0" shown
    But since the loop to add forge to every city runs when ioldfreebuildingcount is 0
    Basium's cities get free forge for now

    After Basium gains city and Guild of Hammers, iChange = 1:
    Owner:
    iOldFreeBuildingCount: 0
    after m_paiFreeBuildingCount[eIndex] = (m_paiFreeBuildingCount[eIndex] + iChange);
    getFreeBuildingCount(eIndex): 1
    forges are added

    Basium:
    iOldFreeBuildingCount = -1 WTF? STILL -1 even though there is a forge in the city
    after m_paiFreeBuildingCount[eIndex] = (m_paiFreeBuildingCount[eIndex] + iChange);
    getFreeBuildingCount(eIndex) = 0
    else if (getFreeBuildingCount(eIndex) == 0)
    { ... } is run
    BASIUM LOSES THE STUPID FORGE
     
  8. Bad Player

    Bad Player Deity

    Joined:
    Oct 31, 2005
    Messages:
    3,533
    Location:
    (Bris)Vegas!
    I think the More Naval AI team (Tholal) might be the person to mention this bug to (since FFH2 has stopped development and the MNAI modmod is FFH2 with bug fixes and better AI).
     

Share This Page