City States building Wonders

[ExpiredReign]

Just had this notification during one of my current games.

Lhasa has just completed "Banaue Rice Terraces"

Is this supposed to happen?

 

[mitsho]

No, it's not. it did happen to me once but I though it might be because I was running a few other mods to try them out. Banaue is a new wonder though so it might be small bug with those. (In General, it may be helpful to provide the lua log for that turn, though I myself did forget to do that with this bug )

 

[skodkim]

I dont think its going to be in lua.log. Its probably just a question of forgetting to disable the new wonders for City States, which is done by xml.

\Skodkim

 

[mystikx21]

And it seems to be mostly with the new early ones since we've seen it twice now on Banaue. CS is unlikely to be built up enough to build Panama or Itaipu or Wat Phra Kaew.

I didn't even realize that was an issue with wonders and CS and given that I did a chunk of the work on the new wonders... that's on me to have checked that out. I never saw it in any test games so didn't even occur to me as a possibility.

 

[skodkim]

The code is quite simple and can be found in the vanilla files. If I have time I'll see if I can provide an example but I don't have access right now.

/skodkim

 

[skodkim]

Every new wonder should have a tag like this:

Spoiler :

	<Civilization_BuildingClassOverrides>
		<Row>
			<CivilizationType>CIVILIZATION_BARBARIAN</CivilizationType>
			<BuildingClassType>BUILDINGCLASS_BANAUE_RICE_TERRACES</BuildingClassType>
			<BuildingType/>
		</Row>
		<Row>
			<CivilizationType>CIVILIZATION_MINOR</CivilizationType>
			<BuildingClassType>BUILDINGCLASS_BANAUE_RICE_TERRACES</BuildingClassType>
			<BuildingType/>
		</Row>
	</Civilization_BuildingClassOverrides>

This prevents City states and barbarians from building the wonder.

Just checked GEM 1.13.1 and the new wonders don't. As I don't remember all the new wonders I'll just post an example here.

\Skodkim

 

[mystikx21]

Works for me.

Attached with all the new wonders listed.

 

[ExpiredReign]

Guys that is fantastic.

I am constantly amazed at the speed that this mod is fixed/updated.

I guess it just goes to show if you have a good product people will love to keep it going.

Here's to many more months/years of Civup/GEM.

 

[Thalassicus]

I added this fix for Gem 1.13.2.