TC01
Deity
I'm not particularly fond of the use Firaxis has put to custom event managers- replacing CvEventManager entirely in all of their mods. I don't know why they would do this. But I wish they hadn't done it.
The first and obvious issue with it is that if a modder wants to use a Python callback, they have to add it from a copy of the BTS CvEventManager. They also have to add a bit of code that executes whatever default Firaxis code is in BTS's CvEventManager. If Final Frontier Plus used a normal event manager, they wouldn't need to do any of this.
The second issue, which only came to my attention recently, is other custom event managers. keldath has been working on merging BBAI and Babylon 5, and part of the BBAI code is a CvCustomEventManager file. And he's been having a little trouble with it (we've talked via PM about it, and he'll probably post more about it in this forum soon).
So now, the point of this topic- would it be a good idea or a bad idea to remove CvFinalFrontierEvents.py and move all the code back to CvEventManager? This would contain all the unique Final Frontier functions too (unless I made a new FinalFrontier.py file, for organizational purposes).
The only point against this that I can think of is that it would make merging with other mods trickier. At the moment, you could use WinMerge to merge, say, the FF+ CvFinalFrontierEvents and the Star Trek CvFinalFrontierEvents.py. You could not, however, do this if I switched to CvEventManager. Why? Because the order of functions in both files would be different. (At least, I'm pretty sure it would be).
Opinions? Please vote in the poll and post what you think.
The first and obvious issue with it is that if a modder wants to use a Python callback, they have to add it from a copy of the BTS CvEventManager. They also have to add a bit of code that executes whatever default Firaxis code is in BTS's CvEventManager. If Final Frontier Plus used a normal event manager, they wouldn't need to do any of this.
The second issue, which only came to my attention recently, is other custom event managers. keldath has been working on merging BBAI and Babylon 5, and part of the BBAI code is a CvCustomEventManager file. And he's been having a little trouble with it (we've talked via PM about it, and he'll probably post more about it in this forum soon).
So now, the point of this topic- would it be a good idea or a bad idea to remove CvFinalFrontierEvents.py and move all the code back to CvEventManager? This would contain all the unique Final Frontier functions too (unless I made a new FinalFrontier.py file, for organizational purposes).
The only point against this that I can think of is that it would make merging with other mods trickier. At the moment, you could use WinMerge to merge, say, the FF+ CvFinalFrontierEvents and the Star Trek CvFinalFrontierEvents.py. You could not, however, do this if I switched to CvEventManager. Why? Because the order of functions in both files would be different. (At least, I'm pretty sure it would be).
Opinions? Please vote in the poll and post what you think.
