1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

[FIXED in 1.0.1.135] Hagia Sophia rounding error

Discussion in 'Civ5 - Bug Reports' started by prodigitize, Nov 8, 2010.

  1. prodigitize

    prodigitize Chieftain

    Joined:
    May 18, 2008
    Messages:
    29
    This was briefly mentioned in the Angkor Wat thread - the +33% bonus to GP should in fact be +1/3 but when producing 3 GP, it will take 99% of 3 and round down, i.e. not give any bonus when it should in fact give +1 bonus.

    screenshot

    Taj Mahal is +2 great artist and Hagia Sophia is +1 so clearly I should have +3 and a 1/3 bonus which should make it +4 great artist but I'm only getting +3.

    I would imagine that making the bonus +34% would solve the issue or better yet, allow decimals for great people like with production and food.
     
  2. The_J

    The_J Say No 2 Net Validations Retired Moderator Supporter

    Joined:
    Oct 22, 2008
    Messages:
    32,974
    Location:
    DE/NL/FR
    Please provide a savegame for this situation.
     
  3. Mercade

    Mercade the Counsellor

    Joined:
    Nov 8, 2002
    Messages:
    2,636
    Location:
    The Netherlands
    Confirmed, with SaveFile: http://www.sendspace.com/file/a5her3 (Askia_0165 AD-1700.zip)

    Technically it is working as advertised, but that's not the way it is intended. Look at the city of Gao. It has Hagia Sophia giving a 33% Great Person bonus. With the library you can have one or two scientists, each giving 3 GS points.

    1 scientist -> 3 GS points -> with HS: 3 x 1.33 = 3.99 -> truncated to 3 GS points
    2 scientists -> 6 GS points -> with HS: 6 x 1.33 = 7.98 -> truncated to 7 GS points

    Clearly the intention is that if you have 1 scientist + HS it should give 4 GS points.

    The easiest way to fix this is to make the Hagia Sophia give +34% Great Person bonus.
    Another solution would be to apply proper rounding on all floating point calculations, but that has wider implications.

    Incidentally the same effect can be observed with the Sistine Chapel giving +33% culture, so a city with 6 culture produces 7 instead of 8.
     
  4. The_J

    The_J Say No 2 Net Validations Retired Moderator Supporter

    Joined:
    Oct 22, 2008
    Messages:
    32,974
    Location:
    DE/NL/FR
    I trust you, that you know what you're saying.

    Moderator Action: Bug confirmend and thread moved.
     
  5. Perkus

    Perkus Prince

    Joined:
    Oct 16, 2010
    Messages:
    316
    Location:
    Ontario, Canada
    Mercade is correct, I questioned this exact same thing before, thinking it a bug. I doubt they're going to do anything about it.
     
  6. Mercade

    Mercade the Counsellor

    Joined:
    Nov 8, 2002
    Messages:
    2,636
    Location:
    The Netherlands
    To rephase the math in a simple way, currently it works as follows:

    1 specialist gives 0 extra Great Person Points
    2 specialists give 1 extra Great Person Point
    3 specialists give 2 extra Great Person Points

    So why would a person with one specialist not benefit from the Hagia Sophia Wonder effect? Much more reasonable would be:

    1 specialist gives 1 extra Great Person Point
    2 specialists give 2 extra Great Person Points
    3 specialists give 3 extra Great Person Points

    The principle is clear. There should be a benefit to a Wonder when you build it, even at lower numbers.
     
  7. BomberEscort

    BomberEscort Don't be alarmed; this is a kindness Supporter

    Joined:
    Jul 28, 2003
    Messages:
    1,125
    Gender:
    Male
    Location:
    Kansas City
    This has been fixed for 1.0.1.135. They changed the bonus to 34%! Also fixed for the Sistine Chapel!
     
  8. The_J

    The_J Say No 2 Net Validations Retired Moderator Supporter

    Joined:
    Oct 22, 2008
    Messages:
    32,974
    Location:
    DE/NL/FR
    Thanks for reporting, and thanks for reporting :D.
    Changed it on the list.
     
  9. Mercade

    Mercade the Counsellor

    Joined:
    Nov 8, 2002
    Messages:
    2,636
    Location:
    The Netherlands
    J, can you also update the title of this thread with [Fixed in 1.135] ?
     
  10. The_J

    The_J Say No 2 Net Validations Retired Moderator Supporter

    Joined:
    Oct 22, 2008
    Messages:
    32,974
    Location:
    DE/NL/FR
    No, i can't...because Petek already did it :D.
     

Share This Page