1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

Leugi's Israel for VP

Discussion in 'Mods Repository' started by pineappledan, Apr 5, 2018.

  1. Golan v

    Golan v Warlord

    Joined:
    Oct 31, 2016
    Messages:
    160
    Gender:
    Male
    Location:
    Israel
    Realy? Where? Maby on steam you ment :/
     
  2. adan_eslavo

    adan_eslavo Archmage of all Pixels Supporter

    Joined:
    Apr 23, 2017
    Messages:
    2,026
    Gender:
    Male
    Location:
    Łódź, Poland
    Civ 6 art is awesome and I can see @Leugi did great job there. I love art from civ 6 (the only thing worth in that game :/).
    Off-topic: what do you think about current civ 6 civilization set? I suppose all those civs are also available for civ 5.
    @pineappledan I check Tomatekh after v37 release probably. For now I'm doing code checking and do not want to split my attention too much.
     
  3. pineappledan

    pineappledan Deity

    Joined:
    Aug 9, 2017
    Messages:
    5,003
    Gender:
    Male
    Location:
    Alberta, Canada
    .... yes, on steam. I provided a link to the steam page in my previous comment.
     
  4. adan_eslavo

    adan_eslavo Archmage of all Pixels Supporter

    Joined:
    Apr 23, 2017
    Messages:
    2,026
    Gender:
    Male
    Location:
    Łódź, Poland
    I looked through Sumer code and really cannot find source of error, sorry. We need some help. Or delete code partially and check for errors. That's one of the moethods I sometimes use. Very time consuming.
    Spoiler King's Solomon Mines and Israel :
    upload_2018-9-3_22-38-28.png


    Strange thing, but maybe worth mentioning. I added Papal States and Israel. Two games, and two quick crashes after few turns. Earlier I played with the same mod config without those 2 civs and everything was fine. I cannot find crash logs.
     
    Last edited: Sep 3, 2018
  5. pineappledan

    pineappledan Deity

    Joined:
    Aug 9, 2017
    Messages:
    5,003
    Gender:
    Male
    Location:
    Alberta, Canada
    I found it. There were some commas missing in the SQL for the ziggurat, near the very bottom
    I loaded up Israel and got the exact same crash. 4 turns and the whole game just shuts down.

    I'm turning off various lua codes right now to see if the problem is there
     
    Last edited: Sep 3, 2018
    adan_eslavo likes this.
  6. pineappledan

    pineappledan Deity

    Joined:
    Aug 9, 2017
    Messages:
    5,003
    Gender:
    Male
    Location:
    Alberta, Canada
    I've deduced that ChangeFaith() is causing the crash.

    Code:
    function ShofetCultureFaith(iPlayer)
        local pPlayer = Players[iPlayer]
        local iNumShoph = pPlayer:GetNumUnits(GameInfoTypes.UNIT_ISRAEL_SHOPHET)
        pPlayer:ChangeJONSCulture(2 * iNumShoph)
        pPlayer:ChangeFaith(iNumShoph)
    end
    
    GameEvents.PlayerDoTurn.Add(ShofetCultureFaith)
    I played a game into classical with this code disabled, then played again with ChangeFaith specifically disabled, and it worked fine both times. I'm going to try to do another game with a dummy building which gives the faith and culture, and hopefully that works.
    Code:
    function ShofetCultureFaith(iPlayer)
        local pPlayer = Players[iPlayer]
        local pCapital = pPlayer:GetCapitalCity()
        pCapital:SetNumRealBuilding(GameInfoTypes.BUILDING_SHOPHET_DUMMY, pPlayer:GetNumUnits(GameInfoTypes.UNIT_ISRAEL_SHOPHET))
    end
    
    GameEvents.PlayerDoTurn.Add(ShofetCultureFaith)
     
  7. adan_eslavo

    adan_eslavo Archmage of all Pixels Supporter

    Joined:
    Apr 23, 2017
    Messages:
    2,026
    Gender:
    Male
    Location:
    Łódź, Poland
    Strange because we use change faith in mucfvp mod in Qizilbash fe. Should work.
     
  8. pineappledan

    pineappledan Deity

    Joined:
    Aug 9, 2017
    Messages:
    5,003
    Gender:
    Male
    Location:
    Alberta, Canada
    Is there ever a possibility that the changefaith amount is 0 in those codes? That might be the problem
     
  9. adan_eslavo

    adan_eslavo Archmage of all Pixels Supporter

    Joined:
    Apr 23, 2017
    Messages:
    2,026
    Gender:
    Male
    Location:
    Łódź, Poland
    So add if statement. But in culture code 2*0 is still 0 so tak with it both lines. And check.
     
  10. pineappledan

    pineappledan Deity

    Joined:
    Aug 9, 2017
    Messages:
    5,003
    Gender:
    Male
    Location:
    Alberta, Canada
    It's fine. I've already tested the version with dummy buildings, and that allows the culture and faith to be added to the top ribbon.
     
  11. adan_eslavo

    adan_eslavo Archmage of all Pixels Supporter

    Joined:
    Apr 23, 2017
    Messages:
    2,026
    Gender:
    Male
    Location:
    Łódź, Poland
    SQL errors still show up. New units do not load at all.
     
  12. pineappledan

    pineappledan Deity

    Joined:
    Aug 9, 2017
    Messages:
    5,003
    Gender:
    Male
    Location:
    Alberta, Canada
    Have you downloaded the right version? There’s a 4UC version and a base version. You only need 1
     
  13. adan_eslavo

    adan_eslavo Archmage of all Pixels Supporter

    Joined:
    Apr 23, 2017
    Messages:
    2,026
    Gender:
    Male
    Location:
    Łódź, Poland
    I got such errors. I have right version.

    [49556.962] no such table: MinorCiv_YagemStartPosition
    [49557.040] table Building_YieldPerXTerrainTimes100 has no column named FeatureType

    One error in sql and you cannot load anything.
     
  14. pineappledan

    pineappledan Deity

    Joined:
    Aug 9, 2017
    Messages:
    5,003
    Gender:
    Male
    Location:
    Alberta, Canada
    I will re-upload the versions I have. Both are working fine on my end.

    The yagenmp table missing is an Israel error I cleared last version. The yield per terrain is an error I cleared from Sumer’s last version. I am quite certain you are using old versions of both mods; please reinstal.

    I will reupload my newest version for my own sanity, just in case.
     
    adan_eslavo likes this.
  15. adan_eslavo

    adan_eslavo Archmage of all Pixels Supporter

    Joined:
    Apr 23, 2017
    Messages:
    2,026
    Gender:
    Male
    Location:
    Łódź, Poland
    You posted wrong resource before. I downloaded one more time link and it was normal. Then you reuploaded and now it works fine.
     
  16. pineappledan

    pineappledan Deity

    Joined:
    Aug 9, 2017
    Messages:
    5,003
    Gender:
    Male
    Location:
    Alberta, Canada
    If anyone has opinions on the newest version of Israel, I would really like some input. I moved the temple to Construction because I had several cases in my own games where the AI failed to found a religion. I am considering removing the bonus yields on GP expend, and reducing the bonus faith on completion to 100. I'm unhappy with how similar the bonus on completion is to Stonehenge, but It's far too thematic for the building to give up:

     
  17. Omen of Peace

    Omen of Peace Prince

    Joined:
    Mar 22, 2018
    Messages:
    375
    Gender:
    Male
    Just one data point, but in my current game (Quick, Small, Communitas) the Tradition Israel AI was ahead by two policies and a bunch of techs already in Classical, which seems a bit much (I'm Tradition India).
    His monopoly is Lapis-Lazuli, so that probably helped with culture - and having a synergistic tech path - but still. Of course it's possible he got 3 culture ruins or something.

    We both founded around turn 50 (so that would be something like 70 in Standard speed).
     
  18. pineappledan

    pineappledan Deity

    Joined:
    Aug 9, 2017
    Messages:
    5,003
    Gender:
    Male
    Location:
    Alberta, Canada
    The solomon’s temple is too good, now that it has been moved forward. I’m going to nerf it good and hard in an upcoming patch.

    UA
    +2:c5faith: Faith and :c5culture: Culture for all GP improvements and Great Works (from 2:c5culture:/1:c5faith: on GPI and 1:c5culture:/2:c5faith: on GW).
    Simpler, reduces text in UA, which was pouring onto the 4th line, and strengthens Israel's mid-game. minimal impact on early game.

    UW
    7 :c5faith:Faith, 3 :c5culture:Culture, 3 :c5gold:Gold (down from 7:c5faith:/5:c5culture:/3:c5gold:)
    Instant boost of 100:c5faith:Faith on completion (down from 200:c5faith:)
    No yields on GP expend (used to be 36:c5culture: on GP expend)

    4UC
    Shofet generates 2:c5faith:/2:c5culture: per turn (up from 2:c5culture:1:c5faith:, consistent with change to UA)

    EDIT: new version is live
     
    Last edited: Sep 23, 2018
  19. infidel88

    infidel88 Prince

    Joined:
    Jul 29, 2013
    Messages:
    478
    Location:
    Yuggoth
    In my game, Israel is producing 4:c5faith: in capital from the start. It says 'from building' in tooltip, but there is nothing built in capital except for Palace and this has 0:c5faith: on it. Any ideas?

    Edit - At turn 13 it's 7:c5culture: and 6:c5faith: from buildings :crazyeye:
     
  20. pineappledan

    pineappledan Deity

    Joined:
    Aug 9, 2017
    Messages:
    5,003
    Gender:
    Male
    Location:
    Alberta, Canada

Share This Page