Problems like these can be solved using the Lua.log as you'll get runtime errors there!
-----
Now for your actual issue:
First of all, you have an extra 'end'. Remove the penultimate 'end' as (with the current indents) it does not suggest that it should be there.
Secondly, you call this:
Code:
CheckNewCityTundra(kCity,true)
whereas you defined the function as this:
Code:
function CheckNewCityTundra(iPlayer)
There are two problems with this:
1) You call the function using two parameters (kCity and true), while in fact you only should call one (iPlayer)
2) You pass kCity as a parameter to CheckNewCityTundra, while you should pass iPlayer as you defined it like that
Also, most modders use a thing called
Hungarian Notation, which causes those letters to be placed in front of variable names. Here's a quick rundown:
sCity is used for a variable that contains a
string, probably a name of the City as that's what suggested by the variable-name.
pPlayer is the
pointer towards a Player object, which can be used for functions such as pPlayer:GetName() and such.
iPlayer is an
integer, usually a player ID as that's also an integer. We could also have
bCityHasTundra, which is a
boolean. Lastly, there's
tCity, which means a
table of cities. In general, the variable-name describes what is stored (something related to cities, players, units, etc.), and the extra letter describes what type of data is stored (boolean, integer, table, etc.)
;tldr Use pPlot instead of kplot, and use pCity instead of kCity
Furthermore, there seems to be a logical error in your code. For every plot, if it is not tundra, we remove the dummy from the city. This means that, if the last plot we check is not a tundra, while all other plots are tundra, we do not get the dummy! In fact, since you only run this function once (when the city is founded), you can actually just remove the whole line which states 'pCity:SetNumRealBuilding(iDummyB, 0)', as the city won't have this building upon being founded anyhow. (I left it in in the code below if you do not want to remove it for some reason)
I also suggest you add some print()s (which show up in the Lua.log), and allow for easier debugging
Lastly, you seem to use two notations throughout each other. While that's perfectly fine, it makes it less clear. I suggest using one of the following methods:
Code:
local iDummyB = GameInfoTypes.BUILDING_DUMMY_TURF_HALL_REQ
GameEvents.PlayerCityFounded.Add(function (iPlayer,iCityX,iCityY)
local pPlot = Map.GetPlot(iCityX,iCityY)
local pCity = pPlot:GetPlotCity();
print("Checking "..pCity:GetName())
pCity:SetNumRealBuilding(iDummyB, 0);
for i = 0, pCity:GetNumCityPlots() - 1, 1 do
local pPlot = pCity:GetCityIndexPlot(i)
if pPlot:GetTerrainType() == TerrainTypes.TERRAIN_TUNDRA then
print("Tundra found at ("..pPlot:GetX()..","..pPlot:GetY()..")")
pCity:SetNumRealBuilding(iDummyB, 1);
end
end
end)
or
Code:
local iDummyB = GameInfoTypes.BUILDING_DUMMY_TURF_HALL_REQ
function CheckNewCityTundra(iPlayer,iCityX,iCityY)
local pPlot = Map.GetPlot(iCityX,iCityY)
local pCity = pPlot:GetPlotCity();
print("Checking "..pCity:GetName())
pCity:SetNumRealBuilding(iDummyB, 0);
for i = 0, pCity:GetNumCityPlots() - 1, 1 do
local pPlot = pCity:GetCityIndexPlot(i)
if pPlot:GetTerrainType() == TerrainTypes.TERRAIN_TUNDRA then
print("Tundra found at ("..pPlot:GetX()..","..pPlot:GetY()..")")
pCity:SetNumRealBuilding(iDummyB, 1);
end
end
end
GameEvents.PlayerCityFounded.Add(CheckNewCityTundra)
I prefer the latter as I personally find that clearer
