Need help with hook - TeamSetEra

Craig_Sutter · Oct 3, 2015

This code is meant to spawn a settler when sweden enters a new era... could not find a working example. Onmodactivated, etc. is set properly.

error in log:

Code:

[1395416.978] Runtime Error: C:\Users\doms\Documents\My Games\Sid Meier's Civilization 5\MODS\The Viking Age for BNW (v 2)\LUA/SwedenTrait.lua:45: attempt to call field 'TeamSetEra' (a table value)
[1395416.978] Runtime Error: Error loading C:\Users\doms\Documents\My Games\Sid Meier's Civilization 5\MODS\The Viking Age for BNW (v 2)\LUA/SwedenTrait.lua.

Code:

-- Lua Script1
-- Author: Craig and Nancy
-- DateCreated: 7/23/2014 11:50:56 PM
--------------------------------------------------------------

function  SwedenSettler(teamId, eEra)

-- Set up Sweden Player

	for iPlayer=0, GameDefines.MAX_MAJOR_CIVS-1 do 

	local pSweden = Players[iPlayer]

		if (GameInfo.Civilizations.CIVILIZATION_SWEDEN.ID == pSweden:GetCivilizationType()) then
	
		Sweden = pSweden
		SwedenTeamID = Sweden:GetTeam();
		SwedenTeam= Teams[ Sweden:GetTeam() ]

		end	
	end

--Spawn Units
	
	if teamID==SwedenTeamID then
		
		if eEra>0 then

			local pCity = Sweden:GetCapitalCity()				
			if pCity then

			local pPlot = pCity:Plot();
			local Spawnunit;
			local iSpawnX = pPlot:GetX();
			local iSpawnY = pPlot:GetY();

			Spawnunit = Sweden:InitUnit(GameInfoTypes["UNIT_SETTLER"], iSpawnX, iSpawnY, UNITAI_SETTLE, DIRECTION_NORTHWEST )
			print (Sweden:GetName() ,"...is spawning settler due to Era change in...", pCity:GetName());
	
			end	
		end
	end

end
						
GameEvents.TeamSetEra(SwedenSettler);

Thank-you in advance.

LeeS · Oct 3, 2015

Haven't looked through the rest of the code as yet, but:

Code:

GameEvents.TeamSetEra(SwedenSettler)

needs to be

Code:

GameEvents.TeamSetEra.Add(SwedenSettler)

Craig_Sutter · Oct 3, 2015

May have found it...

GameEvents.TeamSetEra(SwedenSettler);

should be GameEvents.TeamSetEra.Add(SwedenSettler);

and

if eEra>0 then

should be eEra>=0

Hope that's all

Craig_Sutter · Oct 3, 2015

Jinx

Craig_Sutter · Oct 4, 2015

This code is still not working. The green print statements show up, but not the red... which is bizarre since I've used that part of the function many times. The blue line is the likely culprit, although I cannot see why...

Code:

function  SwedenSettler(teamId, eEra)

local Sweden
local SwedenTeamID

[COLOR="Lime"]print("eEra = " .. eEra)[/COLOR]

	if eEra>=0 then
	[COLOR="Lime"]print("eEra confirmed at..." .. eEra)[/COLOR]

		for iPlayer=0, GameDefines.MAX_MAJOR_CIVS-1 do 

		local Sweden = Players[iPlayer]

			if (GameInfo.Civilizations.CIVILIZATION_SWEDEN.ID == Sweden:GetCivilizationType()) then
				
				local SwedenTeamID = Sweden:GetTeam()
				[COLOR="Lime"]print (Sweden:GetName() ,"...confirmed as on team");[/COLOR]

				[COLOR="RoyalBlue"]if	SwedenTeamID == teamID then[/COLOR]
						
					local pCity = Sweden:GetCapitalCity()
					local pPlot = pCity:GetCityIndexPlot();
					local Spawnunit;
					local iSpawnX = pPlot:GetX();
					local iSpawnY = pPlot:GetY();

					Spawnunit = Sweden:InitUnit(GameInfoTypes["UNIT_SETTLER"], iSpawnX, iSpawnY, UNITAI_SETTLE, DIRECTION_NORTHWEST )
					[COLOR="Red"]print (pCity:GetName() ,"...is spawning a Settler from switching eras... ");[/COLOR]

				end		
			end
		end
	end
end

GameEvents.TeamSetEra.Add(SwedenSettler);

Finally, this was in the log...

Spoiler :

LeeS · Oct 4, 2015

Code:

local iSwedenID = GameInfoTypes.CIVILIZATION_SWEDEN

function SwedenSettler(teamId, eEra)
	--if eEra > 0 then
		--print("eEra confirmed at..." .. eEra)
		for iPlayer = 0, GameDefines.MAX_MAJOR_CIVS - 1, 1 do
			if (Players[iPlayer] ~= nil) then
				if (Players[iPlayer]:GetTeam() == teamId) then
					if Players[iPlayer]:GetCivilizationType() == iSwedenID then
						local pPlayer = Players[iPlayer]
						print (pPlayer:GetName() .. " ...confirmed as on team " .. teamId);
						if pPlayer:GetNumCities() > 0 then
							pPlayer:InitUnit(GameInfoTypes["UNIT_SETTLER"], pPlayer:GetCapitalCity():GetX(), pPlayer:GetCapitalCity():GetY())
							print (pPlayer:GetCapitalCity():GetName() .. " ...is spawning a Settler from switching eras...");
						else
							print ("player has no capital city to spawn a settler in");
						end
						return
					end
				end
			end
		end
	--end
end
GameEvents.TeamSetEra.Add(SwedenSettler)

eEra is always going to meet the ">=" condition so there is no real need for that conditional within the code. I commented-out the conditional-check for ">" in the code shown, along with its required "end" and the print statement to go along with it. Taking the comments out would make the player only get the free settler at the Classical and higher eras.
The code as presented 'caches' the ID# of CIVILIZATION_SWEDEN at game loading, though for the TeamSetEra hook doing so probably won't save much processing time since TeamSetEra simply doesn't fire all that often.
I think the code as you had it had problems with localization issues of variables, multiple re-creation of the same variable-names, etc.
- Each statement of
  Code:
```
local iPizzaParlor = xyz
```
  creates a new local variable for that "level" of the function with a variable name of iPizzaParlor.
- manipulation of this new deeper-level variable called iPizzaParlor within the scope of the new deeper-level of the function does not pass the change in the data within iPizzaParlor back up the chain in levels to the previous "higher-up" level of the function.
- in order to get updates and changes to data held within a variable to be "passed back up the chain" to a higher level of the function, it is necessary to set the name of the variable at the outset of the function before any "if", "for", "while", etc., blocks of code:
  Code:
```
function PizzaHandler(iPlayer)
	local iPizzaParlor = false
	if Players[iPlayer]:GetCivilizationType() == GameInfoTypes.CIVILIZATION_PIZZASHACK then
		iPizzaParlor = true
	end
	if iPizzaParlor == true then
		print("Yum!!")
	else print("But I am hungry!")
	end
end
```
  Note that in the example I did not anywhere restate
  Code:
```
local iPizzaParlor =
```
  I instead simply referenced to the existing local variable name that was first created at the highest level of the function's "food chain".

Craig_Sutter · Oct 4, 2015

Thank-you. That works.

And thank-you for teaching me a bit more about lua, too. It'll be useful in future.

Need help with hook - TeamSetEra

Craig_Sutter

Deity

LeeS

Imperator

Craig_Sutter

Deity

Craig_Sutter

Deity

Craig_Sutter

Deity

LeeS

Imperator

Craig_Sutter

Deity

Similar threads