1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

Small Projects Bulletin

Discussion in 'Rhye's and Fall - Dawn of Civilization' started by Leoreth, Jul 21, 2018.

  1. Leoreth

    Leoreth Fluffy Boy Moderator

    Joined:
    Aug 23, 2009
    Messages:
    31,536
    Gender:
    Male
    Location:
    Dark World
    A while ago some people expressed interest in taking up small things that need work with the mod. From my perspective, these are probably bug fixes or small quality of life changes that I would eventually get around to doing, but usually can also be completed by someone else while I work on a larger feature that gets the mod forward.

    I have created this thread to post about things like this that are to do so you can pick them up and submit a pull request. Please announce that you start working on it so we don't have two people working on the same thing.

    (Please do not use this thread to report issues, I will update it from the bug report thread as I find necessary.)

    Your support is appreciated!

    Current to do list:
    • Turkic leaders lack intro texts: Bumin, Alp Arslan and Tamerlane have an empty greeting texts. They should at least use the default greeting text
    • Issue with Bumin LH: part of the fur on Bumin's hat is incorrectly rendered and flickering in and out
    • Wrong modifiers due to Khmer reordering: when the position of the Khmer in the spawn order was changed, the comments in Modifiers.py were not updated accordingly. This means that subsequent changes for civs between the old and current position of the Khmer may be wrong. So all changes to the file since the reordering need to be reviewed if that is the case.
    • Ottoman dawn of man text: at least in the 1700 AD scenario, the Ottoman dawn of man text incorrectly shows TXT_KEY_DOM_TURKEY instead of using the correct TXT_KEY_DOM_OTTOMANS_1700AD text key.
    • It should be possible to build Quarries on Rainforest with the right technology.
     
    Last edited: Jul 31, 2018
    Publicola, merijn_v1 and 1SDAN like this.
  2. Sataa3a

    Sataa3a Chieftain

    Joined:
    Sep 26, 2012
    Messages:
    42
    Location:
    United States
    I can take a stab at the dawn of man text. I can see how to easily fix it for the case of Ottomans, but the way currently dawn of man text is pulled is hacky and will cause problems with the non-English versions (launch the mod in French, China's text is just TXT_KEY_DOM_CHINE), so I'd like to fix it overall and not just for English-speaking Ottoman players.
     
  3. Leoreth

    Leoreth Fluffy Boy Moderator

    Joined:
    Aug 23, 2009
    Messages:
    31,536
    Gender:
    Male
    Location:
    Dark World
    If you can, that's fine. It's probably easiest to force using the English text when sythesising the text keys.
     
  4. merijn_v1

    merijn_v1 Black Belt

    Joined:
    Dec 29, 2008
    Messages:
    5,269
    Location:
    The city of the original vlaai
    Wouldn't it be easier if the gc.getCivilizationInfo(iCiv).getIdentifier() function is used?

    EDIT:
    I think this could also be used to fix the translation key problems with the DCN.
     
    Last edited: Sep 16, 2018
  5. Leoreth

    Leoreth Fluffy Boy Moderator

    Joined:
    Aug 23, 2009
    Messages:
    31,536
    Gender:
    Male
    Location:
    Dark World
    Easier? Tons of text keys would need to be changed. It's possible to control the returned language so that's the best way to go imo.
     
  6. Sataa3a

    Sataa3a Chieftain

    Joined:
    Sep 26, 2012
    Messages:
    42
    Location:
    United States
    That requires changing many of the text keys, correct? The identifier is three characters, but keys seem to use the short description. It is the cause of that problem too, yes.

    Is the identifier currently only used for the UHV and UP text keys? I'm curious why some keys are using it and some the full name.
     
  7. Leoreth

    Leoreth Fluffy Boy Moderator

    Joined:
    Aug 23, 2009
    Messages:
    31,536
    Gender:
    Male
    Location:
    Dark World
    I was asking myself the same thing, honestly I think it's for historical reasons. The identifier existed long before it was possible to retrieve it using the CvCivilizationInfo API.
     
  8. merijn_v1

    merijn_v1 Black Belt

    Joined:
    Dec 29, 2008
    Messages:
    5,269
    Location:
    The city of the original vlaai
    I am aware that it requires changing a lot of text keys. But once it is done, all problems regarding languagues creating wrong text keys are gone.

    I was never able to control the returned language. How do you do that?
     
  9. Leoreth

    Leoreth Fluffy Boy Moderator

    Joined:
    Aug 23, 2009
    Messages:
    31,536
    Gender:
    Male
    Location:
    Dark World
    You're right, apparently you can only temporarily change the language which isn't very elegant either. I guess then the best solution is to change the identifier to match the short description.
     
  10. Sataa3a

    Sataa3a Chieftain

    Joined:
    Sep 26, 2012
    Messages:
    42
    Location:
    United States
    Sounds good.
     
  11. freethink

    freethink Chieftain

    Joined:
    Dec 17, 2011
    Messages:
    117
    Location:
    Great Light House
    TAMERLANE INTRO TEXT SUGGESTIONS
    By the blows of my well tempered sword I have conquered the greater part of the world to enlarge Samarkand and Bukhara, my capitals and residences; and you, pitiful creature, would exchange these two cities for a mole. Indeed, truth is safety.

    BUMIN INTRO
    I Qaghan Budin was called slave,but I am free, and by rights of sharp swords the son of free men, forging the strength of my people to ride under the sky of Tour Tengri.

    ALP ARSLAN INTRO
    I would like to know as to what you do with your prisoners. My punishment is the heaviest, for I would forgive you and set you to ride free between the west and the east.
     
    Leoreth and ozqar like this.
  12. Leoreth

    Leoreth Fluffy Boy Moderator

    Joined:
    Aug 23, 2009
    Messages:
    31,536
    Gender:
    Male
    Location:
    Dark World
    Sounds good.
     
    freethink likes this.
  13. Leoreth

    Leoreth Fluffy Boy Moderator

    Joined:
    Aug 23, 2009
    Messages:
    31,536
    Gender:
    Male
    Location:
    Dark World
    Is anyone interested in reviewing all quest texts to see if they match their actual requirements, like the one reported here?

    It should be noted that sometimes the solution could be to change the requirements instead. For instance, in the linked issue, the text mentions "modern military techs", and while I have updated the obsoletion techs, I may not have taken the intent of modern military techs into account and chosen other arbitrary techs.
     
  14. Alexius08

    Alexius08 Chieftain

    Joined:
    May 28, 2010
    Messages:
    1,092
    I'll submit a pull request for that one soon.

    Also, I suggest revising the Charismatic event. The text refers to a dictator seizing control of his party and country. However, it is currently set to expire even before the civic unlocking it become accessible. We have to remove the obsoletion techs and review whether the current civic requirement (Ideology) fits the event or needs to be changed to something else (State Party and Totalitarianism are good candidates for replacements).

    We also have to decide if the event and its associated outcomes are intended to represent Napoleon and postcolonial Latin American leaders (which would then require revising the text and possibly making Nationhood as the required civic) or 20th-century totalitarian regimes (by which only the required civic needs to be revised).
     
    Last edited: Oct 8, 2018
    1SDAN, Leoreth and Imp. Knoedel like this.
  15. Leoreth

    Leoreth Fluffy Boy Moderator

    Joined:
    Aug 23, 2009
    Messages:
    31,536
    Gender:
    Male
    Location:
    Dark World
    Thanks.

    I would like the event to represent preferably both, and the Ideology civic is kind of appropriate here, because it already kind of encompasses charismatic leadership that is vested into either a person or a mass movement. Imagine a throughline between revolutionary republics and later totalitarian movements. I'm actually not entirely happy with that civic name but couldn't come up with a better one yet. I considered calling it Revolutionary though because this could feasibly represent the French Republic but also the Soviet Union. It's harder to mesh this with fascist governments though. Totalitarianism on the other seems more like a possible outcome of such an event than its prereq ... there needs to be a sort of rules based system in place that a charismatic person can attain control of in the first place.

    But I haven't looked at the event yet.
     

Share This Page