1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

[NFP] [Still active of 1.0.2.39] Hetairoi not receiving special combat bonus

Discussion in 'Civ6 - Bug Reports' started by Jester of Doom, May 26, 2020.

  1. Jester of Doom

    Jester of Doom Chieftain

    Joined:
    May 26, 2020
    Messages:
    2
    I started playing as Alexander on the mirror map against Gran Columbia and Mongolia, and for some reason my hetairoi are only receiving the standard +5 combat strength bonus from a great general, without receiving their additional +5 bonus. I tested this with several over games, and as far as I can tell the hetairoi no longer gain their additional +5 combat bonus from great generals at all in this patch, despite still listing it in the civilopedia.

    If anyone knows a way to circumvent this bug please tell me. If this isn't something unique to my game then Firaxis needs to do something about this ASAP, either fixing the ability or removing the references to it in the game if this is an intended nerf.

    EDIT: others have reported the bug is still active as of 1.02.39.
     

    Attached Files:

    Last edited: Jul 8, 2020
    mentos15 likes this.
  2. dshirk

    dshirk Firaxian

    Joined:
    Oct 31, 2005
    Messages:
    878
    Could you attach a save that demonstrates this as well? Would love to take a look!
     
  3. Jester of Doom

    Jester of Doom Chieftain

    Joined:
    May 26, 2020
    Messages:
    2
    Here are two saves. One is from the game where I first discovered this bug, but used two unrelated mods: Tomatehk's Historical Religions, and Zebenji's Additional Religions. The other is from a test game I ran without those mods to see if they were responsible, where this bug still manifested itself.
     

    Attached Files:

  4. dshirk

    dshirk Firaxian

    Joined:
    Oct 31, 2005
    Messages:
    878
    Thanks for this. Taking a look.
     
  5. Joshua Taylor

    Joshua Taylor Chieftain

    Joined:
    Jul 6, 2020
    Messages:
    1
    Gender:
    Male
    This seems to still be an active bug fyi
     
  6. Eyswein

    Eyswein Warlord GOTM Staff

    Joined:
    Nov 26, 2016
    Messages:
    284
    Gender:
    Male
    Is this bug still active?

    Edit: As of August 2020 patch the bug still exists, at least in my test.
     
    Last edited: Aug 29, 2020
  7. Lily_Lancer

    Lily_Lancer Deity

    Joined:
    May 25, 2017
    Messages:
    2,269
    Location:
    Berkeley,CA
    Spoiler :

    Screen Shot 2020-09-27 at 11.48.59 PM.png

    The Hetairoi GG extra +5 ability still doesn't work. Poor Macedon.

    Moderator Action: Merged with existing Bug Report thread. leif
     
    Last edited by a moderator: Sep 27, 2020
  8. myclan

    myclan Prince

    Joined:
    Feb 26, 2008
    Messages:
    584
    They also have a bug with Nihang for they don't have a barrack. The +15CS bonus doesn't count with the UB
     
    pokiehl likes this.
  9. yosxpeee

    yosxpeee Chieftain

    Joined:
    Feb 9, 2018
    Messages:
    5
    Gender:
    Male
    Fix code this.

    <BuildingModifiers>
    <Row BuildingType="BUILDING_BASILIKOI_PAIDES" ModifierId="LAHORE_NIHANG_BARRACKS_ABILITY"/>
    </BuildingModifiers>
     
  10. cholsy

    cholsy Warlord

    Joined:
    Dec 20, 2010
    Messages:
    138
    There is a MOD to fix Hetairoi from a Modder. I'd like to thank him/her.

    https://steamcommunity.com/sharedfiles/filedetails/?id=2183461036

    If my understanding is right, what he/she did is to define the type as MODIFIER_SINGLE_UNIT_ATTACH_MODIFIER first, with requirement.
    And then he/she replaced its type to MODIFIER_UNIT_ADJUST_COMBAT_STRENGTH later.

    I'm not good at Modding but tried to make the original MOD simpler, as same concept.

    Spoiler fix :

    <UnitAbilityModifiers>
    <Row>
    <UnitAbilityType>ABILITY_HETAIROI</UnitAbilityType>
    <!-- <ModifierId>HETAIROI_GREAT_GENERAL_COMBAT_BONUS</ModifierId> DELETE -->
    <ModifierId>HETAIROI_NEIGHBOR_COMBAT</ModifierId> <!-- INSERT -->
    </Row>
    </UnitAbilityModifiers>

    <Modifiers>
    <Row> <!-- INSERT -->
    <ModifierId>HETAIROI_NEIGHBOR_COMBAT</ModifierId>
    <ModifierType>MODIFIER_SINGLE_UNIT_ATTACH_MODIFIER</ModifierType>
    <SubjectRequirementSetId>UNIT_ADJACENT_TO_GREAT_GENERAL_REQUIREMENTS</SubjectRequirementSetId>
    </Row>
    <Row>
    <ModifierId>HETAIROI_GREAT_GENERAL_COMBAT_BONUS</ModifierId>
    <ModifierType>MODIFIER_UNIT_ADJUST_COMBAT_STRENGTH</ModifierType>
    <!-- DELETE <SubjectRequirementSetId>UNIT_ADJACENT_TO_GREAT_GENERAL_REQUIREMENTS</SubjectRequirementSetId> -->
    </Modifiers>

    <ModifierArguments>
    <Row> <!-- INSERT -->
    <ModifierId>HETAIROI_NEIGHBOR_COMBAT</ModifierId>
    <Name>ModifierId</Name>
    <Value>HETAIROI_GREAT_GENERAL_COMBAT_BONUS</Value>
    </Row>
    </ModifierArguments>


    I tested and it seems to work but I don't understand how the mechanism works exactly. If anybody can explain, it will help.
     
    Last edited: Oct 9, 2020
  11. Laurana Kanan

    Laurana Kanan Don’t underestimate who I am.

    Joined:
    Apr 10, 2014
    Messages:
    2,846
    Gender:
    Female
    Location:
    Near the Greatest Snow on Earth
    Hmm, missed this one being uploaded, but good find. :thumbsup:
    I didn't really look over your simplification, but here's one via SQL that eliminates all the Delete statements and the unnecessary redefining of the modifiers, requirements, etc. in the original mod.
    Code:
    -----------------------------------------------
    --Modifiers
    -----------------------------------------------
    
    INSERT INTO Modifiers
           (ModifierId,                                     ModifierType,                             SubjectRequirementSetId)
    VALUES ('MODIFIER_LK_HETAIROI_GG_COMBAT_BONUS_ATTACH', 'MODIFIER_SINGLE_UNIT_ATTACH_MODIFIER',    'UNIT_ADJACENT_TO_GREAT_GENERAL_REQUIREMENTS');
    
    UPDATE Modifiers SET SubjectRequirementSetId = NULL WHERE ModifierId = 'HETAIROI_GREAT_GENERAL_COMBAT_BONUS';
    
    -----------------------------------------------
    --ModifierArguments
    -----------------------------------------------
    
    INSERT INTO ModifierArguments
           (ModifierId,                                     Name,             Value)
    VALUES ('MODIFIER_LK_HETAIROI_GG_COMBAT_BONUS_ATTACH', 'ModifierId',     'HETAIROI_GREAT_GENERAL_COMBAT_BONUS');
    
    -----------------------------------------------
    --UnitAbilityModifiers
    -----------------------------------------------
    
    UPDATE UnitAbilityModifiers SET ModifierId = 'MODIFIER_LK_HETAIROI_GG_COMBAT_BONUS_ATTACH'
    WHERE UnitAbilityType = 'ABILITY_HETAIROI' AND ModifierId = 'HETAIROI_GREAT_GENERAL_COMBAT_BONUS';
    
    The mod uses the same mechanism that is used for the adjacent Hoplite combat bonus ability, which is what the game should have used to begin with. It uses a separate modifier to broadcast, or attach, the combat modifier to the unit if the requirement set is satisfied. The original code misses that step.
     
  12. cholsy

    cholsy Warlord

    Joined:
    Dec 20, 2010
    Messages:
    138
    Really appreciate your comment and advice.
    Thank you Laurana!! :lol:
     
  13. Machine_Maker

    Machine_Maker Chieftain

    Joined:
    Oct 15, 2020
    Messages:
    1
    Gender:
    Male
    Glad to see this is a known issue. Was just trying out the Conquests of Alexander scenario, and then noticed I wasn't getting that extra boost from being adjacent to alexander.
     

Share This Page