The bug is in your code.
The AddLakes function is executed by GenerateMap()
after base terrain is generated and there is no more need for the cached data in lua table "terrainTypes". So AddLakes(args) does not update the "terrainTypes" table. AddLakes(args) randomly selects plots to be transformed into lakes, paying no attention whatever to what the previous condition of the plot was re Flatlands, Hills, or Mountains.
So when you use
you are using outdated information for the designated plot. This is why some of your lakes were converted to hills and others were not.
You need to access the actual plot object at the point your code executes and check whether the plot is a Mountain, has a feature (ie,, is a Volcano or Natural Wonder), or is adjacent to a Natural Wonder.
This should cure the issue
Code:
for x = 0, g_iW - 1 do
for y = 0, g_iH - 1 do
local i = y * g_iW + x;
pPlot = Map.GetPlotByIndex(i);
if pPlot:IsMountain() and (pPlot:IsNaturalWonder() == false) and (pPlot:GetFeatureType() ~= g_FEATURE_VOLCANO) and (AdjacentToNaturalWonder(pPlot) == false) then
TerrainBuilder.SetTerrainType(pPlot, ConvertMountainToHills(pPlot:GetTerrainType()));
end
end
end
The AdjacentToNaturalWonder() function is part of the built-in toolkit stuff in the RiversLakes.lua file that is "included" into the code of the Pangea.lua file at the top of the file:
Code:
include "MapEnums"
include "MapUtilities"
include "MountainsCliffs"
include "RiversLakes"
include "FeatureGenerator"
include "TerrainGenerator"
include "NaturalWonderGenerator"
include "ResourceGenerator"
include "CoastalLowlands"
include "AssignStartingPlots"
You want to avoid changing terrain that is adjacent to a Natural Wonder because doing so can cause the game engine to not properly render the Natural Wonder graphically.
You want to not alter a Volcano tile because while you can change the underlying base terrain (ie, it's a mountain) this does not allow removal of the fact that the plot is a Volcano and you get both odd graphical representation as well as the fact the game still thinks it is a Volcano plot.
Volcano and Lake plots especially seem not susceptible to alteration once they have been marked by the game engine as being lakes or Volcanos. So even though you can alter the tile, the game in most ways still "sees" the tile as being either a lake or a volcano if it ever was such a tile.
