What's wrong with this code?

[Androrc the Orc]

I made the following alteration in CityView.lua (changes in red):

		sortedList = {};
		thisId = 1;
		for building in GameInfo.Buildings() do
			local thisBuildingClass = GameInfo.BuildingClasses[building.BuildingClass];
[COLOR="Red"]			-- Androrc
--			if thisBuildingClass.MaxGlobalInstances <= 0 and thisBuildingClass.MaxPlayerInstances ~= 1 and thisBuildingClass.MaxTeamInstances <= 0 then
			if thisBuildingClass.MaxGlobalInstances <= 0 and thisBuildingClass.MaxPlayerInstances ~= 1 and thisBuildingClass.MaxTeamInstances <= 0 and not thisBuildingClass.Hidden then
			-- Androrc End
[/COLOR]				local buildingID= building.ID;
				if pCity:GetNumSpecialistsAllowedByBuilding(buildingID) <= 0 then
					if (pCity:IsHasBuilding(buildingID)) then
						numBuildingsInThisCity = numBuildingsInThisCity + 1;
						local element = {};
						local name = Locale.ConvertTextKey( building.Description )
						element.name = name;
						element.ID = building.ID;
						sortedList[thisId] = element;
						thisId = thisId + 1;
					end
				end
			end
		end

It is supposed to make it so buildings that belong to building classes that have the "Hidden" field set to true not appear in the city screen. However, this code is making it so ZERO non-specialist buildings appear in the city view screen. Does anybody have any idea of what might be wrong with it?

This is my SQL alteration that adds the "Hidden" field to building classes, by the way:

ALTER TABLE BuildingClasses ADD COLUMN 'Hidden' TEXT DEFAULT false;

Strangely enough, I wrote very similar code for the civilopedia screen (to exclude "Hidden" building classes' buildings from showing up in the civilopedia), and that worked perfectly.

 

[PawelS]

The Hidden column that you created is of text type, so when you use it as a condition it always returns true if there is some text in it, even if this text is saying 'false'

 

[Androrc the Orc]

The Hidden column that you created is of text type, so when you use it as a condition it always returns true if there is some text in it, even if this text is saying 'false'

Thanks, I changed it to this:

ALTER TABLE BuildingClasses ADD COLUMN 'Hidden' BOOLEAN DEFAULT false;

But unfortunately that didn't fix the issue

 

[PawelS]

A quote from this page: http://www.sqlite.org/datatype3.html

SQLite does not have a separate Boolean storage class. Instead, Boolean values are stored as integers 0 (false) and 1 (true).

It's an interesting thing that Civ5 XML files use the boolean data type, it seems it's converted to integer (0 or 1) when filling the database with data. So I think you should make it an integer value, and use 0 as false and 1 as true. I'm not sure how it will work in LUA conditions though, so it's possible that instead of

not thisBuildingClass.Hidden

you'll have to use

thisBuildingClass.Hidden == 0

 

[Androrc the Orc]

A quote from this page: http://www.sqlite.org/datatype3.html



It's an interesting thing that Civ5 XML files use the boolean data type, it seems it's converted to integer (0 or 1) when filling the database with data. So I think you should make it an integer value, and use 0 as false and 1 as true. I'm not sure how it will work in LUA conditions though, so it's possible that instead of

not thisBuildingClass.Hidden

you'll have to use

thisBuildingClass.Hidden == 0

That worked perfectly! Thank you so much

 

[bc1]

The reason for this is that the only things evaluated as in LUA are nil and false; all other are true.