[mod] Log changes

eotinb said:

Are there other events that could fire at the same time a civ is eliminated besides losing a city? I think onCityLost() is fired every time onCityRazed() is, so there shouldn't be a need to check in both of those functions, but there may be some other way a civ is eliminated that I'm forgetting. Maybe if they lost their first settler before it founded the first city, although I can't see that ever happening. Something else?

Click to expand...

1. If a civilization is not eliminated until their last settler is dead, it seems like you could catch that in the onUnitLost event handler. onCityLost and onUnitLost together ought to cover all the bases regardless of the rules.
2. There is an onSetPlayerAlive event handler. I imagine that gets called when a civilization is eliminated. If so, that pretty much solves the problem without having to worry about checking for the last city, the last settler, etc.

eotinb said:

Req, you will be happy to hear that I have completed the conversion to a proper inherited class structure. It was a bit tricky, but nothing I couldn't handle (he says before all the bug reports come streaming in). I'm still having trouble with recognizing when PrtScn is hit -- at first I thought the keyboard event is consumed wherever in the code the screenshot is stored, but then I realized that with my code in, the screenshots I took were different (specifially, they were tga format but still had the .jpg extension and didn't have any interface) and as soon as I commented out my code it worked as before. But I never got my placeholder code (just a simple message to the in-game screen to let me know it was working) to trigger. I'll work with it a bit more and if I make no more headway, release the new version without it later today.

I'm also looking for some help on implementing vbraun's request on noting when a civ is destroyed, in particular:

• It would be much easier if I could make this event-based. This means I need to figure out all of the events that could be triggered at the same time that a civ is eliminated (since there is no specific onCivEliminated() or similar event). From what I have read, a civ is eliminated when they lose their last city, regardless of if they have any units left (I think that's one of the hints that shows when the game is loading). This would mean that a civ with a settler out and about that loses its last city is gone even though it could found a new city with the settler. So I guess I have two questions:
  1. Can anyone confirm that what I have just described (regarding settlers) is true?
  2. Are there other events that could fire at the same time a civ is eliminated besides losing a city? I think onCityLost() is fired every time onCityRazed() is, so there shouldn't be a need to check in both of those functions, but there may be some other way a civ is eliminated that I'm forgetting. Maybe if they lost their first settler before it founded the first city, although I can't see that ever happening. Something else?
• Should the log only note when a civ you know is destroyed? If not, should you be told the name of the dead civ if you haven't met them? In other words, as I see it there are three options when a civ you don't know is destroyed (you are always told who died when the eliminated civ is one you know):
  • You don't hear about it
  • You get a message like "An unknown civ has been destroyed"
  • You get a message like "The Aztecs have been destroyed"

Click to expand...

Tubby Rower said:

Clicking the OK button works for me. For a while I just hit enter and nothing but Debug Event popped up. After I found out that enter <> clicking OK then I changed the way I enter messages. Just a habit of hitting <enter>.

Click to expand...

	def __eventCustomLogEntryApply(self, playerID, userData, popupReturn):
		[B]if (popupReturn.getButtonClicked() == 0):[/B]
			CyInterface().addMessage(CyGame().getActivePlayer(), True, 10, message, None, 2, None, ColorTypes(8), 0, 0, False, False)
			self.log.write(2, message)

		[B]if (popupReturn.getButtonClicked() != 1):[/B]

eotinb said:

Should be possible. Let me look into it. No promises that this will make it into the upcoming revision, though. Good catch, by the way. This is a pretty big missing feature since you mention it.

Click to expand...