Database order from several mods?

<Actions>
<OnModActivated>
<UpdateDatabase>XML/ProMod.xml</UpdateDatabase>
</OnModActivated>
</Actions>

Click to expand...

LeeS said:

Are you sure you have your dependancy set up correctly in the 'iconmod' ?

I've never found the dependancy system to not work correctly. Nor the mod 'reference' system either. But without link (or attachment) to the mods themselves it will be oujia-boarding to hit the correct answer for where your problem lies.

Click to expand...

Nutty said:

I don't have time at the moment to look at your pack, so I'm not sure this is the issue, but note that the dependencies and references only affect database load order, not the order of VFS "overwrites" (i.e., where a mod replaces a file from the base game or another mod). There is apparently no way to guarantee that order (though you might try to ensure the file date of the "winner" is the newest; that seems to help for DLC mods, anyway). Otherwise, you can just delete the conflicting file. In any event, another method can often be used to get the same result without replacing files (though it's sometimes quite a bit more effort).

Click to expand...

Serp said:

thanks

Yes the problem is, that the iconmod "updates" a non existing promotion -> nothing.
And then the new promotion is added.
But it should be the other way round.

Luckily I saved my cache while it was working, so now I was able to compile my modpack.

The date of which file is the one to look at? The modinfo file? Or the xml/sql that updates/adds something?

Click to expand...

Nutty said:

If it's a pure database update (OnModActivated) and not a VFS update, then the date shouldn't matter, assuming you have properly set the Dependencies or References in the Associations tab of the mod's properties. Another option, rather than Associations, is to use SQL triggers, which has the benefit of potentially working with any mod, known, unknown, or made in the future.

Click to expand...

Serp said:

Next time I will try to teach myself about sql triggers

Click to expand...

whoward69 said:

See http://forums.civfanatics.com/showthread.php?t=521961

Click to expand...

CREATE TRIGGER TerrainIconsFlagPromo1
AFTER INSERT ON UnitPromotions  
WHEN 'PROMOTION_CAN_CROSS_MOUNTAINS'=NEW.Type
BEGIN
  UPDATE UnitPromotions
    SET PortraitIndex = 2, IconAtlas = 'NEW_ICON_ATLAS'
    WHERE Type = 'PROMOTION_CAN_CROSS_MOUNTAINS';   
END;

CREATE TRIGGER TerrainIconsFlagPromo2
AFTER INSERT ON UnitPromotions  
WHEN 'PROMOTION_CAN_CROSS_MOUNTAINS_SCOUT'=NEW.Type
BEGIN
  UPDATE UnitPromotions
    SET PortraitIndex = 2, IconAtlas = 'NEW_ICON_ATLAS'
    WHERE Type = 'PROMOTION_CAN_CROSS_MOUNTAINS_SCOUT';    
END;

CREATE TRIGGER TerrainIconsFlagPromo3
AFTER INSERT ON UnitPromotions  
WHEN 'PROMOTION_CAN_CROSS_ICE'=NEW.Type
BEGIN
  UPDATE UnitPromotions
    SET PortraitIndex = 2, IconAtlas = 'NEW_PROMOTION_ATLAS'
    WHERE Type = 'PROMOTION_CAN_CROSS_ICE';  
END;

CREATE TRIGGER TerrainIconsFlagPromo4
AFTER INSERT ON UnitPromotions  
WHEN 'PROMOTION_ICEBREAKER'=NEW.Type
BEGIN
  UPDATE UnitPromotions
    SET PortraitIndex = 2, IconAtlas = 'NEW_PROMOTION_ATLAS'
    WHERE Type = 'PROMOTION_ICEBREAKER';    
END;

Nutty said:

FYI, SQL triggers won't catch changes that have occurred prior to the trigger (as you've seen, we don't know beforehand the order they're applied), so you'll want to run your updates inside the triggers ALSO outside (and prior to) the triggers.

And XML <Row> is translated to a SQL INSERT, yes.

Click to expand...

UPDATE UnitPromotions
SET PortraitIndex = 2, IconAtlas = 'NEW_ICON_ATLAS'
WHERE Type = 'PROMOTION_CAN_CROSS_MOUNTAINS';   

UPDATE UnitPromotions
SET PortraitIndex = 2, IconAtlas = 'NEW_ICON_ATLAS'
WHERE Type = 'PROMOTION_CAN_CROSS_MOUNTAINS_SCOUT';   

UPDATE UnitPromotions
SET PortraitIndex = 2, IconAtlas = 'NEW_PROMOTION_ATLAS'
WHERE Type = 'PROMOTION_CAN_CROSS_ICE';  

UPDATE UnitPromotions
SET PortraitIndex = 2, IconAtlas = 'NEW_PROMOTION_ATLAS'
WHERE Type = 'PROMOTION_ICEBREAKER';

whoward69 said:

You really should not need anything other than a correct dependency in one of the mods

Is this for two mods for use in single player, or for two mods which you then merge into a multi-player mod pack?

If the former, just attach the two mods as snippets of SQL out of context are difficult to debug.

If the latter, are you sure the merging tool a) understands dependancies and b) copes with SQL. And if the latter, why not just merge the two mods manually and then include the combined mod via the MP mod-pack making tool?

Click to expand...

[87819.031] \Users\Serp\Documents\My Games\Sid Meier's Civilization 5\MODS\Promotions - Level Promotions (v 3)\Promotions - Level Promotions: Promotions - Level Promotions Active

LeeS said:

If the lua-file is at the root level of the mod instead of within a sub-folder of the mod, the lua log will do this.

I get this sort of full file-path-string all the time with a tester-mod I use where all the files are at the root level of the mod because I was too lazy to make any sub-folders within the mod.

Click to expand...

whoward69 said:

Check database.log - you have SQL errors. One is benign, the final update to the LoadedFile table, the other is fatal - you're missing the ; after the END of the triggers, so the triggers are not being created. Add four missing semi-colons and the SQL executes and the promotions get the new icons (only checked by looking in the database with SQLiteSpy)

The other interesting thing is that Firaxis appear to have written the database execution mod dependency code as "any of these mods" and not "all of these mods".

This is causing the Flag Promotion mod to load after either of the Terrain Crossing or Level Promotions mod has loaded and not (as you'd reasonably expect) both of them to have loaded. You can fix this for these 4 mods by making Flag Promo depend on Terrain Crossing depend on Level Promo depend on DLL VMC, but for many mods it's going to be a right PITA to get the required order, so TRIGGERS (with the final semi-colon) will definitely be required.

Click to expand...