Celtic UHVs

alright, so I ran the code for the UHVs past Rhye and he said they looked good...but only one of them (the one with the buildings) seems to work. The three cities and never losing a city don't register as succeeded when I achieve them.

If the almighty Rhye has given you his blessing, than I am sure you will find a way to make the UHV conditions work.

I'm thinking they must interact with some other piece of code that must be looking for something they are not providing. Other than cut-and-paste and change the obvious names and dates, I know of no other way to modify them as I'm so new to coding. I know some people in the forum have successfully designed new UHVs for things, so maybe it's something obvious or dumb that I'm missing...

There are several errors in the code you posted originally, but I take it you are using different code now as you have changed UHVs somewhat. If you post the updated code someone may be able to spot what the problem is.

here is the latest form. (victory.py saved as a txt)

I took a quick look and believe that this is your first culprit:
The first instance should be the tile making up the lower left corner of the rectangle, and the second one should be the upper right corner. I know that it makes no sense with the TL and BR, but this is how it works nonetheless. Since I'm not looking at the map at the moment I can't look what tiles they should be, but I can see (in Consts.py) that the tiles defining the English spawn area are (50, 53) and (54, 60) respectively. So the British Isles should probably be something like (48, 53) and (54, 60) if you include Ireland.

Also, I believe that you've managed to mix victory conditions by simply copy-pasting stuff. The victory conditions are in fact numbered (from 0 to 2) and you seem to have two victory conditions that are #0 (zero). Figure out how they are numbered and change them. (Hint: Its the first number after "iCeltia".)

If you can't make it work by yourself I would probably be able to sort things out for you. Would you like to have other victory conditions altogether, maybe something more unique than simply copying those of other Civs? Given the spare time I might be able to help you, just to challenge my newly acquired Python-fu.

By all means, I'm happy for the tinkering help!

...I suppose if I had my wishlist they would be colonizing the British Isles (maybe four cities is better), lose no cities to the Romans or English, and capture/control/raze Rome by 410 AD (but I don't want to force the Celtic player to raze it).

I have slightly altered the britsh isles so as to better accomodate celtic/english competition for it...scotland goes one tile north from where it used to now, ireland's been "squared off" in its lower right hand corner, and some changes were made in the bristol/cornwall/wales area, but really only the scotland change will affect coordinates...

antaine said:

By all means, I'm happy for the tinkering help!

Click to expand...

Just let me know when you give up trying to get it to work. I think its mighty impressive that you've managed to come this far by copy-pasting. And compiling the dll to boot!

antaine said:

...I suppose if I had my wishlist they would be colonizing the British Isles (maybe four cities is better), lose no cities to the Romans or English, and capture/control/raze Rome by 410 AD (but I don't want to force the Celtic player to raze it).

Click to expand...

And what are the goals as of now? Would you keep any as is?

antaine said:

I have slightly altered the britsh isles so as to better accomodate celtic/english competition for it...scotland goes one tile north from where it used to now, ireland's been "squared off" in its lower right hand corner, and some changes were made in the bristol/cornwall/wales area, but really only the scotland change will affect coordinates...

Click to expand...

Ah, your coordinates are nonsensical anyways, since you've plotted the wrong tiles. So, what tile is the south west corner, and what tile is the north east corner?

If you have altered the map you should probably also change the Settler/Stability map and City name map - for the English. And perhaps also for the Vikings and the Germans? (I've yet to tinker with those myself.)

well, the colonizing the british isles will stay the same, except with proper coordinates and four cities instead of three.

I've already changed the maps.

hm....but now that I'm thinking...I think I mucked up the other things that called for coordinates the same way as tBritishIsles, so I'll probably have to redo all of them as well.

tBritishIsles
sw = 47,52
ne = 55,61

antaine said:

well, the colonizing the british isles will stay the same, except with proper coordinates and four cities instead of three.

I've already changed the maps.

hm....but now that I'm thinking...I think I mucked up the other things that called for coordinates the same way as tBritishIsles, so I'll probably have to redo all of them as well.

tBritishIsles
sw = 47,52
ne = 55,61

Click to expand...

Oh, i just saw this post now. I believe I got one of the coordinates wrong in my suggestion for a fix (in the other thread). Marked with red.