Advertisement
Civilization Fanatics' Center  

Go Back   Civilization Fanatics' Forums > CIVILIZATION IV > Civ4 - Creation & Customization > Civ4 - Mod Components

Reply
 
Thread Tools
Old Mar 03, 2010, 11:18 PM   #21
PieceOfMind
Drill IV Defender
 
PieceOfMind's Avatar
 
Join Date: Jan 2006
Location: Australia
Posts: 9,290
Quote:
I guess this answers the firaxis programmer's comment about whether to take this out!


Thanks jdog, that was quick! I'm glad it wasn't something I did, because I was wracking my brain trying to work out how my change could cause the observed behaviour.

EDIT

A question for LunarMongoose.

Could you perhaps let me know how you fixed it? As I said before, for me this was tinkering in unfamiliar territory so I have no idea how frequently the function is called and so whether I need to try and cut down on (possibly?) expensive functions and repeated calculations.

Besides, your fix might be more elegant and i wouldn't have to have it commented so weirdly as a fix by me for PIG Mod but from mongoosesdk.

By the way, I also don't like how I reassigned iMinAreaSize but I wondered whether it was necessary to create a new variable or not? (or whether I should)
__________________
Tip: Forcing Steam's Offline Mode
Civ4 Mods: Advanced Combat Odds, PIG Mod(discontinued), HEX Mod(discontinued)
Suggestion: Try karadoc's K-Mod: Far Beyond the Sword
Read if bored: Zoom-To-Cursor, Good advice from Kaell for DX11 users, Nvidia beats AMD in Civ V

Last edited by PieceOfMind; Mar 03, 2010 at 11:25 PM.
PieceOfMind is offline   Reply With Quote
Old Mar 04, 2010, 12:35 AM   #22
LunarMongoose
King
 
LunarMongoose's Avatar
 
Join Date: Jan 2006
Location: Boston, MA, USA
Posts: 642
Quote:
Originally Posted by PieceOfMind View Post
Could you perhaps let me know how you fixed it? As I said before, for me this was tinkering in unfamiliar territory so I have no idea how frequently the function is called and so whether I need to try and cut down on (possibly?) expensive functions and repeated calculations.

Besides, your fix might be more elegant and i wouldn't have to have it commented so weirdly as a fix by me for PIG Mod but from mongoosesdk.

By the way, I also don't like how I reassigned iMinAreaSize but I wondered whether it was necessary to create a new variable or not? (or whether I should)
I used your code as-was. I don't know how frequently isCoastalLand() is called either, but it doesn't matter; that's where the change has to go, and your change is what it has to be to work right. Nothing about the GC calls is particularly expensive, and there's not a lot of math, so I'm not very worried about it. It's something that could conceivably be added to the CAR cache system, but that would break the save files of the test game I'm currently playing so I don't want to bother.

The double comment was more-or-less fine it just didn't match my format exactly. And the argument reassignment will work in all cases where it's not a pointer that's being passed. Normally structs and custom types like vectors are not passed directly, though they can be, so usually you can look at whether it's a primitive like int to see if it'll work, but regardless it's not a particularly good practice stylistically, no.

Also... I found the problem with my Sandworm code. Woot.
LunarMongoose is offline   Reply With Quote
Old Apr 10, 2012, 05:01 AM   #23
migck
Cacique
 
Join Date: Apr 2009
Posts: 75
Sorry to bump this after more than two years, but I am baffled at the usefulness of these changes and wanted to thank you for them.

I was wondering, is it still OK to pull code from here for other projects, or is it better to use the code from your MongooseMod?
migck is offline   Reply With Quote
Old Apr 10, 2012, 05:10 AM   #24
keldath
LivE LonG AnD PrOsPeR
 
keldath's Avatar
 
Join Date: Dec 2005
Location: israel
Posts: 5,490
migck ,

hi, i wish mongoose would update the sdk for release - he created version 4 for his great mod, but he wont release the sdk unfortunatly

gluck friend.
__________________
keldath is online now   Reply With Quote
Old Jul 12, 2012, 01:48 AM   #25
Cruel
King
 
Cruel's Avatar
 
Join Date: Jun 2005
Location: São Paulo, Brazil
Posts: 820
Download not working...
__________________
A Big Fan and Team´s Member of Realism: Invictus

[ SVN | Download | CFC Forum | Manual ]

Do you like RI and want to help? Talk to a member of our team!
Cruel is offline   Reply With Quote
Reply

Bookmarks

Go Back Civilization Fanatics' Forums > CIVILIZATION IV > Civ4 - Creation & Customization > Civ4 - Mod Components > [MODCOMP] MongooseSDK

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off



Advertisement

All times are GMT -6. The time now is 09:59 AM.


Powered by vBulletin®
Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
This site is copyright © Civilization Fanatics' Center.
Support CFC: Amazon.com | Amazon UK | Amazon DE | Amazon CA | Amazon FR