Please Help Me with my own civilization(Noob)

Samsamqwq · Apr 1, 2016

So I created my own test civilization after this tutorial: http://forums.civfanatics.com/showthread.php?t=490901

After loading the mod I couldn't scroll in the civilization mod menu. I looked it up and I found that it means there is something wrong with the civ.
So I installed a mod called really advanced setup to play my civilization by force.
Both my unique palace and my unique renamed copy paste unit from the Kris Swordsman seem to work fine

. But when I load the civilization the loading screen is broken(view screenies). I couldn't find anything wrong in my log. But here it is anyway:

Spoiler :

whoward69 · Apr 1, 2016

If the setup screen is broken, you're civ is missing (at least) two uniques.

Nothing in the logs implies you've omitted (at least one) OnModActivated->UpdateDatabase entry ...

Edit: ... all of which are there ... ummmm ....

Samsamqwq · Apr 1, 2016

thanks for the quick reply. Maybe the palace doesn't count as UB? Because in game it has the changes I made, the same goes for the unit.

Klisz · Apr 1, 2016

Your leader's trait is set to TRAIT_CREATIVE, but the trait you created is TRAIT_CREATIVE_BALLS_BALLS. There is an unused TRAIT_CREATIVE in the game, but it lacks a Description or ShortDescription - perhaps that's causing problems.

Samsamqwq · Apr 1, 2016

Ah I see that may be it. The err... rather creative name of my leaders trait is because I was annoyed that the trait creative seemed to be already taken by another civ. So I tried something else. I'll try correcting it right now. Thanks.

EDIT: HURRAY! It worked thanks. I would have never thought of this myself. Or maybe I would have but It would have taken a lot longer. Thank both of you again!

whoward69 · Apr 1, 2016

Klisz said:
but it lacks a Description or ShortDescription - perhaps that's causing problems.

Beat me to it. Lua.log is complaining about a missing description for the trait. One to add to the list of "many ways to kill the setup screen" :lol:

Samsamqwq · Apr 2, 2016

So if anyone ist still here that can help me, i have a new tasty and fresh problem.
I added a Lua script, in which I tried to add a random chance wether a monument or a wall should be placed in the city when it is founded. Yeah I know great idea as a noob.
The Lua log says that...

Spoiler :

...I tried to index PlayerSheo but it's a nil value. But I thought I defined PlayerSheo with PlayerSheo = Players[iPlayer] or did I misunderstand something?
Here's the script:

Spoiler :

Also would it even work with all the errors corrected? Or is there an easier way to achieve what I want?

whoward69 · Apr 2, 2016

Samsamqwq said:
or did I misunderstand something?

The signature for the SerialEventCityCreated event is

Code:

Events.SerialEventCityCreated.Add(function (hexPos, playerID, cityID, cultureType, eraType, continent, populationSize, size, fowState)
  ... 
end)

Rule 1 of programming - understand what you're dealing with

BTW - for stuff like this, the best reference source are the game core UI files

LeeS · Apr 2, 2016

Also, I don't see how this will ever be "true":

Code:

if (pCity:GetNumRealBuilding(cheese) < 0) and (pCity:GetNumRealBuilding(intestines) < 0) then

since a city will not have less than '0' copies of a building.

I suppose in some wierd concatenation of code-methods where some other mod places '-1' copies of a building within a city, it could happen, but I'm not even sure negative values in "iNumBuildings" for City:SetNumRealBuilding(iBuildingType, iNumBuildings) even works or not.

--------------------------------------------------------------------------------------------------

Which leads directly into the next issue, which is that this:

Code:

pCity:SetNumRealBuilding(intestines + 1)

is missing the required parameter for "iNumBuildings", which is just an example placeholder variable and needs to be an integer value telling the API how many copies of "iBuildingType" to place within the given city.

--------------------------------------------------------------------------------------------------

Which leads to the next issue: you are using variable "pCity" before it is even defined, so "pCity" will have a value of 'nil', and you will get an error for that once you get past the error for "PlayerSheo" having a nil value.

Samsamqwq · Apr 2, 2016

But shouldn't it work when I make it: PlayerSheo = Players[playerID]? Also thanks for the help everyone! Yeah and the thingy (pCity:GetNumRealBuilding(cheese) < 0) and (pCity:GetNumRealBuilding(intestines) < 0) replacing it with an == should work right?

LeeS · Apr 2, 2016

Samsamqwq said:
But shouldn't it work when I make it: PlayerSheo = Players[playerID]? Also thanks for the help everyone! Yeah and the thingy (pCity:GetNumRealBuilding(cheese) < 0) and (pCity:GetNumRealBuilding(intestines) < 0) replacing it with an == should work right?

With regard to "playerID":
- Not if you don't change to:
  Code:
```
Events.SerialEventCityCreated.Add(function(hexPos, playerID, cityID, cultureType, eraType, continent, populationSize, size, fowState)
```
  because if you leave it as:
  Code:
```
Events.SerialEventCityCreated.Add(function(playerID )
```
  then you won't be fixing anything -- all you will be doing is shifting the problem from using variable "iPlayer" to variable "playerID".
- The data that gets sent to a 'hook' event is based on position, so the data the game sends for "hexPos" will always be sent to the 1st variable in your list. In your original code, "iPlayer" was in the position for "hexPos" so you were trying to use the data for a HexPos as the player ID#. I can call the variables anything I want, but I must use the variables properly based on where I position them in my function() line.
- I can do this:
  Code:
```
Events.SerialEventCityCreated.Add(function(Hamburgers, Cheeseburgers, PizzaType, Pickles, Mustard, Mayonaisse, Ketchup, Whoppers, SesameSeeds)
```
  and so long as I follow through and do:
  Code:
```
local pPlayer = Players[Cheeseburgers]
```
  everything will be fine because I am using the data from the second parameter (the player ID#) in the proper way. But it will very quickly get very confusing to read such a code, which is why we tend to always use either "iPlayer" or "PlayerID" for a parameter which we expect to pass to us the Player ID # of the affected player.
With regard to "==" instead of "<": yes, this should fix that issue

Samsamqwq · Apr 2, 2016

Ahh now I get it. Thank you! I was already wondering why the would have two different "keywords" or something for the exact same purpose. Yes, YES, YEEES IT WORKS! Here's the script if interested:

Spoiler :

LeeS · Apr 2, 2016

And before you will get your code to work you will need to fix the issue of "pCity" never being defined.

Look here: Player.GetCityByID

At the bottom there are some practical examples as used by firaxis to get a "pCity" type of data for a city, even though they don't always name their variable specifically "pCity". Also, that bottom section tells you the file where Firaxis is using the quoted code.

You already have the "City ID#", given as part of the data sent to your function.

Samsamqwq · Apr 4, 2016

Sooo, is there any way that I can make another civ declare war on every civ else? My idea is to make a replacement for a great musician, who can select a feature or something like that, that affects the targeted civ when he is expended via a concert tour. I don't know it that is even remoteley possible though.

Please Help Me with my own civilization(Noob)

Samsamqwq

Chieftain

Attachments

whoward69

DLL Minion

Samsamqwq

Chieftain

Klisz

King

Samsamqwq

Chieftain

whoward69

DLL Minion

Samsamqwq

Chieftain

Attachments

whoward69

DLL Minion

LeeS

Imperator

Samsamqwq

Chieftain

LeeS

Imperator

Samsamqwq

Chieftain

LeeS

Imperator

Samsamqwq

Chieftain

Similar threads