Editing an existing civ

• Longbowmen
• Ship of the Line
• Siam's City State bonus(upped to 100%)

1. We want a link to the mod itself as it is in the Game's MODS folder, not the Modbuddy Project Folder as you've linked to. See whoward69's zip your mods and attach tutorial.
2. Your mistake is that you are not using the files from William's thread as templates to be adjusted when creating a new civilization but rather you are essentially direct-copying them with a few changes to settings here and there. This will not work because
   • You are attempting to redefine CIVILIZATION_OTTOMAN, LEADER_SULEIMAN, TRAIT_CITY_STATE_BONUSES, etc. This fails because the game already has definitions of these, and so rejects the entire contents of all your files.
   • You are not attempting to use <Updates> to change the existing civilization, leader, etc., you are attempting to re-state the defintiion of pre-existing information using <Row> structure. (see 'a' directly above)
   • Changing LEADER_SULEIMAN to use TRAIT_CITY_STATE_BONUSES would be all fine and good, but you are then attempting to change the definition of TRAIT_CITY_STATE_BONUSES. This will result in the changes made being applied to both LEADER_RAMKHAMHAENG and LEADER_SULEIMAN because both would then be using TRAIT_CITY_STATE_BONUSES. You would be better off just making changes via <Update> structure to TRAIT_CONVERTS_SEA_BARBARIANS.
3. To add the Ship of the Line and the Longbowmen to the Ottomans, all that is needed is
   Code:

   <GameData>
   	<Civilization_UnitClassOverrides>
   		<Row>
   			<CivilizationType>CIVILIZATION_OTTOMAN</CivilizationType>
   			<UnitClassType>UNITCLASS_CROSSBOWMAN</UnitClassType>
   			<UnitType>UNIT_ENGLISH_LONGBOWMAN</UnitType>
   		</Row>
   		<Row>
   			<CivilizationType>CIVILIZATION_OTTOMAN</CivilizationType>
   			<UnitClassType>UNITCLASS_FRIGATE</UnitClassType>
   			<UnitType>UNIT_ENGLISH_SHIPOFTHELINE</UnitType>
   		</Row>
   	</Civilization_UnitClassOverrides>
   </GameData>

   <Row> rather than <Update> structure works for these two changes to the base-game data because CIVILIZATION_OTTOMAN does not already have any unique units from within the Crossbowman or Frigate Unit-Classes. If they did, then <Update> structure would have been required to apply the change(s) to that pre-existing data.
4. To apply the city-state thing of LEADER_RAMKHAMHAENG to LEADER_SULEIMAN what is wanted is to apply the effects of TRAIT_CITY_STATE_BONUSES to TRAIT_CONVERTS_SEA_BARBARIANS.
   Code:

   <GameData>
   	<Traits>
   		<Update>
   			<Where Type="TRAIT_CONVERTS_SEA_BARBARIANS"/>
   			<Set>
   				<CityStateBonusModifier>100</CityStateBonusModifier>
   			</Set>
   		</Update>
   	</Traits>
   </GameData>

   Note this will not affect the in-game text related to Sulieman's Trait.
5. Nothing else is really required when altering the existing Ottoman Civilization to make it have the additional effects mentioned in the OP

1. This part fails because of multiple problems:
   
   Code:

   <GameData>
   	<Traits>
   		<Update>
   			<Where Type="TRAIT_CONVERTS_SEA_BARBARIANS"/>
   			<Set>
   				<CityStateBonusModifier>100</CityStateBonusModifier>
   			</Set>
   			[color="red"]<Where Text="TXT_KEY_TRAIT_CONVERTS_SEA_BARBARIANS"/>
   			<Set>
   				<Text>City states befriend you out of fear! Increased [Icon Gold, [Icon Culture] and [Icon Food] gain by 100% and pay only half of your naval maintenance upkeep.</Text>
   			</Set>[/color]
   		</Update>
   	</Traits>
   </GameData>

   • You can't have more than one "Where" or "Set" clause within one <Update>. The part Highlighted in red fails because of this.
   • There is no column called "Text" within game-table "Traits". The part highlighted in red will also fail because of this, even if it had not already failed because of the previous syntax error.
2. You want the <Update> to the language tag to occur under table <Language_en_US>:
   Code:

   <GameData>
   	<Traits>
   		<Update>
   			<Where Type="TRAIT_CONVERTS_SEA_BARBARIANS"/>
   			<Set>
   				<CityStateBonusModifier>100</CityStateBonusModifier>
   			</Set>
   		</Update>
   	</Traits>
   	<Language_en_US>
   		<Update>
   			<Where [color="red"]Text[/color]="TXT_KEY_TRAIT_CONVERTS_SEA_BARBARIANS"/>
   			<Set>
   				<Text>City states befriend you out of fear! Increased [color="red"][Icon Gold, [Icon Culture] and [Icon Food][/color] gain by 100% and pay only half of your naval maintenance upkeep.</Text>
   			</Set>
   		</Update>
   	</Language_en_US>
   </GameData>

   However there are still two problems, highlighted again in red.
   • Nowhere within table <Language_en_US> are you going to find any row where the "Text" is equal to "TXT_KEY_TRAIT_CONVERTS_SEA_BARBARIANS". You need to be looking for 'Tag' being equal to that TXT_KEY string.
   • Your designations for inserting Icon Symbols into your text string are incorrect and won't show the Gold, Culture, or Food icons in-game: all that will show is the actual text as you have incorrectly entered it.
3. The correct syntax for what you want to do is:
   Code:

   <GameData>
   	<Traits>
   		<Update>
   			<Where Type="TRAIT_CONVERTS_SEA_BARBARIANS"/>
   			<Set>
   				<CityStateBonusModifier>100</CityStateBonusModifier>
   			</Set>
   		</Update>
   	</Traits>
   	<Language_en_US>
   		<Update>
   			<Where Tag="TXT_KEY_TRAIT_CONVERTS_SEA_BARBARIANS"/>
   			<Set>
   				<Text>City states befriend you out of fear! Increased [ICON_GOLD] Gold, [ICON_CULTURE] Culture and [ICON_FOOD] Food gain by 100% and pay only half of your naval maintenance upkeep.</Text>
   			</Set>
   		</Update>
   	</Language_en_US>
   </GameData>

4. The complete code thus becomes:
   Spoiler :

   Code:

   <GameData>
   	<Civilization_UnitClassOverrides>
   		<Row>
   			<CivilizationType>CIVILIZATION_OTTOMAN</CivilizationType>
   			<UnitClassType>UNITCLASS_CROSSBOWMAN</UnitClassType>
   			<UnitType>UNIT_ENGLISH_LONGBOWMAN</UnitType>
   		</Row>
   		<Row>
   			<CivilizationType>CIVILIZATION_OTTOMAN</CivilizationType>
   			<UnitClassType>UNITCLASS_FRIGATE</UnitClassType>
   			<UnitType>UNIT_ENGLISH_SHIPOFTHELINE</UnitType>
   		</Row>
   	</Civilization_UnitClassOverrides>
   	<Traits>
   		<Update>
   			<Where Type="TRAIT_CONVERTS_SEA_BARBARIANS"/>
   			<Set>
   				<CityStateBonusModifier>100</CityStateBonusModifier>
   			</Set>
   		</Update>
   	</Traits>
   	<Language_en_US>
   		<Update>
   			<Where Tag="TXT_KEY_TRAIT_CONVERTS_SEA_BARBARIANS"/>
   			<Set>
   				<Text>City states befriend you out of fear! Increased [ICON_GOLD] Gold, [ICON_CULTURE] Culture and [ICON_FOOD] Food gain by 100% and pay only half of your naval maintenance upkeep.</Text>
   			</Set>
   		</Update>
   	</Language_en_US>
   	<Civilization_BuildingClassOverrides>
   		<Row>
   			<CivilizationType>CIVILIZATION_OTTOMAN</CivilizationType>
   			<BuildingClassType>BUILDINGCLASS_MARKET</BuildingClassType>
   			<BuildingType>BUILDING_BAZAAR</BuildingType>
   		</Row>
   	</Civilization_BuildingClassOverrides>
   </GameData>

AgressiveWimp said:

EDIT: Haha! I have managed to evade ninjation by LeeS

Click to expand...