[FIXED] Happiness calculation wrong - garrisoned units not included

Seems the breakdown of your empire's happiness is not always correct. The attached screenshot shows Happiness at zero, but the detail breakdown show Total Happiness as 127, with Unhappiness as 138.

If you manually add up the happiness bonuses they come to 138, so the total of zero is right, it's just the break down that's wrong.

1.0.0.20 (the second one), Win7x64, no mods, save attached

If you change things around, does the discrepancy remain the same as the happiness from garrisoned units?

It certainly does, I hadn't noticed that!

The bug is in...\Assets\UI\InGame\TopPanel.lua @ line 534: iGarrisonedUnitsHappiness is not being included in the total happiness calculation.

cheers
ak

That you can see the bug in the source code is for me confirmation enough.
Moderator Action: Moved.

while the total happiness is correct on the top toolbar, when you hover over the happy face and get the drop down showing details, happiness created by garrisoned units shows in the listing, but is not in the total happiness count.

example:

i have 4 excess happiness showing on the overview at top.

when i open the detail drop down it will show 30 total happiness from the 6 luxuries i have but not count the 4 garrisoned units for a true total of 34 happiness, even though they are listed and count towards the true total.

and 30 total unhappiness

Agree. Overall happiness is correctly calculated, it's just the display which is wrong.

Moderator Action: Threads merged. The_J