Is there someway to use python to give random promotions?
I was going to use Occasional Promotions but it's DLL.
It needs to be python...
I was going to use Occasional Promotions but it's DLL.
It needs to be python...
Random Promotions?
- Thread starter topsecret
- Start date
What exactly do you need? What should prompt these random promotions? Is there some set promotions that are valid or would that be situational? (Depending on unit type, prerequisites, et cetera.)
Because promotions can be granted with Python. Randomness is no obstacle, but the code can be more or less complex.
And do you know how to program in Python or do you need a ready-to-use fix?
Because promotions can be granted with Python. Randomness is no obstacle, but the code can be more or less complex.
And do you know how to program in Python or do you need a ready-to-use fix?
Something that gives you a random promotion after a battle
Situational, Depending on unit type and prerequisites.
No, I can't program in python, so I need a ready-to-use fix.
What's it for? I might be able to help. Yes, it might be possible to give a unit a random promotion from a list when it gets out of combat. My mind's working at it already. I needed a Python idea anyway. So give me the specifics and I might be able to help. Is this a trait or what? Should it be any promotion, or just certain promotions? Should this be for all units, or just some?
You really should consider learning Python, it's really easy if you read a good book first, like Head First Programming.
You really should consider learning Python, it's really easy if you read a good book first, like Head First Programming.
smeagolheart
Monarch
Yeah TS, there are a lot of variables you need to spell out. Basically whatever you want is possible but you have to be specific.
If you want to add a promotion to someone after they win a battle, well there is a place for that in the cveventmanager. Then you'll have to decide what percentage chance to win what promotions for which units. I think you'll need to specify exactly which promotions for exactly which units because there are so many and some that require a great general or only certain unitcombats (ie siege weapons get different promotion list than a warrior).
This is what I did in this context with PyScenario:
While this is not a ready-to-copy-paste solution for your specific needs, its still a working script for my PyScenario application. (It sets promotions for spawned units. Some are set randomly while others are set in priority order depending on the prerequisites. The whole thing is designed to create slightly different outcomes from game to game, mimicking some sort of "artificial intelligence".)
So its doable. The promotions themselves are defined in this data structure:
This of course doesn't make much sense at a glance, but the data is basically parsed by the script and the various settings are then used to determine what promotions should be granted. The whole thing could of course be totally random, but then there wouldn't be any "intelligence" behind it.
Spoiler :
So its doable. The promotions themselves are defined in this data structure:
Spoiler :
It's traits for units, so certain units and certain promotions.
Sorry for keeping you waiting, but I go to church on Sunday (more important than Civ).
Sorry for keeping you waiting, but I go to church on Sunday (more important than Civ).
.Yeah, like spit out the entire spreadsheet with units and their available promotions.
Or should everything just "make sense" with regard to how the original game is designed? Basically lookup all available promotions, check which ones are valid for the unit in question at a given point in the game, add those to a list and choose one of those at random?
edit: I looked into it and the main challenge is of curse to make any such code as efficient as possible. A good start might be to map all available promotions to some UnitCombatTypes value, and also weed out special cases like leader promotions. This should be possible to do with CvPromotionInfo.getUnitCombat() and CvPromotionsInfo.isLeader(). Something like this:
If this is valid (I haven't tested any of it myself) its only a matter of knowing where to put the code. 
Or should everything just "make sense" with regard to how the original game is designed? Basically lookup all available promotions, check which ones are valid for the unit in question at a given point in the game, add those to a list and choose one of those at random?
edit: I looked into it and the main challenge is of curse to make any such code as efficient as possible. A good start might be to map all available promotions to some UnitCombatTypes value, and also weed out special cases like leader promotions. This should be possible to do with CvPromotionInfo.getUnitCombat() and CvPromotionsInfo.isLeader(). Something like this:
Spoiler :
God-Emperor
Deity
That would seem like a good option.
You could even check the list of currently valid promotions to separate out those that are specifically appropriate for the fight, like Cover if the enemy was an archer or Shock if the enemy was melee, or what terrain the fight happened on to get woodsman or guerrilla (perhaps limiting it to promotions that give an offensive bonus for the terrain the defended was in if you won while attacking, and for defensive terrain bonuses for the terrain you were in if you won as defender). You could then pick a situational promotion if there is one or more, otherwise going with a purely random promotion.
There are many possible levels of complexity...
You could even check the list of currently valid promotions to separate out those that are specifically appropriate for the fight, like Cover if the enemy was an archer or Shock if the enemy was melee, or what terrain the fight happened on to get woodsman or guerrilla (perhaps limiting it to promotions that give an offensive bonus for the terrain the defended was in if you won while attacking, and for defensive terrain bonuses for the terrain you were in if you won as defender). You could then pick a situational promotion if there is one or more, otherwise going with a purely random promotion.
There are many possible levels of complexity...
Alright, I made a new unit with new promotions, so is there a way you can make code that I could copy & paste and type the names of the units and promotions myself?
Alright, not a spreadsheet and just 1 unit & 3 promotions so far, but...
Name - Basic General
Traits (Promotions) - Good Commander, Intelligent, and Learned.
Name - Basic General
Traits (Promotions) - Good Commander, Intelligent, and Learned.
Yeah, like spit out the entire spreadsheet with units and their available promotions.
Or should everything just "make sense" with regard to how the original game is designed? Basically lookup all available promotions, check which ones are valid for the unit in question at a given point in the game, add those to a list and choose one of those at random?
edit: I looked into it and the main challenge is of curse to make any such code as efficient as possible. A good start might be to map all available promotions to some UnitCombatTypes value, and also weed out special cases like leader promotions. This should be possible to do with CvPromotionInfo.getUnitCombat() and CvPromotionsInfo.isLeader(). Something like this:
If this is valid (I haven't tested any of it myself) its only a matter of knowing where to put the code.Spoiler :
I'll try it, but i don't know where to post it in CvEventManger...
The basic idea for a custom setup like this is to put all units/unit classes/unit combat types into a dictionary or some other data structure. Like this:
Code:
unitPromotionDict = { eBasicGeneral: [eGoodCommander, eIntelligent, eLearned] }
Code:
unitPromotionDict = {
eBasicGeneral: [eGoodCommander, eIntelligent, eLearned],
eAnotherUnit: [eSomePromotion, eOtherPromotion]
}Now, before using these variables you should define them:
Code:
eBasicGeneral = gc.getInfoTypeForString("UNIT_BASIC_GENERAL")
eGoodCommander = gc.getInfoTypeForString("PROMOTION_GOOD_GENERAL")
eIntelligent = gc.getInfoTypeForString("PROMOTION_INTELLIGENT")
eLearned = gc.getInfoTypeForString("PROMOTION_LEARNED")But once you have all the constants done you can access the dictionary to do your dirty work:
Code:
eUnitType = pUnit.getUnitType()
lValidPromotions = unitPromotionDict.get(eUnitType, [])
lAvailablePromotions = lValidPromotins[:]
while lAvailablePromotions:
iNumPromotions = len(lAvailablePromotions)
iRandNum = Game().getSorenRandNum(iNumPromotions, "random promotion")
ePromotion = lAvailablePromotions[iRandNum]
if pUnit.isHasPromotion(ePromotion):
lAvailablePromotions.remove(ePromotion)
pUnit.setHasPromotion(ePromotion)
Aha, but what game event will prompt a unit to get a random promotion/trait? Because this is what the Event Handler does - it fires Python code on game events.
Is it on unit creation, perhaps? (Thats a game event.)
If you get the dictionary of units and traits in order I can create a RandomPromotion module for you, and plug it into CvEventManager. You also need to define all the promotions and units as variables - see example. (Its mostly a copy-paste job.)
Is it on unit creation, perhaps? (Thats a game event.)
If you get the dictionary of units and traits in order I can create a RandomPromotion module for you, and plug it into CvEventManager. You also need to define all the promotions and units as variables - see example. (Its mostly a copy-paste job.)
The game event should be after a battle.
Similar threads
