V131 Happiness/Beakers Bug Continues

Txurce · Feb 19, 2012

I'm now playing my third game with v131. I just noticed the same bug that I did earlier: boosting happiness with gold - that is, buying a colosseum, for example, or paying for CS Friendship with Cultural Diplomacy - results in an instant major science boost.

In my second game - still ongoing - this bug is not occurring. I doubt that it's an occasional bug, because once it appears, it's 100% consistent. I've noticed that it seems to appear later in the game. Could it be triggered by an era, a policy (not Cultural Diplomacy), a finisher, or a GW (not PT)?

Txurce · Feb 19, 2012

I've narrowed it down to one culprit: Korea. It seems to happen pretty much right away with them, but not with anyone else. It has nothing to do with the recent +1 specialist, but how the appropriate Korean scientific boosts for buildings and GL/PT are being affected by a fairly recent change in VEM.

Seek · Feb 21, 2012

Txurce said:
I've narrowed it down to one culprit: Korea. It seems to happen pretty much right away with them, but not with anyone else. It has nothing to do with the recent +1 specialist, but how the appropriate Korean scientific boosts for buildings and GL/PT are being affected by a fairly recent change in VEM.

Aha! I bet it's the dummy building granting the science in capital for happiness!!

Txurce · Feb 21, 2012

Seek said:
Aha! I bet it's the dummy building granting the science in capital for happiness!!

See, that's what I would never figure out on my own.

Txurce · Feb 21, 2012

With regard to this bug and the dummy building, keep in mind that I'm pretty sure the bug appeared since v126.

Thalassicus · Feb 22, 2012

Oooh that's why I had difficulty finding this: I hadn't tried testing with Korea. The trait gives science every time a science wonder is built in the capital. It's apparently coded wrong. Instead of searching for buildings with MaxPlayerInstances=1 (only can build one)... it searches for MaxPlayerInstances != -1 (any limitation). Dummy buildings are MaxPlayerInstances=0.

Since this bug is in the inaccessible game core, we must work around it, instead of fixing it. The science bonus has to be the stackable building because we cannot access the AI, which is also in the game core. To avoid it I think we'll have to disable the Korean trait, reverse-engineer how it works, and do it manually. This will take time but should be relatively simple.

I should have this fix in by v132. Thanks for your help in narrowing down the problem! :thumbsup:

Txurce · Feb 22, 2012

Thalassicus said:
Oooh that's why I had difficulty finding this: I hadn't tried testing with Korea.

I should have this fix in by v132. Thanks for your help in narrowing down the problem!

Yes, what happened is that I found the bug playing with Korea in v129 or v130. You then thought you had fixed it, and in my next two games on v131 it seemed that way - because I didn't use Korea. When I tried them again as part of my wide/tal comparisons, it happened again. That's when I thought "uh oh," and did a replay comparison with my saves. After which Seek explained what I had discovered to me.

Sorry you had to dig in the wrong direction. Out of curiosity, would something you did sometime after v126 have caused Korea to go haywire? I don't think it had this problem before.

kc_bandit · Feb 22, 2012

Txurce said:
Out of curiosity, would something you did sometime after v126 have caused Korea to go haywire? I don't think it had this problem before.

I think this has to be the new happiness modifier to Science in the capital with the new dummy building.

Txurce · Feb 22, 2012

You mean the fact that happiness now gives extra science, right? That's it!

Seek · Feb 22, 2012

Yep, that's what I was referring to in my post above - but I was so psyched that we figured it out I wasn't very clear!

Txurce · Feb 22, 2012

It's funny - I intuited that you had the answer, but kc bandit spelled it out so I understood it more specifically.

Thalassicus · Feb 24, 2012

This has taken slightly longer to fix than I anticipated, but still near the top of my priority list. I should have a fix in by next week.

Txurce · Feb 24, 2012

Thanks, Thal. It's just one civ, so it's not a burning priority.

Thalassicus · Feb 25, 2012

This should be fixed in v131.3 beta. :goodjob:

It turns out I had already reverse-engineered the Korean trait when they were first released. I don't remember why. I just had to adapt it a bit to what was needed here.

Txurce · Feb 26, 2012

Excellent. I don't remember why, either, although I do recall they were nerfed soon after conception.

Thalassicus · Feb 26, 2012

Well I mean I'd written the code, but had not "activated" it... so all that was required was to activate that, deactivate vanilla, and make a few tweaks.

I currently have it set up so each building in the capital gives :c5science:

equal to the cost of the technology which unlocks it. If you play and it feels like too much it's easy to adjust. The Great Library gives 110 :c5science:

for example. This mainly nerfs early buildings and buffs late ones like the Research Lab, which gave ~200sci in an era where techs cost 10,000. Now it gives 10k, and the Great Library gives only 110 (used to be more).

V131 Happiness/Beakers Bug Continues

Txurce

Deity

Txurce

Deity

Seek

Deity

Txurce

Deity

Txurce

Deity

Thalassicus

Bytes and Nibblers

Txurce

Deity

kc_bandit

Chieftain

Txurce

Deity

Seek

Deity

Txurce

Deity

Thalassicus

Bytes and Nibblers

Txurce

Deity

Thalassicus

Bytes and Nibblers

Txurce

Deity

Thalassicus

Bytes and Nibblers

Similar threads