Roland Johansen
Deity
I think that this is not intended, due to the syntax.... if it was intended we would get a "*2" in the first line instead of a crazy check if there is a promo bonus or not for the second time.....
The effects of bonus promotions vs Gunpowder units and Tanks (Pinch & Ambush) are not doubled. But any Air-strike targets will also suffer from the doubling, and that's why I think it should be fixed. (+ I share rolo's opinion about the syntax.)
It's a pity that it isn't intended. And the issue with pinch and ambush promotions not doubling unlike the combat promotions is bad for balance (that's why I asked). Still, I wish it would be possible to promote your airplanes in an effective way. It's pretty hard to fight a somewhat efficient air superiority battle even when your guys are far more experienced. Making experience unimportant in air superiority battles isn't very good for gameplay and it's also not based on realism.
Since, I would rarely use pinch and ambush on fighters anyway and since I like the effect of the doubling of combat promotion effects on air superiority combat, I wish this bug hadn't been found. Bleh, now I guess you'll want Solver to fix it.
But yeah, it's a bug. But a nice bug.