Version 2.41 release

• Illusions can no longer pickup or take equipment; they also cannot be added to Flesh Golems or Wolf Packs
• Animals will no longer have a chance to be assigned a Religion when built
• Players will no longer receive double units when capturing a unit with the <Capture> tag (ie Workers and Settlers for example) due to Slavery or promotions that allow the converting of units (ie, Command promotions)
• Hidden Nationality units will no longer be able to gate into Vassal cities
• Fix for potential crash when automating a workboat
• Players created via InitNewEmpire() will no longer receive techs that are unable to ever research (Seafaring for example) (fix by Terkhen and Magister Cultuum)
• Rebel civs will no longer receive techs that they can never research (code by Magister Cultuum)
• Permanent terrain changes will now remove any temporary terrain counters on the affected plot(s) - fix for Bug #3599496
• Advanced Tactics: Summons and Hidden Nationality units can no longer be gifted
• Advanced Tactics: Super Forts can no longer be captured by units flagged as noCapture() (includes Hidden Nationality units and units with the <bNoCapture> tag
• Advanced Tactics: In order to count as a defender for Super Fort upgrading purposes, the unit must be able to pass the canDefend() function call

• AI will now upgrade its Freaks again
• When valuing a new unit, the AI will now take into consideration the free promotions that unit receives
• AI should use Great Bards for Great Works less often

• Unit help info displayed in mouseovers now includes the Defense Combat info for the unit if it's different from the combat strength
• Many updates to Spanish translations (and a few others) (code by Terkhen)
• Updates to DynamicCivNames (base code by lgfr - modified by Tholal)
• Implementation of the EmphasizeAvoidUnhealthyCitizens and EmphasizeAvoidAngryCitizens buttons (code from WildMana, adapted by lgfr)

• Addition of Dead Player Culture mod (code by Chronis - adaption for FFH by lfgr) (note: this should only affect gameplay when the Revolutions option is enabled)

• Added the scenario files to the codebase for MNAI (really this time!)
• New code and debugging info for RevCivUtils (code by lfgr)
• Removed a reference to an event that doesn't exist in FFH2 (TheVedicAryans)
• Removed several unused text files
• Moved some text for Puppet States, Revolutions and Advanced Tactics into the appropriate files
• Fix for potential assert error when a unit tries to move after using a spell/ability that uses up their movement points

lfgr said:

Are you sure you don't want the culture of dead players appear in the city screen (I noticed that you didn't merge the python file)?
IMO it makes more sense to see it in the city screen than in the plot help popup, since it only affects revolutions.

Click to expand...

Tholal said:

Err.. what file am I missing? Everything looks merged to me.

Click to expand...

				# DEAD_PLAYER_CULTURE: commented out
				#	if ( gc.getPlayer(h).isAlive() ):
				# DEAD_PLAYER_CULTURE end
				# DEAD_PLAYER_CULTURE: indention changed
					iPercent = pHeadSelectedCity.plot().calculateCulturePercent(h)
					if ( iPercent > 0 ):
						screen.setStackedBarColorsRGB( "NationalityBar", iWhichBar, gc.getPlayer(h).getPlayerTextColorR(), gc.getPlayer(h).getPlayerTextColorG(), gc.getPlayer(h).getPlayerTextColorB(), gc.getPlayer(h).getPlayerTextColorA() )
						if ( iRemainder <= 0):
							screen.setBarPercentage( "NationalityBar", iWhichBar, 0.0 )
						else:
							screen.setBarPercentage( "NationalityBar", iWhichBar, float(iPercent) / iRemainder)
						iRemainder -= iPercent
						iWhichBar += 1
				# DEAD_PLAYER_CULTURE end

Tholal said:

And as promised, here's the test DLL.

The only change in this DLL is that the code where the AI gives extra value to starting wars against weak neighbors is now restricted to the Aggressive AI setting only.

I'd be interested in hearing how it plays on various difficulty levels.

Click to expand...

Hightower said:

Your new Scenario files seem to have broken all of the Scenarios. They look for the "FFH2MNA" mod instead of "Fall from Heaven 2", then try to load in base BTS when that fails. I got them to work by changing the Mod path (including Lord of the Balors, yay!).

Click to expand...

akatosh said:

Hightower--can you explain how to change the mod path?

Click to expand...

Tholal said:

Illusions can no longer pickup or take equipment;

Click to expand...

Hightower said:

Another bug I just discovered, though this may not be from MNAI in particular... If you set Autoplay and the original human player dies during Autoplay, there's a neat feature that allows you to choose a new civ from those surviving when Autoplay ends. Unfortunately, that feature doesn't work, at least on pre-made scenarios. You can select the new civilization, and it will tell you you've selected them and give you their minimap, but it will then prompt you to choose a new civilization again and never let you actually play. If you Ctrl-S to save and then reload, it will give you a defeat message immediately on reload. This is a tough bug to find since it requires the AI to be killed during Autoplay, but it should be easy to replicate (load up a game, use Worldbuilder to put a few barbs near your city, delete your starting troops, set Autoplay for 10 turns). I don't know enough to be able to figure out what's actually wrong in the code.

(Note: Not using Advanced Tactics, if that makes a difference.)

Click to expand...

Terkhen said:

I don't think that AIAutoplay should be intended for general usage, in my opinion it should be used for testing only. What is the point of playing if the computer plays for you?

Opinions aside, there are other bugs with AIAutoplay. It is nearly impossible to cancel it when the game is busy enough. The civilization defeated popups do not go away and start staking until AIAutoplay stops and you can close them manually, and so on. I don't consider that AIAutoplay should be a priority so I never got bothered with those problems.

Click to expand...

Hightower said:

Your new Scenario files seem to have broken all of the Scenarios. They look for the "FFH2MNA" mod instead of "Fall from Heaven 2", then try to load in base BTS when that fails. I got them to work by changing the Mod path (including Lord of the Balors, yay!).

Click to expand...

lfgr said:

My fault, I forgot to upload it

Click to expand...

Great. Could you please post the source code?

Click to expand...

if (iEnemyPowerPercent < 75)
	{
		/*
		if (GC.getGameINLINE().getCurrentPeriod() <= 2 ||
			AI_isAnyMemberDoVictoryStrategy(AI_VICTORY_CONQUEST1) ||
			GC.getGameINLINE().isOption(GAMEOPTION_AGGRESSIVE_AI))
			*/
		if (GC.getGameINLINE().isOption(GAMEOPTION_AGGRESSIVE_AI))
		{
			int iModValue = 0;

			// extra value for targeting neighbors
			if (AI_calculateAdjacentLandPlots(eTeam) > (getNumCities() * 2))
			{
				iModValue += 2;
			}

			iModValue += ((iEnemyPowerPercent < 50) ? 8 : 5);
			iModValue *= GC.getHandicapInfo(GC.getGameINLINE().getHandicapType()).getAIDeclareWarProb();
			iModValue /= 100;

			iValue *= iModValue;
		}
	}

Hightower said:

there's a neat feature that allows you to choose a new civ from those surviving when Autoplay ends. Unfortunately, that feature doesn't work, at least on pre-made scenarios. You can select the new civilization, and it will tell you you've selected them and give you their minimap, but it will then prompt you to choose a new civilization again and never let you actually play.

Click to expand...

Tholal said:

And as promised, here's the test DLL.

The only change in this DLL is that the code where the AI gives extra value to starting wars against weak neighbors is now restricted to the Aggressive AI setting only.

I'd be interested in hearing how it plays on various difficulty levels.

Click to expand...

Hightower said:

Another bug I just discovered, though this may not be from MNAI in particular... If you set Autoplay and the original human player dies during Autoplay, there's a neat feature that allows you to choose a new civ from those surviving when Autoplay ends. Unfortunately, that feature doesn't work, at least on pre-made scenarios. You can select the new civilization, and it will tell you you've selected them and give you their minimap, but it will then prompt you to choose a new civilization again and never let you actually play. If you Ctrl-S to save and then reload, it will give you a defeat message immediately on reload. This is a tough bug to find since it requires the AI to be killed during Autoplay, but it should be easy to replicate (load up a game, use Worldbuilder to put a few barbs near your city, delete your starting troops, set Autoplay for 10 turns). I don't know enough to be able to figure out what's actually wrong in the code.

(Note: Not using Advanced Tactics, if that makes a difference.)

Click to expand...

Hightower said:

Your new Scenario files seem to have broken all of the Scenarios. They look for the "FFH2MNA" mod instead of "Fall from Heaven 2", then try to load in base BTS when that fails. I got them to work by changing the Mod path (including Lord of the Balors, yay!).

Click to expand...