The Modding Q&A Thread
- Thread starter Leoreth
- Start date
and those aren't tabs in Rhye's code, those are actually 8 blank spaces for each level.
No, no... It makes perfect sense that it works now. I made a error (I blame the boards) in my initial set of code, and corrected it in the last.
About indentation: Know that it determines flow, so its absolutely key to any script. (Except a PyScenario script
)
About indentation: Know that it determines flow, so its absolutely key to any script. (Except a PyScenario script
)Well, I looked into it and while I have no idea why you're not getting the results you're expecting from it, the code seems to be somewhat cumbersome and borderline faulty in my view. (The CvUtil.findInfoTypeNum() method is, for example, simply a wrapper for CyGlobalContext.infoTypeForString(). I can of course not even verify that your module is even importing CvUtil, or how its importing it. We don't need it in any case.)
Before I rewrite anything at all: Are you defining these buildings in Consts.py? What are their names then? You're basing your thing on RFC:E/M, right?
Also: What exactly are you expecting the script to do for your mod?
No, no... It all makes perfect sense in hindsight. You trying to fix the code make it malfunction, so that it would only be run in certain circumstances. Hence it only fired once that time around. Its a matter of logic, this issue.
civ-addicted
King
I tried to change the DLL for the first time. I follow ASAF's guide and succeeded to change the Vanilla DLL (yay!). Fine so far.
But changing Rhye's DLL doesn't work. I copied all the files into the folder of the Vanilla DLL and replaced all files. Visual Studio knew that Rhyes.cpp was included while compiling although the file isn't included in the solution. Anyway, this is the output:
The good thing is that there are no errors, but one single warning.
When starting the mod, i get an python exception that CvEventInterface couldn't be loaded, and the Rhye-specific features like UPs, UHVs and the star rating doesn't show up in the civ-selection screen.
Can somebody help me?
But changing Rhye's DLL doesn't work. I copied all the files into the folder of the Vanilla DLL and replaced all files. Visual Studio knew that Rhyes.cpp was included while compiling although the file isn't included in the solution. Anyway, this is the output:
Spoiler :
When starting the mod, i get an python exception that CvEventInterface couldn't be loaded, and the Rhye-specific features like UPs, UHVs and the star rating doesn't show up in the civ-selection screen.
Can somebody help me?
civ-addicted
King
What i actually meant: I recompiled the "Vanilla" BtS DLL (version 3.19 of course), which worked, but when i copy the Rhye's source code into that very folder and compile it, i get the warning above.
hangman
almost-scientist
embryodead
Caliph
Rhye's code isn't just CvRhyes.cpp/h. if you started with vanilla BTS, make sure you copy ALL the cpp/h files from RFC/SoI's CvGameCoreDLL folder.
Re: the question in other thread - I don't have any *.rc files. The only thing you need apart from Asaf's files and the mod's cpp/h files is what Visual Studio creates.
Also, assert messages are not errors. They are just failed asserts, which is debug information and often is completely harmless (RFC fires plenty of them). They won't appear if you compile a Final_Release DLL.
Re: the question in other thread - I don't have any *.rc files. The only thing you need apart from Asaf's files and the mod's cpp/h files is what Visual Studio creates.
Also, assert messages are not errors. They are just failed asserts, which is debug information and often is completely harmless (RFC fires plenty of them). They won't appear if you compile a Final_Release DLL.
Can somebody please take a look at what im doing wrong. Im trying to add the Holy Roman Empire but my game alway crashes and i have a hunch that it has to do with the following code in CvRhyes.cpp
I think the X's in the middle are messing everything up; like some of the civs after the Xs had xxx on their spawn date, ratings etc. So i decided to remove all the XXXs but some civs still have messed up (others civs) spawn dates.
Spoiler :
I think the X's in the middle are messing everything up; like some of the civs after the Xs had xxx on their spawn date, ratings etc. So i decided to remove all the XXXs but some civs still have messed up (others civs) spawn dates.
embryodead
Caliph
This stuff was there on purpose, why would you remove it? Yes, when these arrays are not long enough, it causes crashes.
hangman
almost-scientist
I guess that explains why it still worked to some extent. I set up the debugger and it gave me an error at line 10533 of CvPlot.cpp:
Run-Time Check Failure #2 - Stack around the variable 'szBuffer' was corrupted.
Run-Time Check Failure #2 - Stack around the variable 'szBuffer' was corrupted.
Then how should i add the HRE; no matter what i do it doesnt work. Ive tried adding the HRE after Greece and leaving the XXX alone; tried putting HRE after the XXX (the one after greece). Ive tried filling HRE for XXX. Ive even tried putting HRE before Holland.
Heres the most recent thing i tried.
Spoiler :
And here is the original
Spoiler :
Below is the picture of the errors i get on the Scenario screen. Notice how Germany still says 840 ad even after i changed it to 1600 in CvRhyes (and everywhere else). And for the Holy Romans all i get is Xs. Also i get defeated message on spawn. I think that is related to this too. How can i correctly add the HRE here?
Ive added the CvRhyes.cpp for convenience of viewing.
Attachments
Im pretty sure that even though the text and graphics are in the XML; some files and commands are in CvRhyes (like the amount of stars, spawn dates and where the UHV are suppose to go). And there is still the question of where should i add the HRE?
Similar threads
