CivUp v19 Apostrophe Bug

It appears the apostrophe bug is still happening. It was either a quotation mark or double apostrophe in some of the diplomacy screen with other civs. I am sorry idont know exactly where because my game crashed and I didn't try and go back to see what it was.

If you can provide a screenshot when this next happens, that would help track down the problem. There's hundreds of lines of text so it's difficult to find something without details.

Thalassicus said:

Oh duh, I just realized what the problem is. The ' apostrophe is a special character in xml, so I must use the "'" identifier. I'll fix that right away. Thanks for reporting this!

Click to expand...

The update didn't fix anything, it's still using quotation marks for some diplomacy text, as the attached screenshot shows.

Also there's some spelling mistakes occasionally I've noticed, like the sentence "Does my face look bovvered?" in Diplomacy.xml

I could probably go through and clean most of that myself and possibly also mention them here to save time.. but as for the apostrophe bug, nothing I've tried so far has worked, then again I have absolutely no experience with XML either.

Thalassicus said:

If you can provide a screenshot when this next happens, that would help track down the problem. There's hundreds of lines of text so it's difficult to find something without details.

Click to expand...

Here ya go

Bovvered is a British term someone requested in the famous quotes thread.

Thank you jbmoll, those screenshots were very helpful. I had fixed all the lines in ExtraDiplomacyText.xml, but not the lines in Diplomacy.xml. I've corrected that for the next version

It appears the game core text files can use ' apostrophes in their xml, but mod files must use '. I don't know what causes the discrepancy. The problem happened when I copied stuff from the core files to the mod.

So I tried v23 just now, and it seems that the problem STILL exists.

Apparently using ' isn't enough by the looks of it.

Just the first screenshot is enough to demonstrate that neither ' nor ' work. I'll ask on the main modding forum.

I'm starting to think it might be an unfixable G&K bug. Did anyone see this problem in vanilla?

Have you tried the HTML... Edit: hehehe it showed up as an apostrophy! hehehe.

& # 39 ; (all put together of course).

It turns out this is a bug with the updates to ModBuddy, the tool we use to create mods. It does not include apostrophes correctly anymore. I've attempted to add them in a regular text editor instead, which posters in the main modding forum said should work.

I haven't played Civ V in a while so I've been out of the loop for the last half-year or so, but as of CivUP build v2.3.2 the apostrophe issue is still occurring, so it seems whatever measures you've tried so far simply haven't worked. Unless I'm doing something wrong..

And sorry for digging up a old thread like this. I just didn't see the point of making a new thread when this one should suffice.

Thread might need a title update however to clarify that this still affects the mod even now.

Slightly off topic but why are these messages even included in the mod?

I would assume along these lines.

Unmodded game - Start program - load original files - begin game
Modded game with new content - Start program - load original files - load additional files - begin game
Modded game with replacement content - Start program - load original files - load additional files - replace originals - begin game

Now from what I can see the text that has the apostrophe bug is the same as the original. The only difference I can see is the XML tags surrounding it.

Original

<Row Tag="TXT_KEY_DIPLO_DISCUSS_MESSAGE_SORRY">
<Text>We're sorry this has caused a divide between us.</Text>
</Row>

Click to expand...

Modded

<Update>
<Where Tag="TXT_KEY_DIPLO_DISCUSS_MESSAGE_SORRY" />
<Set Text="We're sorry this has caused a divide between us." />
</Update>

Click to expand...

Now if the answer is really simple don't flame me for being stupid, but I just can't understand why we are updating something if nothing is changed.

My modding background from other games tells me only to include CHANGED or ADDED material in a mod. I can't see what is going on here

Help

Am I thick or what?

I assumed most of the messages I saw were the original texts.

On further investigation I now see what's going on.

Rather than adding new diplomacy text to the original it looks like the originals are being UPDATED with new text.

So where there is a 'TEXT_KEY_Blah_Blah_Blah in' the original, that "Row Tag=" and "Text" are changed with "Where Tag=" and "Set Tag="

Yes?

Could the original messages not be kept and these ones put in with the EXTRA messages in the ExtraDiplomacyText.xml?

They are all formatted with "Row Tag=" and "Text" but with extra 'TEXT_Key_' .


Maybe something strange is happening with "UPDATE" tags and that's messing up the apostrophes?

This problem should be solved in Civup v2.4, where I moved the diplomacy text to a sql file (was in xml). This gives more control over the format of the file and text.

Alright seems it's finally working properly now.