CvGameUtils.py in Bug (RevDCM)

[OrionVeteran]

The following code looks correct, but fails to prevent "Slave Cage" building from appearing on the production list, when the player has not changed labor civic to slavery. The slave cage appears on the list when it should not.

Spoiler :

def canConstruct(self,argsList):
	pCity = argsList[0]
	eBuilding = argsList[1]
	bContinue = argsList[2]
	bTestVisible = argsList[3]
	bIgnoreCost = argsList[4]

	pPlayer = gc.getPlayer(pCity.getOwner())		
			
	if eBuilding == gc.getInfoTypeForString("BUILDING_SLAVE_CAGE"):
		if (pPlayer.getCivics(gc.getInfoTypeForString("CIVICOPTION_LABOR")) == gc.getInfoTypeForString("CIVIC_SLAVERY")):
			return True

	return False

and...

Spoiler :

def cannotConstruct(self,argsList):
	pCity = argsList[0]
	eBuilding = argsList[1]
	bContinue = argsList[2]
	bTestVisible = argsList[3]
	bIgnoreCost = argsList[4]

	pPlayer = gc.getPlayer(pCity.getOwner())		
			
	if eBuilding == gc.getInfoTypeForString("BUILDING_SLAVE_CAGE"):
		if not (pPlayer.getCivics(gc.getInfoTypeForString("CIVICOPTION_LABOR")) == gc.getInfoTypeForString("CIVIC_SLAVERY")):
			return True

	return False

What have I missed?


Orion Veteran

 

[phungus420]

The Return False at the end whipes your code for the Slave Cage. Put the slave cage code after the Return false.

 

[EmperorFool]

Did you enable these callbacks in PythonCallbackDefines.xml? They are all disabled by default.

<Define>
	<DefineName>USE_CANNOT_CONSTRUCT_CALLBACK</DefineName>
	<iDefineIntVal>[B][COLOR="Orange"]1[/COLOR][/B]</iDefineIntVal>
</Define>
<Define>
	<DefineName>USE_CAN_CONSTRUCT_CALLBACK</DefineName>
	<iDefineIntVal>[B][COLOR="Orange"]1[/COLOR][/B]</iDefineIntVal>
</Define>

This is not specific to BUG; the normal game uses this file to determine which Python callbacks the DLL should use.

 

[OrionVeteran]

Did you enable these callbacks in PythonCallbackDefines.xml? They are all disabled by default.

That was it! Ops check good! I had totally forgotten about the call backs.



Orion Veteran

 

[phungus420]

Really, this isn't an issue?

	if eBuilding == gc.getInfoTypeForString("BUILDING_SLAVE_CAGE"):
		if not (pPlayer.getCivics(gc.getInfoTypeForString("CIVICOPTION_LABOR")) == gc.getInfoTypeForString("CIVIC_SLAVERY")):
			return True

	return False

Wouldn't that return False at the end override the return true in the if statement above?

 

[EmperorFool]

When a function gets to a return statement, it immediately exits the function and returns the specified value. It does not execute any code from the return to the end of the function.

In this function, each test is checked one-by-one until one succeeds and returns the specified value. Once that happens, no more tests are checked and the function exits with the given value. Only if every if test fails is the final return hit.

def getAnimalName(nLegs)
    if nLegs == 1000:
        return "millipeed"
    if nLegs == 100:
        return "centipede"
    if nLegs == 4:
        return "cat"
    if nLegs == 2:
        return "human"
    return "dunno"

 

[phungus420]

OK thanks, didn't know that.