Code Doesn't Work At All

[deanej]

I'm trying to make it so that you can only have 5 of a certain unit at any given time. Unfortunately, the code for this doesn't work at all - it doesn't do anything, not errors, no nothing, it's like its not even there. Here's what I added:
at the start of CvFinalFrontierEvents, after #globals:

iNumKazon = 0

in onGameStart:

		global iNumKazon

		iNumKazon = 0

in onUnitBuilt:

		iKazonUU = CvUtil.findInfoTypeNum(gc.getUnitInfo,gc.getNumUnitInfos(),'UNIT_KAZON_TORPEDO')
		global iNumKazon

		if(pUnit.getUnitType() == iKazonUU):
                    iNumKazon += 1

in onUnitLost:

		iKazonUU = CvUtil.findInfoTypeNum(gc.getUnitInfo,gc.getNumUnitInfos(),'UNIT_KAZON_TORPEDO')
		global iNumKazon

		if(unit.getUnitType() == iKazonUU):
                    iNumKazon -= 1

in cannotTrain of CvGameUtils:

		FinalFrontier = CvEventInterface.getEventManager()

		if (eUnit == iKazonUU):
                    if (FinalFrontier.iNumKazon == 5):
                        return True

What on Earth am I doing wrong? I NEED this limit in my mod. Please help.

 

[Sto]

Do you have added the pythonCallBack needed in "PythonCallbackDefines.xml" ?

Wouldn't it be easier to do like this in cannotTrain :

		pCity = argsList[0]
		eUnit = argsList[1]
		ePlayer = pCity.getOwner()

                iKazonUU = CvUtil.findInfoTypeNum(gc.getUnitInfo,gc.getNumUnitInfos(),'UNIT_KAZON_TORPEDO')
                iKazonUUClass = gc.getUnitInfo(iKazonUU).getUnitClassType()

                if (eUnit == iKazonUU) :
                        if gc.getPlayer(ePlayer).getUnitClassCountPlusMaking(iKazonUUClass) >= 5 :
                                return True

Or change XML to have iKazonUU its own unit class ... with all the work with building , civilization editing .

Tcho !

 

[Gaius Octavius]

If you only want X amount of a unit at any given time, why don't you just use the national limit tag in XML, like with missionaries?

 

[deanej]

Sto, I tried your code and it still doesn't work. It's definitely enabled in the XML - the starbase code above it works just fine. I can't make it its own unitclass because then the game won't know it's a UU and it won't show up as such on the player selection screen.

 

[Sto]

I've just tested the code with UNIT_WARRIOR and it works fine for me ???

 

[Dale]

Repeating:

If you only want X amount of a unit at any given time, why don't you just use the national limit tag in XML, like with missionaries?

 

[deanej]

I figured out what happened: Before the starbase code, there is a line that says #block out the rest, which is followed by return False. No idea why the starbase code was working (and maybe it wasn't; I didn't really pay that much attention), but removing the return False solves the problem. Thanks!

 

[jkp1187]

I'm with Dale and Gaius on this one....no need to over-think the plumbing here.

 

[Gaius Octavius]

The only reason I could see for doing this would be if you wanted to start out with no limits, and then wanted to limit the number of units if a special trigger occurred. But surely there is still a better way to do that...?

 

[Dale]

The only reason I could see for doing this would be if you wanted to start out with no limits, and then wanted to limit the number of units if a special trigger occurred. But surely there is still a better way to do that...?

Create an SDK function that allows changing of the national limit, then expose to python and write the hook into the events function in python.

You'd end up with something like: player.changeUnitLimit(unitType, change)