EDIT: I think building info xml haven't been read yet when exposing enums to python. That is an issue there to look into.
I might as well tell how I solved this in WTP. First of all, the exe calls in this order:
- CvXMLLoadUtility::LoadPlayerOptions
- DLLPublishToPython()
- TXT_KEY and globalDefine loading
- CvXMLLoadUtility::LoadPreMenuGlobals
I added a single function, which loads all xml files. It is called in step 1 and 4. Next I modded CvXMLLoadUtility::SetGlobalClassInfo
PHP:
if (bFirstRead)
{
bSuccess = pClassInfo->CvInfoBase::read(this);
}
else
{
bSuccess = pClassInfo->read(this);
}
This way getType can be used on all info files both when setting up python and when reading all the files for real. As such reading order becomes less important and the need for readPass2+3 is reduced if not removed entirely.
A light version of this would be to make CvXMLLoadUtility::LoadPlayerOptions load types of selected files and then not touch the rest of the loading code. This will likely be easier to write and with less risk of messing up.
In CyEnumsPythonInterface(), I added
PHP:
static bool bFirstRun = true;
if (bFirstRun)
{
bFirstRun = false;
}
else
{
// run this function on reloads, thorugh skip it the first time as it is handled later in the xml reading order
CyEnumsPythonInterfacePostApply();
}
This means CyEnumsPythonInterfacePostApply won't be called the first time this function is called, but if somebody changes python files, they will be reloaded and CyEnumsPythonInterface will be called again, this time it will call CyEnumsPythonInterfacePostApply. This allows placing part of the loading process after all xml data has been read.
I even added a vector to allow adding a class first and then add more values to it in CyEnumsPythonInterfacePostApply. You can read
my cpp file for details on how that works.
it fails to compile, ( i probably did the == wrong) but still fails.
The issue is indeed the ==. You are comparing two wchar pointers, which isn't what you want to do as you compare the address of the two pointer. This will be false even if the string values of both happens to be the same. You want to compare two strings.
PHP:
if (CvWString(GC.getEventTriggerInfo(eTrigger).getText()) == L"EVENTTRIGGER_PALACE_UPGRADE")
Here it creates a CvWString, uses the wchar pointer as a constructor and then it compares using the overloaded == operator of CvWString, which will then do what you expect it to do. The nameless CvWString will go out of scope and clean itself up as soon as you are done with the if testing. Also getText doesn't take an argument.
You may also want to consider breaking out of the loop once you have found the value you are looking for. Nothing bad will happen from continuing the loop, but this thread is about performance, so it should be pointed out.
Do note that vanilla will not have loaded EventTriggerInfos when DLLPublishToPython is called, hence GC.getNumEventTriggerInfos() will return 0 unless you mod xml loading order.
