Unofficial 3.19 Patch SDK Changes

[Roamty]

Unofficial 3.19 Patch SDK Changes These should be added to the Unofficial 3.19 Patch :

Can you make these Unofficial added to the patch The_J
SDK changes:

In CvGameCoreUtils.cpp
case ACTIVITY_INTERCEPT: szString = L"ACTIVITY_SENTRY"; break;
Should be change to
case ACTIVITY_INTERCEPT: szString = L"ACTIVITY_INTERCEPT"; break;

In CvGameTextMgr
iTempModifier += GC.getDefineINT("ESPIONAGE_CITY_HOLY_CITY_MOD");;
Should be change to
iTempModifier += GC.getDefineINT("ESPIONAGE_CITY_HOLY_CITY_MOD");

In CvInfos
int getYieldModifier(int i) const;; // Exposed to Python
Should be change to
int getYieldModifier(int i) const; // Exposed to Python

in CvPlayer.cpp
iTempModifier += GC.getDefineINT("ESPIONAGE_CITY_HOLY_CITY_MOD");;
Should be change to
iTempModifier += GC.getDefineINT("ESPIONAGE_CITY_HOLY_CITY_MOD");

In CvTeamAI.cpp
// if we not human, do we want to continue war for strategic reasons?
Should be change to
// if we are not human, do we want to continue war for strategic reasons?

iValue += ((bWarPlan ? 100 : 50) * (iCombatRatio - 40)) / 50;;
Should be change to
iValue += ((bWarPlan ? 100 : 50) * (iCombatRatio - 40)) / 50;



The zip file I have here can be use to update Unofficial 3.19 Patch SDK by jdog5000

 

[The_J]

Can you make these Unofficial added to the patch The_J

?
I don't have anything to do with the unofficial patch, that's jdog et al's project.
You should ask in the subforum if somebody will add them (doubt it, don't think there's anyone still really active), else I suggest that you add the changes and publish a new version of the unofficial patch . I doubt anyone would mind that .

 

[Roamty]

Any one that finds typo errors in the XMl, Python, Art, or something they miss etc from BTS add here and we try to update the Unofficial 3.19 Patch

Like in the file XML CIV4BuildingInfos:

<BuildingClass>BUILDINGCLASS_COAL_PLANT</BuildingClass>

<ConstructSound/>
should be
<ConstructSound>AS2D_BUILD_PLANTCOAL</ConstructSound>

<BuildingClass>BUILDINGCLASS_SUPERMARKET</BuildingClass>

<ConstructSound>AS2D_BUILD_GROCERY</ConstructSound>
should be
<ConstructSound>AS2D_BUILD_SUPERMARKET</ConstructSound>

Like in the file XML CIV4UnitClassInfos:

<Type>UNITCLASS_SHIP_OF_THE_LINE</Type>

<Description>TXT_KEY_SHIP_OF_THE_LINE</Description>
should be
<Description>TXT_KEY_UNIT_SHIP_OF_THE_LINE</Description>

 

[Cybah]

Did you update the up_v1_6_sources.zip? For example I can still find 2 ;; in it there.


Edit: Seems that there are more typo errors than your "iTempModifier += GC.getDefineINT("ESPIONAGE_CITY_HOLY_CITY_MOD");;"

 

[Roamty]

Did you update the up_v1_6_sources.zip? For example I can still find 2 ;; in it there.


Edit: Seems that there are more typo errors than your "iTempModifier += GC.getDefineINT("ESPIONAGE_CITY_HOLY_CITY_MOD");;"

No I have not updated Unofficial 3.19 Patch up_v1_6_sources the ones here are what is needed to update the Unofficial 3.19 Patch

I'am asking that anyone find that something is needed to be added to the Unofficial 3.19 Patch to post here I then check it out and add to Unofficial 3.20 Patch that i'am going to make