A "Better" Domestic Advisor ?

GoldenAge said:
This looks spectacular. I think I'll wait until the city names are clickable before I give it a shot though. Great work!
I miss that, too... but it looks great so far :D
 
OK, clearing the cache worked. Guess I wasn't looking closely enough at the descriptions of where it was. Thought it was in the My Documents/My Games along with all the other folders.

Really don't like the idea of a games files being in three different areas of the directory structure.
 
Hi, thanks a lot for you job, it's really great.
I'd like just to point out that the 10th column's heading actually is the total commerce produced in the city (before the splitting between science, culture and gold) and not the gold production. Maybe it would be more correct to make it show the exact gold production...Have you guys the same outcome?

P.S.: anyone has the same problem with me with the domestic advisor? I see some upside-down question marks instead of some icons, in particular instead of "food turn to growth", "hammers" and "gold". I had the same problem with the default advisor (i can't remember which were the icons...)
 
If you look at the previous page of this thread, that's an issue with non-English localised versions of the game.
 
Thank you BeefontheBone...I had missed that issue... I installed the fixed patch, cleaned the cache BUT now it only remains one column with that awfuol symbol...
Ironically, it is the one that reports the total commerce produced by the city...Anyone can help me fixing this last one?

thanks in advance!
 
Hello homegrown
I don't want do steal your work, but I haved change your Advisor a little bit, I hope this is ok so.

I have changed some Details and have worked on the localization of this file.

Following Files are changed/new
1.python/PyHelpers.py - original from homeground
2.python/screens/CvDomesticAdvisor.py
3.xml/text/CIV4GameText_Misc1.xml

It should work with all languages, but i have only translated for the german version, file no.3 can be changed for other languages..at the end of file(actually all in english)
 

Attachments

  • Civ4ScreenShot0004.JPG
    Civ4ScreenShot0004.JPG
    161.2 KB · Views: 723
  • Civ4ScreenShot0005.JPG
    Civ4ScreenShot0005.JPG
    161 KB · Views: 626
  • Domestic.zip
    Domestic.zip
    93.2 KB · Views: 460
terrasol said:
Hello homegrown
I don't want do steal your work, but I haved change your Advisor a little bit, I hope this is ok so.

I like the red numerics, more useful than an icon (imo). Question, what is determining the red numbers under the strength column?
 
oh this was a gimmick for me ;)

i have said, if my town has less then three combat-units in it, then i want to see this in red
 
kalder said:
Thank you BeefontheBone...I had missed that issue... I installed the fixed patch, cleaned the cache BUT now it only remains one column with that awfuol symbol...
Ironically, it is the one that reports the total commerce produced by the city...Anyone can help me fixing this last one?

thanks in advance!

Perhaps the order of the columns got wrong:

Code:
# Food Turns to Growth
szText = u"%c" %(gc.getYieldInfo(YieldTypes.YIELD_FOOD).getChar())
screen.setTableColumnHeader( "CityListBackground", [B]6[/B], szText, 30 )

# Net Health Column
screen.setTableColumnHeader( "CityListBackground", [B]7[/B], unicode(CvUtil.getIcon('healthy')), 30 )

# Production Column
szText = u"%c" %(gc.getYieldInfo(YieldTypes.YIELD_PRODUCTION).getChar())
screen.setTableColumnHeader( "CityListBackground", [B]10[/B], szText, 40 )

# Gold Column
screen.setTableColumnHeader( "CityListBackground", [B]9[/B], unicode(CvUtil.getIcon('gold')), 40 )

The bold numbers must be numbered ascending.
 
jack-itb said:
Perhaps the order of the columns got wrong:


The bold numbers must be numbered ascending.

Thanks a lot for answering!! However, I must admit I'm not very strong in modifying the code. Would you please explain me where I can find the file and how should it be corrected?
It would be a great help.

I'd like to thank also terrasol, you modifications are interesting!!
May I ask you where should I install the 3rd file? xml/text is always in the "usual" MY GAME folder?

Thank you
 
you can install this in
'dummy'\My Games\Sid Meier's Civilization 4\CustomAssets\xml\text

'dummy' appends from your computer-settings....unfortunately i only know in german settings, there this is named 'Eigenen Dateien'...but i think someone can tell you this in english settings

I have changed the DomesticAdvisor again, now you can see the really gold production of your town, depent on your percent settings

see http://forums.civfanatics.com/showpost.php?p=3301432&postcount=88
 
Hello guys!!

First, i would thank everyone who contributed tor the new advisor. :D

I have just added a few line into it ... I somewhat managed to make the city screen appear in the back when you select a city in the table.
Look at this:

civ4.jpg

I added a VIEW button on the bottom. If you click on VIEW, you'll go in the city. If you quit, you'll go back where you were before.

But there is problem : what i get when someone click in the table, is the index of the selected row in the table, which is NOT the city index when the table has been ordered in a other way than the 'standard' order.
Maybe someone will find a way to fix that, I have to :sleep: for now.
Look at the handleInput function, everything is there

Code:
	def handleInput (self, inputClass):
		' Calls function mapped in DomesticAdvisorInputMap'
		# only get from the map if it has the key
		
		if ( inputClass.getNotifyCode() == NotifyCode.NOTIFY_LISTBOX_ITEM_SELECTED ):
			screen = CyGInterfaceScreen( "DomesticAdvisor", CvScreenEnums.DOMESTIC_ADVISOR ) 
			# Index in the table
		        iIndex = inputClass.getData()
		        self.chosenCity = iIndex
		        # Old behaviour
#			screen.updateAppropriateCitySelection( "CityListBackground", len( PyPlayer(CyGame().getActivePlayer()).getCityList() ) )
                        # Automatically close the screen when select
#			screen.hideScreen()
                        # Go to the city
#			CyInterface().lookAtCityOffset(iIndex)

                        city = CyGlobalContext().getActivePlayer().getCity(iIndex)
                        # Select the city
			CyInterface().selectCity(city, True)

                        # Make the city screen appear
			CyEngine().setCityBillboardVisibility(True)
		else:
		        if (inputClass.getFunctionName() != "DomesticView"):
		              return 0
		        # Handle the view 'button'
			screen = CyGInterfaceScreen( "DomesticAdvisor", CvScreenEnums.DOMESTIC_ADVISOR )
			screen.hideScreen()	
#                        CvUtil.pyPrint('funName = %s' %(inputClass.getFunctionName()))
                        city = CyGlobalContext().getActivePlayer().getCity(self.chosenCity)
			CyInterface().selectCity(city, True)
			CyEngine().setCityBillboardVisibility(True)
		return 0

Here is the new domestic.zip attached
View attachment Domestic.zip
 
I downloaded the advisor and placed the files where there should be as mentioned here and in the readme but the advisor i see in the game is the one that shiped with the game. If i place the files in "program files/firaxis games/civ4/assets" etc and replace the original files ( or rename the originals) and then put the files from the zip in their place i also see the original advisor and as a bonus i can no longer load a saved game!!!!
Anyone knows what i should do?

I also tried cleaning the cashe but after i did that and tried to load the game i got a "can't load CvWBInterface" error when the game tried to load python and inside the game i had no interface. I quitted abd loaded again to no vain. All I got was the original advisor...
 
Hi

I do not understand. This mod doesn't work. Also flags mods dont work.
I copy all files into folders that are mentioned in instruction. Then I play new game. And nothing.....

What am I doing wrong?? :confused: :confused: :confused: :confused: :confused:
 
Keep up the good work Homegrown, with this and your clocks mod you've been doing sterling service for all Civ4 fanatics :)
 
Back
Top Bottom