[BUG] some french localization errors

[chrin67]

Bonjour,
Some localization errors in french:

1) I get, almost at each turn, messages like: (I translated them back to english)
"Our Research Agreement with THE Bismark has ended."
"A deal where we provided gold to THE Catherine has ended."
The best one is: "The an unknown player denonced the an unknown player." (which btw should be simply removed)

The problem is that it is rude (or at least pejorative) to prepend an article to a name in french, so that such messages sound rather ridiculous with respect to the diplomatic messages written in very proper french.

2) same problem with wonder names like "Notre-Dame" (no article)

3) gender/article errors in luxury names (seems to be fixed in the newest XML files, I'll check in my next games)

Some suggestions (for the next patch) :

1) if I understood the model correctly, the general patterns for civName (short name) should be:

{@1: plural 1?{@1: gender *:no_article?#; *:vowel?l'; m?le ; f?la ;}; 2?les ;}{@1_CivName}
(e.g. Rome/la Grèce/le Japon/les Aztèques)

{@1: plural 1?{@1: gender *:no_article?à;*:vowel?à l'; m?au ; f?à la ;}; 2?aux ;}{1_CivName:textkey}
(e.g. à Rome/à la Grèce/au Japon/aux Aztèques)

etc.

and Rome should be defined as:

<Row Tag="TXT_KEY_CIV_ROME_SHORT_DESC">
<Text>Rome</Text>
<Gender>feminine:no_article:</Gender>
<Plurality>1</Plurality>
</Row>

because Rome has no article in French (except in some exceptions ;-)

2) same problem with some wonder names

3) it seems that there is a confusion in many notifications between CivName and LeaderName:

example:

<Row Tag="TXT_KEY_NOTIFICATION_DEAL_EXPIRED_GPT_TO_US">
<Text>L'accord stipulant que {@1: plural 1?{@1: gender *:vowel?l'; m?le ; f?la ;}; 2?les ;}{1_CivName:textkey} {@1: plural 1?devait; 2?devaient;} nous verser de l'or à chaque tour a pris fin.</Text>
</Row>

should be changed depending upon which parameter is really passed (civName or leaderName) in:

<Row Tag="TXT_KEY_NOTIFICATION_DEAL_EXPIRED_GPT_TO_US">
<Text>L'accord stipulant que {@1: plural 1?{@1: gender *:no_article?#; *:vowel?l'; m?le ; f?la ;}; 2?les ;}{1_CivName:textkey} {@1: plural 1?devait; 2?devaient;} nous verser de l'or à chaque tour a pris fin.</Text>
</Row>

or simply

<Row Tag="TXT_KEY_NOTIFICATION_DEAL_EXPIRED_GPT_TO_US">
<Text>L'accord stipulant que {1_LeaderName:textkey} devait nous verser de l'or à chaque tour a pris fin.</Text>
</Row>