can't find the problem with the code

[nightingale~]

hello,

i've tried creating a personal mod for myself with a mod's template i found a few months ago and came back to job being unfinished, so i tried writing it.

Spoiler Code :

<?xml version="1.0" encoding="utf-8"?>
<GameInfo>
    <LeaderTraits>
        <Delete LeaderType="LEADER_HARDRADA"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="CULTURE_KILLS_TRAIT"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="FIRST_EMPEROR_TRAIT"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="FLYING_SQUADRON_TRAIT"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_CULTURAL_MAJOR_CIV"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_EXPANSIONIST"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_DIVINE_WIND"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_EL_ESCORIAL"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_GIFTS_FOR_TLATOANI"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_GRAND_EMBASSY"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_HOLY_ROMAN_EMPEROR"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_LITHUANIAN_UNION"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_MAGNANIMOUS"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_MEDITERRANEAN"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_MELEE_COASTAL_RAIDS"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_UNIT_NORWEGIAN_LONGSHIP"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_KILLER_OF_CYRUS"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_PAX_BRITANNICA"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_RELIGIOUS_MAJOR_CIV"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_RIGHTEOUSNESS_OF_FAITH"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_ROOSEVELT_COROLLARY"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_SATYAGRAHA"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_SURROUNDED_BY_GLORY"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAJANS_COLUMN_TRAIT"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_UNIT_POLISH_HUSSAR"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_CITADEL_CIVILIZATION"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_PERPETUALLY_ON_GUARD"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_TO_WORLDS_END"/>
        <Row LeaderType="LEADER_HARDRADA" TraitType="TRAIT_LEADER_FALL_BABYLON"/>
    </LeaderTraits>
    <CivilizationTraits>
        <Delete CivilizationType="CIVILIZATION_NORWAY"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_HELLENISTIC_FUSION"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_BUILDING_BASILIKOI_PAIDES"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_SATRAPIES"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_ADJACENT_DISTRICTS"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_ALL_ROADS_TO_ROME"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_AMAZON"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_BUILDING_ELECTRONICS_FACTORY"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_BUILDING_FILM_STUDIO"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_BUILDING_SUKIENNICE"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_DISTRICT_HANSA"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_DOUBLE_ARCHAEOLOGY_SLOTS"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_DYNASTIC_CYCLE"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_EARLY_OCEAN_NAVIGATION"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_EXTRA_LIGHT_CAVALRY"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_FOUNDING_FATHERS"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_GOLDEN_LIBERTY"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_IMPERIAL_FREE_CITIES"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_ITERU"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_MOTHER_RUSSIA"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_NKISI"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_PLATOS_REPUBLIC"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_TREASURE_FLEET"/>
        <Row CivilizationType="CIVILIZATION_NORWAY" TraitType="TRAIT_CIVILIZATION_WONDER_TOURISM"/>
    </CivilizationTraits>
</GameInfo>

also this is the modinfo file if that's the root of the problem

Spoiler ModInfo :

<?xml version="1.0" encoding="utf-8"?>
<Mod id="7f95196e-9f4a-11e6-80f5-76304dec7eb7" version="3">
    <Properties>
        <Name>MyCivOverhaul</Name>
        <Stability>Alpha</Stability>
        <Teaser>Gives my civilization an overhaul.</Teaser>
        <Description>Gives a civilization an overhaul including various Civilization leaders' traits.</Description>
        <Authors>nightingale~</Authors>
    </Properties>
    <Dependencies />
    <References />
    <Blocks />
    <Components>
        <UpdateDatabase id="MyCivOV">
            <Items>
                <File>MyCivOV.xml</File>
            </Items>
        </UpdateDatabase>
    </Components>
    <Files>
        <File>MyCivOV.xml</File>
    </Files>
</Mod>

could somebody please help me? i've removed a few things like trait modifiers but i cant find the problem.

 

[Infixo]

1. Would be easier if you attached log files.
2. Check all traits that DO NOT start with TRAIT_ and make sure the names are correct 'cos I believe that all traits should start with TRAIT_

 

[Gleb Bazov]

DELETE FROM LeaderTraits WHERE LeaderType='LEADER_HARDRADA';

INSERT INTO LeaderTraits
(    LeaderType,            TraitType                                ) VALUES
(    'LEADER_HARDRADA',     'CULTURE_KILLS_TRAIT'                    ),
(    'LEADER_HARDRADA',     'FIRST_EMPEROR_TRAIT'                    ),
(    'LEADER_HARDRADA',     'FLYING_SQUADRON_TRAIT'                    ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_CULTURAL_MAJOR_CIV'        ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_DIVINE_WIND'                ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_EL_ESCORIAL'                ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_GIFTS_FOR_TLATOANI'        ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_GRAND_EMBASSY'            ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_HOLY_ROMAN_EMPEROR'        ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_LITHUANIAN_UNION'            ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_MAGNANIMOUS'                ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_MEDITERRANEAN'            ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_MELEE_COASTAL_RAIDS'        ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_UNIT_NORWEGIAN_LONGSHIP'    ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_KILLER_OF_CYRUS'            ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_PAX_BRITANNICA'            ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_RIGHTEOUSNESS_OF_FAITH'    ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_ROOSEVELT_COROLLARY'        ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_SATYAGRAHA'                ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_SURROUNDED_BY_GLORY'        ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_UNIT_POLISH_HUSSAR'        ),
(    'LEADER_HARDRADA',     'TRAIT_LEADER_CITADEL_CIVILIZATION'        );

DELETE FROM CivilizationTraits WHERE CivilizationType='CIVILIZATION_NORWAY';

INSERT INTO CivilizationTraits
(    CivilizationType,        TraitType                                            ) VALUES
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_HELLENISTIC_FUSION'                ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_BUILDING_BASILIKOI_PAIDES'        ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_SATRAPIES'                        ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_ALL_ROADS_TO_ROME'                ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_AMAZON'                            ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_BUILDING_ELECTRONICS_FACTORY'    ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_BUILDING_FILM_STUDIO'            ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_DISTRICT_HANSA'                    ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_DOUBLE_ARCHAEOLOGY_SLOTS'        ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_DYNASTIC_CYCLE'                    ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_EARLY_OCEAN_NAVIGATION'            ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_EXTRA_LIGHT_CAVALRY'            ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_FOUNDING_FATHERS'                ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_GOLDEN_LIBERTY'                    ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_IMPERIAL_FREE_CITIES'            ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_ITERU'                            ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_MOTHER_RUSSIA'                    ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_NKISI'                            ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_PLATOS_REPUBLIC'                ),
(    'CIVILIZATION_NORWAY',     'TRAIT_CIVILIZATION_WONDER_TOURISM'                    );

Insert this into / create an SQL file and attach it to your modinfo as you would with an XML file. I don't see any reason why the above would not work; however, I have not tested it.

I think I know why your mod did not work. The following traits:"

TRAIT_LEADER_PERPETUALLY_ON_GUARD
TRAIT_LEADER_TO_WORLDS_END
TRAIT_LEADER_FALL_BABYLON

appear nowhere in my files. And I checked both the pre-Spring patch and post-Spring patch databases. Either there is a mistake somewhere, or you took these traits for a mod. Or maybe I am blind

The following traits:

TRAIT_LEADER_EXPANSIONIST
TRAIT_LEADER_RELIGIOUS_MAJOR_CIV

are useless, AFAIK. They exist for flavour and diplomacy mechanics. AFAIK. I did not include them above.

I did not check CivilizationTraits closely, but none of the traits stood out as erroneous.

Good luck. (PS, SQL is really the better of way of dealing with Civ 6 database. A lot less mucking about.)

 

[Gleb Bazov]

Oh yes, it looks like those incorrect traits were the problem you had with the code. Here's the correct Babylon trait, for instance:

<Row>
<ModifierId>TRAIT_FALLBABYLON_NO_OCCUPATION_PENALTIES</ModifierId>
<Name>NoPenalties</Name>
<Value>true</Value>
</Row>
<Row>
<ModifierId>TRAIT_FALLBABYLON_SURPRISE_MOVEMENT</ModifierId>
<Name>DiplomaticYieldSource</Name>
<Value>SURPRISE_WAR_INITIATED</Value>
</Row>
<Row>
<ModifierId>TRAIT_FALLBABYLON_SURPRISE_MOVEMENT</ModifierId>
<Name>TurnsActive</Name>
<Value>10</Value>
</Row>
<Row>
<ModifierId>TRAIT_FALLBABYLON_SURPRISE_MOVEMENT</ModifierId>
<Name>Amount</Name>
<Value>2</Value>
</Row>

 

[LeeS]

1. Would be easier if you attached log files.
2. Check all traits that DO NOT start with TRAIT_ and make sure the names are correct 'cos I believe that all traits should start with TRAIT_

It is important to verify you have the trait-names correct, but no, not all traits as supplied by Firaxis being with TRAIT_, nor is there any code-requirement to do so:

<LeaderTraits>
	<Row LeaderType="LEADER_TRAJAN" TraitType="TRAJANS_COLUMN_TRAIT"/>
	<Row LeaderType="LEADER_TRAJAN" TraitType="TRAIT_LEADER_EXPANSIONIST"/>
</LeaderTraits>

It is merely good-practice and convention to start all traits with TRAIT_ disregarding the few wherein Firaxis disregarded this convention. It's easier to understand your own code if traits always start with TRAIT_, buildings with BUILDING_, etc. And you avoid difficulties with code-failure in those specific cases where the game expects such tag-names to begin in such a way (like the way BUILDING_DONUTS will automatically be linked to ICON_BUILDING_DONUTS and ICON_BUILDING_DONUTS_FOW, and does not want any other combination except ICON_[building type-name]).