"Fresh Water" improvement yields don't work

[Minor Annoyance]

I've tried Improvement_TechFreshWaterYieldChanges and Improvement_FreshWaterYields and neither work. I wondered why they'd disable the code for civBE when it was already in civ5 and they could just not use it. It might just be that there is a bug that is screwing it up but since they never used it they'd never know.

 

[whoward69]

I don't know how, but the XML parser seems to have been broken (for some tables), the following XML gives no errors, but adds an incomplete row into the Improvement_FreshWaterYields table and no row into the Improvement_TechFreshWaterYieldChanges table

<Improvement_FreshWaterYields>
  <Row>
	<ImprovementType>IMPROVEMENT_FARM<ImprovementType>
	<YieldType>YIELD_FOOD<YieldType>
	<Yield>3<Yield>
  </Row>
</Improvement_FreshWaterYields>

<Improvement_TechFreshWaterYieldChanges>
  <Row>
	<ImprovementType>IMPROVEMENT_FARM<ImprovementType>
	<TechType>TECH_GENETICS<TechType>
	<YieldType>YIELD_FOOD<YieldType>
	<Yield>2<Yield>
  </Row>
</Improvement_TechFreshWaterYieldChanges>

but the corresponding SQL correctly adds both rows

INSERT INTO Improvement_FreshWaterYields(ImprovementType, YieldType, Yield) VALUES('IMPROVEMENT_FARM', 'YIELD_FOOD', 4);
INSERT INTO Improvement_TechFreshWaterYieldChanges(ImprovementType, TechType, YieldType, Yield) VALUES('IMPROVEMENT_FARM', 'TECH_GENETICS', 'YIELD_FOOD', 1);

A mod that uses the SQL will only increase farms next to fresh water (rivers or lakes) when genetics is researched (ie the second statement behaves as expected, whereas the first does not!)

I'd need to check the CivV C++ code, but it's possible the first one doesn't work for CivV either - as it's never used by Firaxis.