[GS] Great work yields

[edoipi]

Some time ago I started playing with one JFD's mods, polish leader Stanislaw. While the mod was never updated for Gathering Storm I haven't noticed any issues - until I became a suzerain of Babylon. Both the modded leader and the city state apply bonus 2 science to works of writing, and apparently those two don't stack. I looked a bit around sqls for this mod but didn't find anything wrong with it, so for a time being I assume that it is a bug withing game engine/dlls. While looking around the database dump I discovered that apart from flat bonus you can also apply percentage bonus. Quick testing showed that percentage bonus actually properly stacks! So here's idea: what if instead of giving flat 2 bonus I would give flat 1 and 200%? Such bonus by itself calculates to 2, so the base value is as desired. After implementing such bonuses for both leader and Babylon city state I got results: leader by himself gives great work of writing 2 science, Babylon by itself gives 2, and most importantly having them both gives 4! I was pretty sure that I have succeeded at hacking this issue, but unfortunately somehow after losing suzerain bonus it also removed leader bonus. However, when I tweaked bonus values to: leader +4, 50%, Babylon +1, 200%, it appears to both give correct values and behave correctly when you are no longer suzerain. Obviously I need more testing before I call it a success and I am not entirely happy with this work around since it will break if/when there will be another since bonus on great work of art in the game. I would love to hear if anyone had similar problem and if maybe someone has better fix for such issue. For the record I'm entirely new to civ modding and have not yet looked into what is possible with lua scripting.