Help needed adjusting civ bonuses (Norway and Sumeria)

[camomilk]

I've been trying to make a mod that adjusts civ bonuses, but I'm at a loss when it comes to some of them. Specifically, Norway and Sumeria are ones where it seems like my changes should be doing something, but actually has no effect.

For Sumeria, I attempted to adjust the gold rewards from barbarian camps:

INSERT INTO Modifiers (ModifierId, ModifierType)
    VALUES ('TRAIT_BARBARIAN_CAMP_GOLD_BONUS', 'MODIFIER_PLAYER_ADJUST_GOLD_DISPERSAL');

INSERT INTO ModifierArguments (ModifierId, Name, Value)
    VALUES ('TRAIT_BARBARIAN_CAMP_GOLD_BONUS', 'Amount', 200);

INSERT INTO ModifierArguments (ModifierId, Name, Value)
    VALUES ('TRAIT_BARBARIAN_CAMP_GOLD_BONUS', 'Improvement', 'IMPROVEMENT_BARBARIAN_CAMP');

INSERT INTO TraitModifiers (TraitType, ModifierId)
    VALUES ('TRAIT_CIVILIZATION_FIRST_CIVILIZATION', 'TRAIT_BARBARIAN_CAMP_GOLD_BONUS');

For Norway, I tried adding the ability to ignore rivers:

INSERT INTO TraitModifiers (TraitType, ModifierId)
    VALUES ("TRAIT_CIVILIZATION_EARLY_OCEAN_NAVIGATION", "TRAIT_IGNORE_RIVERS");

INSERT INTO Modifiers (ModifierId, ModifierType, SubjectRequirementSetId)
    VALUES (
        "TRAIT_IGNORE_RIVERS",
        "MODIFIER_PLAYER_UNITS_ADJUST_IGNORE_RIVERS",
        "UNIT_IS_DOMAIN_LAND"
    );

INSERT INTO ModifierArguments (ModifierId, Name, Value)
    VALUES ("TRAIT_IGNORE_RIVERS", "Ignore", "true");

Neither of these is having the intended effect. Am I doing something wrong?

 

[Horem]

Check your logs?

 

[camomilk]

Logs seem fine. Modding.log says "Status: Applied all components of enabled mods." Database.log says "Passed Validation."

 

[Hajee]

I am no sql expert but double quotes are bad " "

ie
"TRAIT_IGNORE_RIVERS"

 

[Hajee]

I am no sql expert but double quotes are bad " "

ie
"TRAIT_IGNORE_RIVERS"

and true in sql is 1- false is 0

 

[camomilk]

and true in sql is 1- false is 0

Brilliant! I'm not sure if it's the single quotes or the 1 instead of "true", but the ignoring rivers ability is working now. Thank you!

I am still hoping to modify the Sumerian ability to change rewards from Barbarian Camps.

 

[Hajee]

Brilliant! I'm not sure if it's the single quotes or the 1 instead of "true", but the ignoring rivers ability is working now. Thank you!

I am still hoping to modify the Sumerian ability to change rewards from Barbarian Camps.

No worries mate, I just learned that myself two days ago