I can't figure out why this lua file is not working

Craig_Sutter · Jul 27, 2012

I can't figure out why this does not work. The log is clean and the mod starts normally... but Sweden and Denmark are neutral in their relations. And the print command is not printing out their names in the log. It does not work whether or not I put the print command in... so it is not that part.

Code:

-- Lua Script2
-- Author: Craig and Nancy
-- DateCreated: 7/26/2012 8:52:58 AM
--------------------------------------------------------------
GameEvents.GetScenarioDiploModifier1.Add(function(ePlayer1, ePlayer2)


	if (ePlayer1 == GameInfo.Civilizations["CIVILIZATION_DENMARK"].ID and ePlayer2 == GameInfo.Civilizations["CIVILIZATION_SWEDEN"].ID) or  (ePlayer2 == GameInfo.Civilizations["CIVILIZATION_DENMARK"].ID and ePlayer1 == GameInfo.Civilizations["CIVILIZATION_SWEDEN"].ID) then
		
		print(ePlayer1:GetName())
		print(pPlayer2:GetName())
		
		return -50
	else
		return 0
	end
end)

Advice would be appreciated. Thank-you.

whoward69 · Jul 28, 2012

You have in InGameUIAddin entry for the file?

Craig_Sutter · Jul 28, 2012

Yes. And the logs are clean so the address was not mistyped. I amrunning several other files but they ought not to interfere with this one... I will double check when I get home by removing them as addins.

Gedemon · Jul 28, 2012

the lua log should output an error on the print statement (ePlayer1 is not an object, and pPlayer2 is not defined)

ePlayer1 and ePlayer2 are player ID, not civilization ID. You first need to get the player object using pPlayer1 = Players[ePlayer1], then the civilization ID using player:GetCivilizationType() (Firaxis naming at work...)

whoward69 · Jul 28, 2012

Gedemon said:
the lua log should output an error on the print statement (ePlayer1 is not an object, and pPlayer2 is not defined)

But due to the mistake in the condition of comparing playerId with civId the prints will never be executed, so will never generate an error (ain't dynamic languages ****)

Craig_Sutter · Jul 28, 2012

Well, I've continued to work on this, and I believe I am making progress...

Thus far,

Code:

GameEvents.GetScenarioDiploModifier1.Add(function(ePlayer1, ePlayer2)

for iPlayer=0, GameDefines.MAX_MAJOR_CIVS-1 do 
    local pPlayer = Players[iPlayer]
    if (pPlayer:IsAlive()) then

	print("This is for pPlayer")
	print(pPlayer:GetName())


		function GetCivID(civType)
			local civ = GameInfo.Civilizations[civType];
			if(civ) then
				return civ.ID;
			else
				return -1;
			end
		end

		local playerCiv = pPlayer:GetCivilizationType();
		if(playerCiv == GetCivID("CIVILIZATION_DENMARK")) then

			local ePlayer1 = pPlayer;
	
		print("This is for ePlayer1")
		print(ePlayer1:GetName())

	
		elseif(playerCiv == GetCivID("CIVILIZATION_SWEDEN")) then

			local ePlayer2 = pPlayer;

		print("This is for ePlayer2")
		print(ePlayer2:GetName())



			if (ePlayer1 == GameInfo.Civilizations["CIVILIZATION_DENMARK"] and ePlayer2 == GameInfo.Civilizations["CIVILIZATION_SWEDEN"]) then
		
		return -50
	else
		return 0
		end
	end
	end
end
	end)

And I get the following in my log file at the end:

Spoiler :

This indicates to me that I am getting the appropriate ePlayer1 and ePlayer2 (Harald is the Denmark Leader while Erik is the Swedish one).

I'm not certain why they are not being taken the one step further to do the diplomatic function at the end... I play as Denmark and check Sweden, and they are simply neutral (no additional diplomatic text, red or green, shows up).

It occurs to me that I haven't played as Sweden... I should check from that end, although I do not think it will make a difference.

I think, likely, my output in ePlayer1 and ePlayer2 is still not of the proper type.

If not, I don't know. I've tried a couple of other methods as well:

Code:

GameEvents.GetScenarioDiploModifier1.Add(function(ePlayer1, ePlayer2)

for iPlayer=0, GameDefines.MAX_MAJOR_CIVS-1 do 
    local pPlayer = Players[iPlayer]
    if (pPlayer:IsAlive()) then

	print(pPlayer:GetName())

      if (pPlayer:GetCivilizationType() == GameInfo.Civilizations["CIVILIZATION_DENMARK"]) then
		local pPlayer=ePlayer1

		print(ePlayer1:GetName())
				
		elseif (pPlayer:GetCivilizationType() == GameInfo.Civilizations["CIVILIZATION_SWEDEN"]) then
			local pPlayer=ePlayer2

		print(ePlayer2:GetName())
		
	if (ePlayer1 == GameInfo.Civilizations["CIVILIZATION_DENMARK"] and ePlayer2 == GameInfo.Civilizations["CIVILIZATION_SWEDEN"]) then
		
		return -50
	else
		return 0
		end
		end
		end
	end
end)

Returned my whole list of civ leader three times, identically, as indicated by the log. I think the code previous on this page was closer to succeeding.

Anyhow, I'm still looking at the various scenario files to dig out what I can. Any further advice would be appreciated.

Thanks.

Gedemon · Jul 28, 2012

Craig_Sutter said:
I think the code previous on this page was closer to succeeding.

yes

Try that:

Code:

-- Lua Script2
-- Author: Craig and Nancy
-- DateCreated: 7/26/2012 8:52:58 AM
--------------------------------------------------------------
GameEvents.GetScenarioDiploModifier1.Add(function(ePlayer1, ePlayer2)

	local iCiv1 = Players[ePlayer1]:GetCivilizationType()
	local iCiv2 = Players[ePlayer2]:GetCivilizationType()

	local iDenmark = GameInfo.Civilizations["CIVILIZATION_DENMARK"].ID
	local iSweden = GameInfo.Civilizations["CIVILIZATION_SWEDEN"].ID

	if (iCiv1 == iDenmark and iCiv2 == iSweden) or  (iCiv2 == iDenmark and iCiv1 == iSweden) then
		
		print(Players[ePlayer1]:GetName())
		print(Players[ePlayer2]:GetName())
		
		return -50
	else
		return 0
	end
end)

Craig_Sutter · Jul 28, 2012

Just tested for Sweden... interesting result:

Again, Denmark maintained its neutral attitude. I find it interesting, though, that the lua file seems to have run when I opened the diplomatic screen. So something is happening, just not certain what. I think, I may be getting a return of "0" rather than the dipl0matic part of the code not working at all.... although that a "0" is what would result if: if (ePlayer1 == GameInfo.Civilizations["CIVILIZATION_DENMARK"] and ePlayer2 == GameInfo.Civilizations["CIVILIZATION_SWEDEN"]) then was not true, which could be for any number of reasons.

Spoiler :

whoward69 · Jul 28, 2012

Completely untested, try

Code:

GameEvents.GetScenarioDiploModifier1.Add(function(ePlayer1, ePlayer2)
  -- This is what we are trying to achieve
  -- if ePlayer1 is Denmark (or Sweden) and ePlayer2 is Sweden (or Denmark), return -50 otherwise 0

  -- We don't want player ids, we need civ ids
  local eCiv1 = Players[ePlayer1]:GetCivilizationType()
  local eCiv2 = Players[ePlayer2]:GetCivilizationType()

  if ((eCiv1 == GameInfoTypes.CIVILIZATION_DENMARK and eCiv2 == GameInfoTypes.CIVILIZATION_SWEDEN) or 
      (eCiv1 == GameInfoTypes.CIVILIZATION_SWEDEN and eCiv2 == GameInfoTypes.CIVILIZATION_DENMARK)) then
    return -50
  else
    return 0
  end
end)

Gedemon · Jul 28, 2012

I feel invisible right now

whoward69 · Jul 28, 2012

Craig_Sutter said:

Code:

GameEvents.GetScenarioDiploModifier1.Add(function(ePlayer1, ePlayer2)

[COLOR="Red"]for iPlayer=0, GameDefines.MAX_MAJOR_CIVS-1 do 
    local pPlayer = Players[iPlayer]
    if (pPlayer:IsAlive()) then[/COLOR]
SNIP
	end)

As you already have two known player IDs the code in red is completely un-necessary. Why loop over all players when you already have the two you are interested in in hand?

Try writing in "pseudo code comments" and then translating into lua, eg

Code:

GameEvents.GetScenarioDiploModifier1.Add(function(ePlayer1, ePlayer2)
  -- If (ePlayer1 is Denmark or Sweden) then
    -- If (ePlayer2 is Sweden or Denmark) then
      -- return -50
    -- end
  -- end
  -- return 0
end)

Craig_Sutter · Jul 28, 2012

Amazing... I worked, literally, for hours on the two bits I showed here... and you did it in a matter of minutes. Excellent and thank-you.

Just so you know, Sweden still shows as neutral even though the text associated with the function shows up and is green. Not certain why he would not show up as friendly. perhaps the bonus needs to be higher to achieve that, can't recall. I'll do further testing.

Another question... can this be iterated. There are only 3 different diplomatic functions:

GetScenarioDiploModifier1
GetScenarioDiploModifier2
GetScenarioDiploModifier3

I'm hoping that these can be used with many different pairs of civilizations. I'll do some work on that later.

Again, thank-you (although I had hoped to succeed myself, somehow).

Craig_Sutter · Jul 28, 2012

Just realized I got two great responses. I used Gedemon's first, but will check out the Whoward's next... likely with no differences in the result.

The extra code is coming from my not having much of a clue as to what I am doing

. I look through the scenarios and pick what looks good or what worked in the past... not the best method I know, but I'm learning incrementally.

Just discovered how to paste into firetuner

.

Craig_Sutter · Jul 28, 2012

Thank-you for the advice about commenting, too. I had a vague idea what I was trying to do from some of Gedemon's advice, but i never outlined it as you did, and kind of lost track of the order of things in my mind... I'm not certain I was achieving the goals elicited from your advice. I think a more studied approach will do me better... and writing comments as you mentioned, will lead to a more orderly process.

Craig_Sutter · Jul 28, 2012

Same result with Whoward69's coding.

Again, for your information, I used a higher value (70), and his attitude remained neutral. I'm curious what value would be need to make him friendly... or if these diplomatic values aren't tracked properly by the UI.

I can't figure out why this lua file is not working

Craig_Sutter

Deity

whoward69

DLL Minion

Craig_Sutter

Deity

Gedemon

Modder

whoward69

DLL Minion

Craig_Sutter

Deity

Gedemon

Modder

Craig_Sutter

Deity

whoward69

DLL Minion

Gedemon

Modder

whoward69

DLL Minion

Craig_Sutter

Deity

Craig_Sutter

Deity

Craig_Sutter

Deity

Craig_Sutter

Deity

Similar threads