Modifier have no effect in game ?

[LeeS]

Have you tried taking the "permanent" out of this?

        <Row>
            <ModifierId>HIMEJI_PLAYER_UNITS_GRANT_ABILITY</ModifierId>
            <ModifierType>MODIFIER_PLAYER_UNITS_GRANT_ABILITY</ModifierType>
            <Permanent>true</Permanent>
        </Row>

Not sure if that will fix the problem but it's the first thing that occurs to me to try.

Otherwise you may need to try one of the other booleans or the "stack" limits availabel in table Modifiers

CREATE TABLE "Modifiers" (
		"ModifierId" TEXT NOT NULL,
		"ModifierType" TEXT NOT NULL,
		"RunOnce" BOOLEAN NOT NULL CHECK (RunOnce IN (0,1)) DEFAULT 0,
		"NewOnly" BOOLEAN NOT NULL CHECK (NewOnly IN (0,1)) DEFAULT 0,
		"Permanent" BOOLEAN NOT NULL CHECK (Permanent IN (0,1)) DEFAULT 0,
		"OwnerRequirementSetId" TEXT,
		"SubjectRequirementSetId" TEXT,
		"OwnerStackLimit" INTEGER,
		"SubjectStackLimit" INTEGER,
		PRIMARY KEY(ModifierId),
		FOREIGN KEY (OwnerRequirementSetId) REFERENCES RequirementSets(RequirementSetId) ON DELETE CASCADE ON UPDATE CASCADE,
		FOREIGN KEY (SubjectRequirementSetId) REFERENCES RequirementSets(RequirementSetId) ON DELETE CASCADE ON UPDATE CASCADE);

 

[Shirotora Kenshin]

@LeeS Furion Huang told me the solution. i used the wrong modifiertype it have to be this :

<ModifierType>MODIFIER_UNIT_ADJUST_COMBAT_STRENGTH</ModifierType>

thanks for all your help, got Himeji Castle fully working now , will be able to release it soon