Non functional event/lua

[CivilizationAce]

So having got all my ducks in a row (or so I thought) I added a .lua file to my mod. I added it to the in-Game Actions — AddGameplayScripts. However, not even the first print statement result appears in the Lua Console when I take a barbarian encampment. Here are the relevant parts of the code:

function OnLoadScreenClose()
    Events.ImprovementActivated.Add(OnImprovementActivated)
end

function OnImprovementActivated(iX, iY, iPlayer, moot1, iImprovementIndex, moot2, moot3, moot4)
    print("OnImprovementActivated start")
    pPlayer ~= -1 and Players[iPlayer] or Map.GetPlot(iX,iY):GetOwner()
    if iImprovementIndex == GameInfo.Improvements["IMPROVEMENT_BARBARIAN_CAMP"].Index then
        print("About to GenerateUnit")
        GenerateUnit(pPlayer,1)        -- 1/30 in final build
    end
end

Events.LoadScreenClose.Add(OnLoadScreenClose)

Anyone got any idea about what I've done wrong please?

 

[Infixo]

1. Any errors in Lua.log? 2. What is the line after print and before if supposed to do? 3. Put print into OnLoadScreenClose so you will know that you got there. 4. Just in case, put entire OnImprovementAcivated function before OnLoadScreenClose. It's really bad practice to put functions calls before actual function definition.

 

[CivilizationAce]

What is the line after print and before if supposed to do?

It deduces the player when the encampment is taken by placing a city.

 

[Infixo]

So, maybe you cut too much, but this line just computes a boolean value. It's not even stored anywhere.

 

[CivilizationAce]

Nah. I'd messed up

 

[CivilizationAce]

P.S. Thanks.

 

[LeeS]

looks like you were wanting this but just oopsed

local pPlayer = ((iPlayer == -1) and Players[Map.GetPlot(iX,iY):GetOwner()] or Players[iPlayer])

like as this

local iBarbCamp = GameInfo.Improvements["IMPROVEMENT_BARBARIAN_CAMP"].Index
function OnImprovementActivated(iX, iY, iPlayer, moot1, iImprovementIndex, moot2, moot3, moot4)
	print("OnImprovementActivated start")
	if iImprovementIndex == iBarbCamp then 
		print("Barbarian Camp Cleared")
		local pPlayer = ((iPlayer == -1) and Players[Map.GetPlot(iX,iY):GetOwner()] or Players[iPlayer])
	        print("About to GenerateUnit")
		GenerateUnit(pPlayer,1)        -- 1/30 in final build
	else
		print("The Improvement was not a Barbarian Camp")
	end
end
function OnLoadScreenClose()
    Events.ImprovementActivated.Add(OnImprovementActivated)
end
Events.LoadScreenClose.Add(OnLoadScreenClose)

You just have to make sure the code within function GenerateUnit(arg1,arg2) is written to recieve a player object rather than a player ID # as arg1

 

[CivilizationAce]

Thanks. I'd made some progress, but that helps.

 

[CivilizationAce]

TBH as far as I can tell objects rock and ID's suck. I don't know why they make functions return ID's. It may save time up-front, but it's always going to cost time later, and it results in us needing more code.